Mailinglist Archive: opensuse-factory (710 mails)

< Previous Next >
Re: [opensuse-factory] HAL and related
Am Thu, 2 Jun 2011 01:26:30 +0400
schrieb Ilya Chernykh <anixxsus@xxxxxxxxx>:

To get a security fix there should not be just maintainers, but programmers,
not just programmers, but hi-class programmers.

I for instance know one issue in ksquirrel libs
http://secunia.com/secunia_research/2008-63/ . This issue is currently can be
automatically detected by post-build-checks of OBS thus the package can only
built with the checks disabled.

Well, the fix for this issue is pretty trivial, a possible fix is attached.
No hi-class programmer needed.

As the issue is not fixed so far, one can
just choose not to include ksquirrel-libs in openSUSE, it is not a very
important package.

More relevant is, that the package is obviously abandoned by upstream
(otherwise they would have fixed that trivial bug which even the compiler
can find, no security expert needed) and thus it's a good idea to not
include it anymore.
--
Stefan Seyfried

"Dispatch war rocket Ajax to bring back his body!"
From f7ceaf9c735218e14516fad0a5c686cbbd68ad11 Mon Sep 17 00:00:00 2001
From: Stefan Seyfried <seife+obs@xxxxxxxxxxxxxx>
Date: Thu, 2 Jun 2011 10:38:50 +0200
Subject: [PATCH] fix CVE-2008-5263 by checking for buffer bounds

Signed-off-by: Stefan Seyfried <seife+obs@xxxxxxxxxxxxxx>
---
kernel/kls_hdr/fmt_codec_hdr.cpp | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/kls_hdr/fmt_codec_hdr.cpp b/kernel/kls_hdr/fmt_codec_hdr.cpp
index 4be7b26..2f04a73 100644
--- a/kernel/kls_hdr/fmt_codec_hdr.cpp
+++ b/kernel/kls_hdr/fmt_codec_hdr.cpp
@@ -317,6 +317,8 @@ bool fmt_codec::getHdrHead()
if(!frs.readK(&a, sizeof(s8))) return false;

++count;
+ if (count > 79)
+ return false;
}

buff[count] = '\0';
--
1.7.4.2

< Previous Next >
List Navigation
Follow Ups