Mailinglist Archive: opensuse-commit (1903 mails)

< Previous Next >
commit kpackage for openSUSE:Factory
Hello community,

here is the log from the commit of package kpackage for openSUSE:Factory
checked in at 2019-04-19 21:23:45
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kpackage (Old)
and /work/SRC/openSUSE:Factory/.kpackage.new.5536 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "kpackage"

Fri Apr 19 21:23:45 2019 rev:55 rq:695242 version:5.57.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/kpackage/kpackage.changes 2019-03-21
09:47:41.238878367 +0100
+++ /work/SRC/openSUSE:Factory/.kpackage.new.5536/kpackage.changes
2019-04-19 21:23:47.875829430 +0200
@@ -1,0 +2,18 @@
+Tue Apr 16 13:34:55 UTC 2019 - wbauer@xxxxxx
+
+- Add Dont-use-qAsConst-over-a-temporary-variable.patch to fix a
+ possible crash
+
+-------------------------------------------------------------------
+Sun Apr 14 20:21:44 UTC 2019 - lbeltrame@xxxxxxx
+
+- Update to 5.57.0
+ * New feature release
+ * For more details please see:
+ * https://www.kde.org/announcements/kde-frameworks-5.57.0.php
+- Changes since 5.56.0:
+ * Fix finding the host tools targets file in the Android docker environment
+ * [kpackages] compile without foreach
+ * Add cross-compilation support for kpackagetool5
+
+-------------------------------------------------------------------

Old:
----
kpackage-5.56.0.tar.xz

New:
----
Dont-use-qAsConst-over-a-temporary-variable.patch
kpackage-5.57.0.tar.xz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ kpackage.spec ++++++
--- /var/tmp/diff_new_pack.zs6s8q/_old 2019-04-19 21:23:48.499830224 +0200
+++ /var/tmp/diff_new_pack.zs6s8q/_new 2019-04-19 21:23:48.503830229 +0200
@@ -16,14 +16,14 @@
#


-%define _tar_path 5.56
+%define _tar_path 5.57
# Full KF5 version (e.g. 5.33.0)
%{!?_kf5_version: %global _kf5_version %{version}}
# Last major and minor KF5 version (e.g. 5.33)
%{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} |
awk -F. '{print $1"."$2}')}
%bcond_without lang
Name: kpackage
-Version: 5.56.0
+Version: 5.57.0
Release: 0
Summary: Non-binary asset user-installable package managing framework
License: LGPL-2.1-or-later
@@ -31,6 +31,8 @@
URL: https://www.kde.org
Source:
http://download.kde.org/stable/frameworks/%{_tar_path}/%{name}-%{version}.tar.xz
Source1: baselibs.conf
+# PATCH-FIX-UPSTREAM
+Patch0: Dont-use-qAsConst-over-a-temporary-variable.patch
BuildRequires: cmake >= 3.0
BuildRequires: extra-cmake-modules >= %{_kf5_bugfix_version}
BuildRequires: fdupes
@@ -66,6 +68,7 @@
%if 0%{?suse_version} == 1500
sed -i -e "s/^set *(REQUIRED_QT_VERSION 5.10.0)$/set(REQUIRED_QT_VERSION
5.9.0)/" CMakeLists.txt
%endif
+%autopatch -p1

%build
%cmake_kf5 -d build -- -DSYSCONF_INSTALL_DIR=%{_kf5_sysconfdir}

++++++ Dont-use-qAsConst-over-a-temporary-variable.patch ++++++
From c3e896e02f9a8dc92d6e26cdbc87fe5c6b9cf3bf Mon Sep 17 00:00:00 2001
From: David Faure <faure@xxxxxxx>
Date: Sun, 14 Apr 2019 19:44:50 +0200
Subject: Don't use qAsConst over a temporary variable

Summary:
(will crash because the temporary will be destroyed before being used)

Detected with
ag -sr qAsConst'\([^)]*\(' .

Test Plan: builds

Reviewers: mlaurent, cfeck, apol

Reviewed By: mlaurent

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20552
---
src/kpackage/package.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/kpackage/package.cpp b/src/kpackage/package.cpp
index 130eec6..801f1c2 100644
--- a/src/kpackage/package.cpp
+++ b/src/kpackage/package.cpp
@@ -429,7 +429,8 @@ QStringList Package::entryList(const QByteArray &key) const
QStringList list;
for (const QString &prefix : qAsConst(d->contentsPrefixPaths)) {
//qCDebug(KPACKAGE_LOG) << " looking in" << prefix;
- for (const QString &path : qAsConst(it.value().paths)) {
+ const QStringList paths = it.value().paths;
+ for (const QString &path : paths) {
//qCDebug(KPACKAGE_LOG) << " looking in" << path;
if (it.value().directory) {
//qCDebug(KPACKAGE_LOG) << "it's a directory, so trying out"
<< d->path + prefix + path;
--
cgit v1.1

++++++ kpackage-5.56.0.tar.xz -> kpackage-5.57.0.tar.xz ++++++
++++ 14936 lines of diff (skipped)


< Previous Next >
This Thread
  • No further messages