Hello community, here is the log from the commit of package kidletime for openSUSE:Factory checked in at 2019-04-19 21:22:51 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kidletime (Old) and /work/SRC/openSUSE:Factory/.kidletime.new.5536 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "kidletime" Fri Apr 19 21:22:51 2019 rev:65 rq:695227 version:5.57.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kidletime/kidletime.changes 2019-03-21 09:46:10.886899183 +0100 +++ /work/SRC/openSUSE:Factory/.kidletime.new.5536/kidletime.changes 2019-04-19 21:22:56.967764594 +0200 @@ -1,0 +2,11 @@ +Sun Apr 14 20:21:43 UTC 2019 - lbeltrame@kde.org + +- Update to 5.57.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.57.0.php +- Changes since 5.56.0: + * Port foreach here + * compile without foreach + +------------------------------------------------------------------- Old: ---- kidletime-5.56.0.tar.xz New: ---- kidletime-5.57.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kidletime.spec ++++++ --- /var/tmp/diff_new_pack.jljcQG/_old 2019-04-19 21:22:58.267766250 +0200 +++ /var/tmp/diff_new_pack.jljcQG/_new 2019-04-19 21:22:58.271766255 +0200 @@ -17,13 +17,13 @@ %define lname libKF5IdleTime5 -%define _tar_path 5.56 +%define _tar_path 5.57 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: kidletime -Version: 5.56.0 +Version: 5.57.0 Release: 0 Summary: User and system idle time reporting singleton License: LGPL-2.1-or-later ++++++ kidletime-5.56.0.tar.xz -> kidletime-5.57.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kidletime-5.56.0/.gitignore new/kidletime-5.57.0/.gitignore --- old/kidletime-5.56.0/.gitignore 1970-01-01 01:00:00.000000000 +0100 +++ new/kidletime-5.57.0/.gitignore 2019-04-07 09:18:41.000000000 +0200 @@ -0,0 +1,21 @@ +# Ignore the following files +*~ +*.[oa] +*.diff +*.kate-swp +*.kdev4 +.kdev_include_paths +*.kdevelop.pcs +*.moc +*.moc.cpp +*.orig +*.user +.*.swp +.swp.* +Doxyfile +Makefile +avail +random_seed +/build*/ +CMakeLists.txt.user* +*.unc-backup* diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kidletime-5.56.0/CMakeLists.txt new/kidletime-5.57.0/CMakeLists.txt --- old/kidletime-5.56.0/CMakeLists.txt 2019-03-02 14:27:06.000000000 +0100 +++ new/kidletime-5.57.0/CMakeLists.txt 2019-04-07 09:18:41.000000000 +0200 @@ -1,11 +1,11 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.56.0") # handled by release scripts +set(KF5_VERSION "5.57.0") # handled by release scripts project(KIdleTime VERSION ${KF5_VERSION}) # ECM setup include(FeatureSummary) -find_package(ECM 5.56.0 NO_MODULE) +find_package(ECM 5.57.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules") feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -76,7 +76,7 @@ option(BUILD_QCH "Build API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)" OFF) add_feature_info(QCH ${BUILD_QCH} "API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)") - +add_definitions(-DQT_NO_FOREACH) # Subdirectories add_subdirectory(src) add_subdirectory(examples) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kidletime-5.56.0/src/kidletime.cpp new/kidletime-5.57.0/src/kidletime.cpp --- old/kidletime-5.56.0/src/kidletime.cpp 2019-03-02 14:27:06.000000000 +0100 +++ new/kidletime-5.57.0/src/kidletime.cpp 2019-04-07 09:18:41.000000000 +0200 @@ -171,12 +171,13 @@ static QStringList pluginCandidates() { QStringList ret; - foreach (const QString &path, QCoreApplication::libraryPaths()) { - QDir pluginDir(path + QLatin1String("/kf5/org.kde.kidletime.platforms")); + const QStringList libPath = QCoreApplication::libraryPaths(); + for (const QString &path : libPath ) { + const QDir pluginDir(path + QLatin1String("/kf5/org.kde.kidletime.platforms")); if (!pluginDir.exists()) { continue; } - foreach (const QString &entry, pluginDir.entryList(QDir::Files | QDir::NoDotAndDotDot)) { + for (const QString &entry : pluginDir.entryList(QDir::Files | QDir::NoDotAndDotDot)) { ret << pluginDir.absoluteFilePath(entry); } } @@ -185,7 +186,8 @@ static AbstractSystemPoller *loadPoller() { - foreach (const QString &candidate, pluginCandidates()) { + const QStringList lstPlugins = pluginCandidates(); + for (const QString &candidate : lstPlugins) { if (!QLibrary::isLibrary(candidate)) { continue; } @@ -249,7 +251,8 @@ Q_Q(KIdleTime); if (associations.values().contains(msec)) { - Q_FOREACH (int key, associations.keys(msec)) { + const auto listKeys = associations.keys(msec); + for (int key : listKeys) { emit q->timeoutReached(key); emit q->timeoutReached(key, msec); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kidletime-5.56.0/src/plugins/osx/macpoller.cpp new/kidletime-5.57.0/src/plugins/osx/macpoller.cpp --- old/kidletime-5.56.0/src/plugins/osx/macpoller.cpp 2019-03-02 14:27:06.000000000 +0100 +++ new/kidletime-5.57.0/src/plugins/osx/macpoller.cpp 2019-04-07 09:18:41.000000000 +0200 @@ -182,7 +182,7 @@ int idle = m_secondsIdle * 1000; // Check if we reached a timeout.. - Q_FOREACH (int i, m_timeouts) { + for (int i : qAsConst(m_timeouts)) { if ((i - idle < 1000 && i > idle) || (idle - i < 1000 && idle > i)) { // Bingo! emit timeoutReached(i); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kidletime-5.56.0/src/widgetbasedpoller.cpp new/kidletime-5.57.0/src/widgetbasedpoller.cpp --- old/kidletime-5.56.0/src/widgetbasedpoller.cpp 2019-03-02 14:27:06.000000000 +0100 +++ new/kidletime-5.57.0/src/widgetbasedpoller.cpp 2019-04-07 09:18:41.000000000 +0200 @@ -114,7 +114,7 @@ int idle = getIdleTime(); // Check if we reached a timeout.. - Q_FOREACH(int timeOut, m_timeouts) { + for(int timeOut : qAsConst(m_timeouts)) { if ( ( timeOut - idle < 300 && timeOut >= idle ) || ( idle - timeOut < 300 && idle > timeOut ) ) { // Bingo! emit timeoutReached( timeOut ); @@ -124,7 +124,7 @@ // Let's check the timer now! int mintime = 0; - Q_FOREACH (int i, m_timeouts) { + for (int i : qAsConst(m_timeouts)) { if (i > idle && (i < mintime || mintime == 0)) { mintime = i; }