Hello community, here is the log from the commit of package siproxd for openSUSE:Factory checked in at 2019-04-02 09:23:55 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/siproxd (Old) and /work/SRC/openSUSE:Factory/.siproxd.new.25356 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "siproxd" Tue Apr 2 09:23:55 2019 rev:36 rq:690484 version:0.8.2 Changes: -------- --- /work/SRC/openSUSE:Factory/siproxd/siproxd.changes 2019-03-18 10:40:59.755299609 +0100 +++ /work/SRC/openSUSE:Factory/.siproxd.new.25356/siproxd.changes 2019-04-02 09:24:02.412779745 +0200 @@ -1,0 +2,7 @@ +Fri Mar 15 20:28:22 UTC 2019 - Jan Engelhardt <jengelh@inai.de> + +- Do not hide errors from useradd. +- Replace %__-type macro indirections. +- Remove redundant %clean section. + +------------------------------------------------------------------- @@ -294 +300,0 @@ - ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ siproxd.spec ++++++ --- /var/tmp/diff_new_pack.sQOrsX/_old 2019-04-02 09:24:03.232780295 +0200 +++ /var/tmp/diff_new_pack.sQOrsX/_new 2019-04-02 09:24:03.236780297 +0200 @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # @@ -29,7 +29,7 @@ Version: 0.8.2 Release: 0 Summary: A SIP masquerading proxy with RTP support -License: GPL-2.0+ +License: GPL-2.0-or-later Group: Productivity/Networking/Other Url: http://siproxd.sourceforge.net/ Source0: %{name}-%{version}.tar.bz2 @@ -87,7 +87,7 @@ Group: Documentation/Other %description doc -HTML and pdf documentation for %{name} +HTML and PDF documentation for %{name} %prep %setup -q @@ -100,54 +100,46 @@ %build autoreconf --install --force -CFLAGS="%{optflags} -fno-strict-aliasing" ./configure \ - --prefix=%{_prefix} \ - --sysconfdir=%{_sysconfdir} \ - --disable-static \ - --libdir=%{_libdir}\ - --docdir=%{_defaultdocdir} - -%{__make} %{?_smp_mflags} +CFLAGS="%{optflags} -fno-strict-aliasing" +%configure --disable-static +make %{?_smp_mflags} %install %make_install find %{buildroot} -type f -name "*.la" -delete -print -%{__mkdir} -p %{buildroot}%{_sysconfdir}/%{name} -%{__mv} %{buildroot}%{_sysconfdir}/%{name}.conf.example \ +mkdir -p %{buildroot}%{_sysconfdir}/%{name} +mv %{buildroot}%{_sysconfdir}/%{name}.conf.example \ %{buildroot}%{_sysconfdir}/%{name}/%{name}.conf -%{__install} -d %{buildroot}%{_sysconfdir}/sysconfig/SuSEfirewall2.d/services/ -%{__install} -m 644 %{S:1} %{buildroot}%{_sysconfdir}/sysconfig/SuSEfirewall2.d/services/%{name} +install -d %{buildroot}/%{_sysconfdir}/sysconfig/SuSEfirewall2.d/services/ +install -m 644 %{S:1} %{buildroot}/%{_sysconfdir}/sysconfig/SuSEfirewall2.d/services/%{name} -%{__install} -d %buildroot/%{_sysconfdir}/logrotate.d/ -%{__install} -m 0644 %{S:3} %buildroot/%{_sysconfdir}/logrotate.d/%{name} +install -d %{buildroot}/%{_sysconfdir}/logrotate.d/ +install -m 0644 %{S:3} %{buildroot}/%{_sysconfdir}/logrotate.d/%{name} -%{__install} -d %{buildroot}%{_datadir}/%{name}/scripts -%{__install} %{S:2} %{buildroot}%{_datadir}/%{name}/scripts/%{name} -%{__install} -d %{buildroot}%{_unitdir} -%{__install} -m 644 %{S:6} %{buildroot}%{_unitdir} -%{__sed} -i "s#@%{name}_PIDDIR@#%{_rundir}/%{name}#" %{buildroot}%{_datadir}/%{name}/scripts/%{name} -%{__install} -d %buildroot/%{_sbindir} -%{__ln_s} %{_sbindir}/service %buildroot/%{_sbindir}/rc%{name} +install -d %{buildroot}/%{_datadir}/%{name}/scripts +install %{S:2} %{buildroot}/%{_datadir}/%{name}/scripts/%{name} +install -d %{buildroot}/%{_unitdir} +install -m 644 %{S:6} %{buildroot}/%{_unitdir} +sed -i "s#@%{name}_PIDDIR@#%{_rundir}/%{name}#" %{buildroot}%{_datadir}/%{name}/scripts/%{name} +install -d %buildroot/%{_sbindir} +ln -s %{_sbindir}/service %buildroot/%{_sbindir}/rc%{name} -%{__mkdir} -p %buildroot%_mandir/man8 -%__install -m 0644 %{S:4} %{buildroot}%{_mandir}/man8/%name.8.gz +mkdir -p %buildroot%_mandir/man8 +install -m 0644 %{S:4} %{buildroot}/%{_mandir}/man8/%name.8.gz # sed -i -e "s@nobody@%{siproxduser}@" %{buildroot}%{_sysconfdir}/%{name}/%{name}.conf sed -i -e "s@nobody@%{siproxduser}@" %{buildroot}%{_datadir}/%{name}/scripts/%{name} # # Directory needs to exist for packaging %if %suse_version > 1120 -%{__mkdir} -p %buildroot%{_rundir}/%{name} +mkdir -p %{buildroot}/%{_rundir}/%{name} %endif # cleanup -%{__rm} -f %{buildroot}%{_sysconfdir}/siproxd_passwd.cfg -%{__rm} -f %{buildroot}%{_libdir}/%{name}/*.a -%{__rm} -rf %{buildroot}/usr/share/doc/%{name} - -%clean -%{__rm} -rf %{buildroot} +rm -f %{buildroot}/%{_sysconfdir}/siproxd_passwd.cfg +rm -f %{buildroot}/%{_libdir}/%{name}/*.a +rm -rf %{buildroot}/usr/share/doc/%{name} %post /sbin/ldconfig @@ -155,8 +147,11 @@ %pre %service_add_pre siproxd.service -%{_sbindir}/groupadd -r %{sipproxdgroup} 2> /dev/null || : -%{_sbindir}/useradd -r -g %{sipproxdgroup} -s /bin/false -c "Siproxd user" -d %{_rundir}/%{name} %{siproxduser} 2> /dev/null || : +getent group %{siproxdgroup} >/dev/null || \ + %{_sbindir}/groupadd -r %{siproxdgroup} +getent passwd %{siproxduser} >/dev/null || \ + %{_sbindir}/useradd -r -g %{siproxdgroup} -s /bin/false \ + -c "Siproxd user" -d %{_rundir}/%{name} %{siproxduser} %postun %service_del_postun siproxd.service