Hello community,
here is the log from the commit of package yast2 for openSUSE:Factory checked in at 2019-03-06 19:03:11
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2 (Old)
and /work/SRC/openSUSE:Factory/.yast2.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2"
Wed Mar 6 19:03:11 2019 rev:445 rq:682117 version:4.1.60
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2/yast2.changes 2019-02-28 21:47:22.897423167 +0100
+++ /work/SRC/openSUSE:Factory/.yast2.new.28833/yast2.changes 2019-03-06 19:03:15.957076892 +0100
@@ -1,0 +2,28 @@
+Wed Mar 06 12:09:35 CET 2019 - aschnell@suse.com
+
+- added "Modify" button label (related to gh#yast/yast-yast2#713)
+- 4.1.60
+
+-------------------------------------------------------------------
+Tue Mar 5 09:41:23 UTC 2019 - Ladislav Slezák
+
+- Added command line support also for the other Report module
+ methods (related to bnc#1127685)
+- 4.1.59
+
+-------------------------------------------------------------------
+Tue Mar 5 08:00:03 UTC 2019 - Ladislav Slezák
+
+- Fixed a failing testsuite, the Report.LongError used in the
+ global exception handler did not support the command line mode
+ (related to bnc#1127685)
+- 4.1.58
+
+-------------------------------------------------------------------
+Mon Mar 4 09:02:22 UTC 2019 - Michal Filka
+
+- bnc#1127685
+ - made Report module long message reporting popups adjustable
+- 4.1.57
+
+-------------------------------------------------------------------
Old:
----
yast2-4.1.56.tar.bz2
New:
----
yast2-4.1.60.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2.spec ++++++
--- /var/tmp/diff_new_pack.1y3EG4/_old 2019-03-06 19:03:16.769076697 +0100
+++ /var/tmp/diff_new_pack.1y3EG4/_new 2019-03-06 19:03:16.773076696 +0100
@@ -17,7 +17,7 @@
Name: yast2
-Version: 4.1.56
+Version: 4.1.60
Release: 0
Summary: YaST2 - Main Package
License: GPL-2.0-only
++++++ yast2-4.1.56.tar.bz2 -> yast2-4.1.60.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.1.56/library/commandline/test/commandline_test.rb new/yast2-4.1.60/library/commandline/test/commandline_test.rb
--- old/yast2-4.1.56/library/commandline/test/commandline_test.rb 2019-02-27 13:38:25.000000000 +0100
+++ new/yast2-4.1.60/library/commandline/test/commandline_test.rb 2019-03-06 12:35:40.000000000 +0100
@@ -19,18 +19,22 @@
allow(Yast::Debugger).to receive(:installed?).and_return(false)
end
+ # NOTE: when using the byebug debugger here temporarily comment out
+ # all "expect($stdout)" lines otherwise the byebug output will be
+ # lost in the rspec mocks and you won't see anything.
+
it "invokes initialize, handler and finish" do
- expect(STDOUT).to receive(:puts).with("Initialize called").ordered
- expect(STDOUT).to receive(:puts).with("something").ordered
- expect(STDOUT).to receive(:puts).with("Finish called").ordered
+ expect($stdout).to receive(:puts).with("Initialize called").ordered
+ expect($stdout).to receive(:puts).with("something").ordered
+ expect($stdout).to receive(:puts).with("Finish called").ordered
Yast::WFM.CallFunction("dummy_cmdline", ["echo", "text=something"])
end
it "displays errors and aborts" do
- expect(STDOUT).to receive(:puts).with("Initialize called").ordered
+ expect($stdout).to receive(:puts).with("Initialize called").ordered
expect(Yast::CommandLine).to receive(:Print).with(/I crashed/).ordered
- expect(STDOUT).to_not receive(:puts).with("Finish called")
+ expect($stdout).to_not receive(:puts).with("Finish called")
Yast::WFM.CallFunction("dummy_cmdline", ["crash"])
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.1.56/library/general/src/modules/Label.rb new/yast2-4.1.60/library/general/src/modules/Label.rb
--- old/yast2-4.1.56/library/general/src/modules/Label.rb 2019-02-27 13:38:25.000000000 +0100
+++ new/yast2-4.1.60/library/general/src/modules/Label.rb 2019-03-06 12:35:40.000000000 +0100
@@ -184,6 +184,12 @@
_("Remo&ve")
end
+ # Modify Button
+ def ModifyButton
+ # Button label
+ _("&Modify")
+ end
+
# Refresh Button
def RefreshButton
# Button label
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.1.56/library/general/src/modules/Report.rb new/yast2-4.1.60/library/general/src/modules/Report.rb
--- old/yast2-4.1.56/library/general/src/modules/Report.rb 2019-02-27 13:38:25.000000000 +0100
+++ new/yast2-4.1.60/library/general/src/modules/Report.rb 2019-03-06 12:35:40.000000000 +0100
@@ -478,7 +478,9 @@
Builtins.y2milestone(1, "%1", message_string) if @log_messages
if @display_messages
- if Ops.greater_than(@timeout_messages, 0)
+ if Mode.commandline
+ CommandLine.Print(message_string)
+ elsif Ops.greater_than(@timeout_messages, 0)
Popup.TimedMessage(message_string, @timeout_messages)
else
Popup.Message(message_string)
@@ -492,15 +494,19 @@
# Store new message text, the text is displayed in a richtext widget - long lines are automatically wrapped
# @param [String] message_string message text (it can contain rich text tags)
+ # @param width [Integer] width of popup (@see Popup#LongMessageGeometry)
+ # @param height [Integer] height of popup (@see Popup#LongMessageGeometry)
# @return [void]
- def LongMessage(message_string)
+ def LongMessage(message_string, width: 60, height: 10)
Builtins.y2milestone(1, "%1", message_string) if @log_messages
if @display_messages
- if Ops.greater_than(@timeout_messages, 0)
- Popup.TimedLongMessage(message_string, @timeout_messages)
+ if Mode.commandline
+ CommandLine.Print(message_string)
+ elsif Ops.greater_than(@timeout_messages, 0)
+ Popup.TimedLongMessageGeometry(message_string, @timeout_messages, width, height)
else
- Popup.LongMessage(message_string)
+ Popup.LongMessageGeometry(message_string, width, height)
end
end
@@ -517,7 +523,11 @@
Builtins.y2milestone(1, "%1", message_string) if @log_errors
if @display_errors
- if Ops.greater_than(@timeout_errors, 0)
+ if Mode.commandline
+ CommandLine.Print(headline_string)
+ CommandLine.Print("\n\n")
+ CommandLine.Print(message_string)
+ elsif Ops.greater_than(@timeout_errors, 0)
Popup.ShowTextTimed(headline_string, message_string, @timeout_errors)
else
Popup.ShowText(headline_string, message_string)
@@ -552,15 +562,19 @@
# Store new warning text, the text is displayed in a richtext widget - long lines are automatically wrapped
# @param [String] warning_string warning text (it can contain rich text tags)
+ # @param width [Integer] width of popup (@see Popup#LongWarningGeometry)
+ # @param height [Integer] height of popup (@see Popup#LongWarningGeometry)
# @return [void]
- def LongWarning(warning_string)
+ def LongWarning(warning_string, width: 60, height: 10)
Builtins.y2warning(1, "%1", warning_string) if @log_warnings
if @display_warnings
- if Ops.greater_than(@timeout_warnings, 0)
- Popup.TimedLongWarning(warning_string, @timeout_warnings)
+ if Mode.commandline
+ CommandLine.Print("Warning: #{error_string}")
+ elsif Ops.greater_than(@timeout_warnings, 0)
+ Popup.TimedLongWarningGeometry(warning_string, @timeout_warnings, width, height)
else
- Popup.LongWarning(warning_string)
+ Popup.LongWarningGeometry(warning_string, width, height)
end
end
@@ -594,15 +608,19 @@
# Store new error text, the text is displayed in a richtext widget - long lines are automatically wrapped
# @param [String] error_string error text (it can contain rich text tags)
+ # @param width [Integer] width of popup (@see Popup#LongErrorGeometry)
+ # @param height [Integer] height of popup (@see Popup#LongErrorGeometry)
# @return [void]
- def LongError(error_string)
+ def LongError(error_string, width: 60, height: 10)
Builtins.y2error(1, "%1", error_string) if @log_errors
if @display_errors
- if Ops.greater_than(@timeout_errors, 0)
- Popup.TimedLongError(error_string, @timeout_errors)
+ if Mode.commandline
+ CommandLine.Print "Error: #{error_string}"
+ elsif Ops.greater_than(@timeout_errors, 0)
+ Popup.TimedLongErrorGeometry(error_string, @timeout_errors, width, height)
else
- Popup.LongError(error_string)
+ Popup.LongErrorGeometry(error_string, width, height)
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.1.56/library/general/test/report_test.rb new/yast2-4.1.60/library/general/test/report_test.rb
--- old/yast2-4.1.56/library/general/test/report_test.rb 2019-02-27 13:38:25.000000000 +0100
+++ new/yast2-4.1.60/library/general/test/report_test.rb 2019-03-06 12:35:40.000000000 +0100
@@ -44,15 +44,15 @@
let(:show) { false }
it "does not show a popup" do
- expect(Yast::Popup).to_not receive(meth)
+ expect(Yast::Popup).to_not receive("#{meth}Geometry")
subject.send(meth, "Message")
end
end
context "when display of messages is enabled" do
it "shows a popup" do
- expect(Yast::Popup).to receive(meth)
- .with("Message")
+ expect(Yast::Popup).to receive("#{meth}Geometry")
+ .with("Message", instance_of(Integer), instance_of(Integer))
subject.send(meth, "Message")
end
end
@@ -62,8 +62,8 @@
let(:timeout) { 1 }
it "shows a timed popup" do
- expect(Yast::Popup).to receive("Timed#{meth}")
- .with("Message", 1)
+ expect(Yast::Popup).to receive("Timed#{meth}Geometry")
+ .with("Message", 1, instance_of(Integer), instance_of(Integer))
subject.send(meth, "Message")
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.1.56/package/yast2.changes new/yast2-4.1.60/package/yast2.changes
--- old/yast2-4.1.56/package/yast2.changes 2019-02-27 13:38:25.000000000 +0100
+++ new/yast2-4.1.60/package/yast2.changes 2019-03-06 12:35:40.000000000 +0100
@@ -1,4 +1,32 @@
-------------------------------------------------------------------
+Wed Mar 06 12:09:35 CET 2019 - aschnell@suse.com
+
+- added "Modify" button label (related to gh#yast/yast-yast2#713)
+- 4.1.60
+
+-------------------------------------------------------------------
+Tue Mar 5 09:41:23 UTC 2019 - Ladislav Slezák
+
+- Added command line support also for the other Report module
+ methods (related to bnc#1127685)
+- 4.1.59
+
+-------------------------------------------------------------------
+Tue Mar 5 08:00:03 UTC 2019 - Ladislav Slezák
+
+- Fixed a failing testsuite, the Report.LongError used in the
+ global exception handler did not support the command line mode
+ (related to bnc#1127685)
+- 4.1.58
+
+-------------------------------------------------------------------
+Mon Mar 4 09:02:22 UTC 2019 - Michal Filka
+
+- bnc#1127685
+ - made Report module long message reporting popups adjustable
+- 4.1.57
+
+-------------------------------------------------------------------
Wed Feb 27 12:10:49 UTC 2019 - mvidner@suse.com
- Use /sbin/rpcinfo only, /usr/sbin/rpcinfo is gone (bsc#1127138).
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.1.56/package/yast2.spec new/yast2-4.1.60/package/yast2.spec
--- old/yast2-4.1.56/package/yast2.spec 2019-02-27 13:38:25.000000000 +0100
+++ new/yast2-4.1.60/package/yast2.spec 2019-03-06 12:35:40.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2
-Version: 4.1.56
+Version: 4.1.60
Release: 0
Summary: YaST2 - Main Package
License: GPL-2.0-only