Hello community,
here is the log from the commit of package libappindicator for openSUSE:Factory checked in at 2019-02-04 21:17:05
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libappindicator (Old)
and /work/SRC/openSUSE:Factory/.libappindicator.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libappindicator"
Mon Feb 4 21:17:05 2019 rev:10 rq:665366 version:12.10.1+bzr20170215
Changes:
--------
--- /work/SRC/openSUSE:Factory/libappindicator/libappindicator.changes 2018-03-14 19:26:05.800777844 +0100
+++ /work/SRC/openSUSE:Factory/.libappindicator.new.28833/libappindicator.changes 2019-02-04 21:17:05.847743609 +0100
@@ -1,0 +2,7 @@
+Sun Jan 13 19:146:00 UTC 2019 - ximi.obs@gmail.com
+
+- Changed the activate-support patch to signal an "activate-event"
+ so users can create callbacks themselves.
+ Original patch from Yichao Yu .
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libappindicator.spec ++++++
--- /var/tmp/diff_new_pack.LneLPq/_old 2019-02-04 21:17:06.603743326 +0100
+++ /var/tmp/diff_new_pack.LneLPq/_new 2019-02-04 21:17:06.615743321 +0100
@@ -1,7 +1,7 @@
#
# spec file for package libappindicator
#
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
@@ -26,13 +26,13 @@
Version: 12.10.1+bzr20170215
Release: 0
Summary: Application indicators library
-License: LGPL-2.0 AND LGPL-3.0 AND GPL-3.0
+License: LGPL-2.0-only AND LGPL-3.0-only AND GPL-3.0-only
Group: System/Libraries
URL: https://launchpad.net/libappindicator
Source: https://launchpad.net/ubuntu/+archive/primary/+files/%{name}_%{_version}.orig.tar.gz
# PATCH-FIX-UPSTREAM 0001_Fix_mono_dir.patch hrvoje.senjan@gmail.com -- Fix location of .pc files.
Patch0: 0001_Fix_mono_dir.patch
-# PATCH-FIX-OPENSUSE libappindicator-activate-support.patch sor.alexei@meowr.ru -- Open menu on the left-click action.
+# PATCH-FIX-OPENSUSE libappindicator-activate-support.patch yyc1992@gmail.com -- Send "activate-event" signal on the left-click action.
Patch1: libappindicator-activate-support.patch
# PATCH-FIX=UPSTREAM libappindicator-no-Werror.patch dimstar@opensuse.org -- Don't add -Werror on build: the code is aging and does not keep up
Patch2: libappindicator-no-Werror.patch
@@ -194,7 +194,6 @@
%postun -n libappindicator3-%{sover} -p /sbin/ldconfig
%files -n python2-appindicator
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%dir %{python_sitearch}/appindicator/
@@ -206,19 +205,16 @@
%{_datadir}/pygtk/2.0/defs/appindicator.defs
%files -n libappindicator%{sover}
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%{_libdir}/libappindicator.so.%{sover}*
%files -n typelib-1_0-AppIndicator-0_1
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%{_libdir}/girepository-1.0/AppIndicator-0.1.typelib
%files devel
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%dir %{_includedir}/libappindicator-0.1/
@@ -231,19 +227,16 @@
%{_datadir}/vala/vapi/appindicator-0.1.deps
%files -n libappindicator3-%{sover}
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%{_libdir}/libappindicator3.so.%{sover}*
%files -n typelib-1_0-AppIndicator3-0_1
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%{_libdir}/girepository-1.0/AppIndicator3-0.1.typelib
%files -n libappindicator3-devel
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%dir %{_includedir}/libappindicator3-0.1/
@@ -257,7 +250,6 @@
%if %{with mono}
%files -n appindicator-sharp
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%dir %{_libdir}/appindicator-sharp-0.1/
@@ -280,7 +272,6 @@
%{_libexecdir}/mono/gac/policy.0.0.appindicator-sharp/*/policy.0.0.appindicator-sharp.dll
%files -n appindicator-sharp-devel
-%defattr(-,root,root)
%license COPYING COPYING.LGPL.2.1
%doc README
%{_libdir}/pkgconfig/appindicator-sharp-0.1.pc
++++++ libappindicator-activate-support.patch ++++++
--- /var/tmp/diff_new_pack.LneLPq/_old 2019-02-04 21:17:06.647743310 +0100
+++ /var/tmp/diff_new_pack.LneLPq/_new 2019-02-04 21:17:06.647743310 +0100
@@ -1,28 +1,126 @@
+--- a/bindings/mono/libappindicator-api.metadata
++++ b/bindings/mono/libappindicator-api.metadata
+@@ -13,6 +13,8 @@
+ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='connection_changed']" name="cname">connection-changed</attr>
+ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='scroll_event']" name="name">ScrollEvent</attr>
+ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='scroll_event']" name="cname">scroll-event</attr>
++ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='activate_event']" name="name">ActivateEvent</attr>
++ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='activate_event']" name="cname">activate-event</attr>
+ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='new_icon']" name="name">NewIcon</attr>
+ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='new_icon']" name="cname">new-icon</attr>
+ <attr path="/api/namespace/object[@cname='AppIndicator']/signal[@field_name='new_icon_theme_path']" name="name">NewIconThemePath</attr>
--- a/src/app-indicator.c
+++ b/src/app-indicator.c
-@@ -1188,6 +1188,12 @@ bus_method_call (GDBusConnection * conne
+@@ -115,6 +115,7 @@ enum {
+ CONNECTION_CHANGED,
+ NEW_ICON_THEME_PATH,
+ SCROLL_EVENT,
++ ACTIVATE_EVENT,
+ LAST_SIGNAL
+ };
+
+@@ -603,6 +604,20 @@ app_indicator_class_init (AppIndicatorCl
+ _application_service_marshal_VOID__INT_UINT,
+ G_TYPE_NONE, 2, G_TYPE_INT, GDK_TYPE_SCROLL_DIRECTION);
+
++ /**
++ * AppIndicator::activate-event:
++ * @arg0: The #AppIndicator object
++ *
++ * Signaled when the #AppIndicator receives a activate event.
++ */
++ signals[ACTIVATE_EVENT] = g_signal_new(APP_INDICATOR_SIGNAL_ACTIVATE_EVENT,
++ G_TYPE_FROM_CLASS(klass),
++ G_SIGNAL_RUN_LAST,
++ G_STRUCT_OFFSET (AppIndicatorClass, activate_event),
++ NULL, NULL,
++ NULL,
++ G_TYPE_NONE, 0);
++
+ /* DBus interfaces */
+ if (item_node_info == NULL) {
+ GError * error = NULL;
+@@ -1188,6 +1203,8 @@ bus_method_call (GDBusConnection * conne
{
gtk_widget_activate (menuitem);
}
+ } else if (g_strcmp0(method, "Activate") == 0) {
-+ GtkMenu * menu = app_indicator_get_menu(app);
-+ if (menu != NULL) {
-+ gtk_menu_popup(menu, NULL, NULL, NULL, NULL, 1,
-+ gtk_get_current_event_time());
-+ }
++ g_signal_emit(G_OBJECT(app), signals[ACTIVATE_EVENT], 0);
} else {
g_warning("Calling method '%s' on the app-indicator and it's unknown", method);
}
+@@ -1224,6 +1241,13 @@ bus_get_prop (GDBusConnection * connecti
+ return g_variant_new_string(priv->absolute_attention_icon_name);
+ }
+ return g_variant_new_string(priv->attention_icon_name ? priv->attention_icon_name : "");
++ } else if (g_strcmp0(property, "ToolTip") == 0) {
++ const char *title = priv->title;
++ if (!title)
++ title = g_get_application_name();
++ if (!title)
++ title = "";
++ return g_variant_new ("(sa(iiay)ss)", priv->icon_name, NULL, title, "");
+ } else if (g_strcmp0(property, "Title") == 0) {
+ const gchar * output = NULL;
+ if (priv->title == NULL) {
+@@ -1676,19 +1700,7 @@ status_icon_changes (AppIndicator * self
+ static void
+ status_icon_activate (GtkStatusIcon * icon, gpointer data)
+ {
+- GtkMenu * menu = app_indicator_get_menu(APP_INDICATOR(data));
+- if (menu == NULL)
+- return;
+-
+- gtk_menu_popup(menu,
+- NULL, /* Parent Menu */
+- NULL, /* Parent item */
+- gtk_status_icon_position_menu,
+- icon,
+- 1, /* Button */
+- gtk_get_current_event_time());
+-
+- return;
++ g_signal_emit(G_OBJECT(data), signals[ACTIVATE_EVENT], 0);
+ }
+
+ /* Handles the right-click action by the status icon by showing
+--- a/src/app-indicator.h
++++ b/src/app-indicator.h
+@@ -119,6 +119,7 @@ G_BEGIN_DECLS
+ #define APP_INDICATOR_SIGNAL_CONNECTION_CHANGED "connection-changed"
+ #define APP_INDICATOR_SIGNAL_NEW_ICON_THEME_PATH "new-icon-theme-path"
+ #define APP_INDICATOR_SIGNAL_SCROLL_EVENT "scroll-event"
++#define APP_INDICATOR_SIGNAL_ACTIVATE_EVENT "activate-event"
+
+ /**
+ * AppIndicatorCategory:
+@@ -228,7 +229,7 @@ struct _AppIndicatorClass {
+ void (*app_indicator_reserved_3)(void);
+ void (*app_indicator_reserved_4)(void);
+ void (*app_indicator_reserved_5)(void);
+- void (*app_indicator_reserved_6)(void);
++ void (*activate_event)(AppIndicator *indicator, gpointer user_data);
+ };
+
+ /**
--- a/src/notification-item.xml
+++ b/src/notification-item.xml
-@@ -31,6 +31,10 @@
- <method name="XAyatanaSecondaryActivate">
- <arg type="u" name="timestamp" direction="in" />
- </method>
+@@ -9,6 +9,7 @@
+ <property name="IconName" type="s" access="read" />
+ <property name="IconAccessibleDesc" type="s" access="read" />
+ <property name="AttentionIconName" type="s" access="read" />
++ <property name="ToolTip" type="(sa(iiay)ss)" access="read" />
+ <property name="AttentionAccessibleDesc" type="s" access="read" />
+ <property name="Title" type="s" access="read" />
+
Reply
