Hello community, here is the log from the commit of package openSUSE-release-tools for openSUSE:Factory checked in at 2018-03-09 10:45:21 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/openSUSE-release-tools (Old) and /work/SRC/openSUSE:Factory/.openSUSE-release-tools.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "openSUSE-release-tools" Fri Mar 9 10:45:21 2018 rev:67 rq:584267 version:20180308.defd995 Changes: -------- --- /work/SRC/openSUSE:Factory/openSUSE-release-tools/openSUSE-release-tools.changes 2018-03-08 11:00:22.299106798 +0100 +++ /work/SRC/openSUSE:Factory/.openSUSE-release-tools.new/openSUSE-release-tools.changes 2018-03-09 10:45:51.020289663 +0100 @@ -1,0 +2,20 @@ +Thu Mar 08 10:26:27 UTC 2018 - opensuse-releaseteam@opensuse.org + +- Update to version 20180308.defd995: + * osclib/conf: change priority to be string to work with ConfigParser. + +------------------------------------------------------------------- +Thu Mar 08 08:17:04 UTC 2018 - opensuse-releaseteam@opensuse.org + +- Update to version 20180308.3e83a1f: + * leaper: do not decline SLE requests, but rather ask managers for input. + * osclib/conf: configure SLE-15 leaper-override-group. + * leaper: move review groups to osclib.conf. + +------------------------------------------------------------------- +Wed Mar 07 20:30:27 UTC 2018 - opensuse-releaseteam@opensuse.org + +- Update to version 20180307.f6eae67: + * repo_checker: format what_depends_on as markdown bulleted list. + +------------------------------------------------------------------- Old: ---- openSUSE-release-tools-20180307.d30db7e.obscpio New: ---- openSUSE-release-tools-20180308.defd995.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ openSUSE-release-tools.spec ++++++ --- /var/tmp/diff_new_pack.Xz5vhf/_old 2018-03-09 10:45:53.092215034 +0100 +++ /var/tmp/diff_new_pack.Xz5vhf/_new 2018-03-09 10:45:53.096214890 +0100 @@ -20,7 +20,7 @@ %define source_dir osc-plugin-factory %define announcer_filename factory-package-news Name: openSUSE-release-tools -Version: 20180307.d30db7e +Version: 20180308.defd995 Release: 0 Summary: Tools to aid in staging and release work for openSUSE/SUSE License: GPL-2.0-or-later AND MIT ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.Xz5vhf/_old 2018-03-09 10:45:53.136213449 +0100 +++ /var/tmp/diff_new_pack.Xz5vhf/_new 2018-03-09 10:45:53.136213449 +0100 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/openSUSE/osc-plugin-factory.git</param> - <param name="changesrevision">d30db7eb1d8572d7bb8aae01fca9a0e92228904b</param> + <param name="changesrevision">defd9954b5be1f8dc4f8c6a66869d9d1a98edb4b</param> </service> </servicedata> ++++++ openSUSE-release-tools-20180307.d30db7e.obscpio -> openSUSE-release-tools-20180308.defd995.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openSUSE-release-tools-20180307.d30db7e/leaper.py new/openSUSE-release-tools-20180308.defd995/leaper.py --- old/openSUSE-release-tools-20180307.d30db7e/leaper.py 2018-03-07 20:41:31.000000000 +0100 +++ new/openSUSE-release-tools-20180308.defd995/leaper.py 2018-03-08 11:19:00.000000000 +0100 @@ -63,9 +63,9 @@ self.pending_factory_submission = False self.source_in_factory = None self.needs_release_manager = False - self.release_manager_group = 'leap-reviewers' - self.review_team_group = 'opensuse-review-team' - self.legal_review_group = 'legal-auto' + self.release_manager_group = None + self.review_team_group = None + self.legal_review_group = None self.must_approve_version_updates = False self.must_approve_maintenance_updates = False self.needs_check_source = False @@ -199,6 +199,13 @@ #self.logger.info('no matching sources in Factory, Leap:15.0, nor devel project') self.logger.info('no matching sources in Factory, nor devel project') + if origin_same is False: + # Rather than decline, leave review open in-case of change and + # ask release manager for input via override comment. + self.logger.info('Comment `(at){} override accept` to force accept.'.format(self.review_user)) + self.needs_release_manager = True + return None + return origin_same if package in self.lookup_150: @@ -427,6 +434,8 @@ return False def check_one_request(self, req): + api = self.staging_api(req.actions[0].tgt_project) + config = self.staging_config[api.project] self.needs_legal_review = False self.needs_reviewteam = False self.needs_release_manager = False @@ -472,11 +481,14 @@ add_review_groups = [] if self.needs_release_manager: - add_review_groups.append(self.release_manager_group) + add_review_groups.append(self.release_manager_group or + config.get(self.override_group_key)) if self.needs_reviewteam: - add_review_groups.append(self.review_team_group) + add_review_groups.append(self.review_team_group or + config.get('review-team')) if self.needs_legal_review: - add_review_groups.append(self.legal_review_group) + add_review_groups.append(self.legal_review_group or + config.get('legal-review-group')) if self.needs_check_source and self.check_source_group is not None: add_review_groups.append(self.check_source_group) @@ -507,9 +519,9 @@ parser.add_option("--manual-version-updates", action="store_true", help="release manager must approve version updates") parser.add_option("--manual-maintenance-updates", action="store_true", help="release manager must approve maintenance updates") parser.add_option("--check-source-group", dest="check_source_group", metavar="GROUP", help="group used by check_source.py bot which will be added as a reviewer should leaper checks pass") - parser.add_option("--review-team-group", dest="review_team_group", metavar="GROUP", help="group used for package reviews", default="opensuse-review-team") - parser.add_option("--release-manager-group", dest="release_manager_group", metavar="GROUP", help="group used for release manager reviews", default="leap-reviewers") - parser.add_option("--legal-review-group", dest="legal_review_group", metavar="GROUP", help="group used for legal reviews", default="legal-auto") + parser.add_option("--review-team-group", dest="review_team_group", metavar="GROUP", help="group used for package reviews") + parser.add_option("--release-manager-group", dest="release_manager_group", metavar="GROUP", help="group used for release manager reviews") + parser.add_option("--legal-review-group", dest="legal_review_group", metavar="GROUP", help="group used for legal reviews") return parser diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openSUSE-release-tools-20180307.d30db7e/osclib/conf.py new/openSUSE-release-tools-20180308.defd995/osclib/conf.py --- old/openSUSE-release-tools-20180307.d30db7e/osclib/conf.py 2018-03-07 20:41:31.000000000 +0100 +++ new/openSUSE-release-tools-20180308.defd995/osclib/conf.py 2018-03-08 11:19:00.000000000 +0100 @@ -51,6 +51,7 @@ # check_source.py 'devel-project-enforce': 'True', 'review-team': 'opensuse-review-team', + 'legal-review-group': 'legal-auto', 'repo-checker': 'repo-checker', 'pkglistgen-product-family-include': 'openSUSE:Leap:N', }, @@ -72,6 +73,8 @@ 'main-repo': 'standard', 'download-baseurl': 'http://download.opensuse.org/distribution/leap/%(version)s/', 'download-baseurl-update': 'http://download.opensuse.org/update/leap/%(version)s/', + 'review-team': 'opensuse-review-team', + 'legal-review-group': 'legal-auto', # check_source.py # review-team optionally added by leaper.py. 'repo-checker': 'repo-checker', @@ -103,6 +106,7 @@ 'openqa': None, 'lock': 'SUSE:%(project)s:Staging', 'lock-ns': 'SUSE', + 'leaper-override-group': 'sle-release-managers', 'delreq-review': None, 'main-repo': 'standard', # check_source.py @@ -129,7 +133,7 @@ 'remote-config': False, 'delreq-review': None, 'main-repo': 'standard', - 'priority': 100, # Lower than SLE-15 since less specific. + 'priority': '100', # Lower than SLE-15 since less specific. }, # Allows devel projects to utilize tools that require config, but not # complete StagingAPI support. @@ -148,7 +152,7 @@ 'delreq-review': None, 'main-repo': 'openSUSE_Factory', 'remote-config': False, - 'priority': 1000, # Lowest priority as only a fallback. + 'priority': '1000', # Lowest priority as only a fallback. }, } @@ -185,7 +189,7 @@ def populate_conf(self): """Add sane default into the configuration.""" defaults = {} - default_ordered = OrderedDict(sorted(DEFAULT.items(), key=lambda i: i[1].get('priority', 99))) + default_ordered = OrderedDict(sorted(DEFAULT.items(), key=lambda i: int(i[1].get('priority', 99)))) for prj_pattern in default_ordered: match = re.match(prj_pattern, self.project) if match: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openSUSE-release-tools-20180307.d30db7e/repo_checker.py new/openSUSE-release-tools-20180308.defd995/repo_checker.py --- old/openSUSE-release-tools-20180307.d30db7e/repo_checker.py 2018-03-07 20:41:31.000000000 +0100 +++ new/openSUSE-release-tools-20180308.defd995/repo_checker.py 2018-03-08 11:19:00.000000000 +0100 @@ -491,7 +491,8 @@ what_depends_on.remove(action.tgt_package) if len(what_depends_on): - self.logger.warn('{} is still a build requirement of {}'.format(action.tgt_package, ', '.join(what_depends_on))) + self.logger.warn('{} is still a build requirement of:\n\n- {}'.format( + action.tgt_package, '\n- '.join(sorted(what_depends_on)))) if len(self.comment_handler.lines): self.comment_write(state='seen', result='failed') ++++++ openSUSE-release-tools.obsinfo ++++++ --- /var/tmp/diff_new_pack.Xz5vhf/_old 2018-03-09 10:45:53.908185644 +0100 +++ /var/tmp/diff_new_pack.Xz5vhf/_new 2018-03-09 10:45:53.908185644 +0100 @@ -1,5 +1,5 @@ name: openSUSE-release-tools -version: 20180307.d30db7e -mtime: 1520451691 -commit: d30db7eb1d8572d7bb8aae01fca9a0e92228904b +version: 20180308.defd995 +mtime: 1520504340 +commit: defd9954b5be1f8dc4f8c6a66869d9d1a98edb4b