Hello community, here is the log from the commit of package sysuser-tools for openSUSE:Factory checked in at 2017-10-25 17:43:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/sysuser-tools (Old) and /work/SRC/openSUSE:Factory/.sysuser-tools.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "sysuser-tools" Wed Oct 25 17:43:28 2017 rev:5 rq:533650 version:2.0 Changes: -------- --- /work/SRC/openSUSE:Factory/sysuser-tools/sysuser-tools.changes 2017-06-23 09:13:55.648054294 +0200 +++ /work/SRC/openSUSE:Factory/.sysuser-tools.new/sysuser-tools.changes 2017-10-25 17:43:29.842746566 +0200 @@ -1,0 +2,18 @@ +Mon Oct 9 13:51:42 UTC 2017 - dimstar@opensuse.org + +- Furhter enhance sysusers-generate-pre: inside the build + environment, it can be acceptable to be failing to create the + users (e.g when building sysuser-tools or system-user-root, since + those two packages have to be speificallty excluded). Always + return with error code 0 if /.buildenv exists. + +------------------------------------------------------------------- +Wed Sep 27 11:06:52 UTC 2017 - dimstar@opensuse.org + +- sysusers2shadow.sh: Exit if one of the useradd/groupadd/usermod + call fails: the resulting system is quite undefined if this + should happen. +- sysusers-generate-pre: exit the pre script with the exit code + of sysusers2shadow.sh. + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ sysusers-generate-pre ++++++ --- /var/tmp/diff_new_pack.kbALYT/_old 2017-10-25 17:43:30.630709585 +0200 +++ /var/tmp/diff_new_pack.kbALYT/_new 2017-10-25 17:43:30.634709397 +0200 @@ -19,6 +19,8 @@ echo '#!/bin/bash' echo "tail -n $lines \$0 | /usr/sbin/sysusers2shadow" -echo "exit 0" +echo 'RET=$?' +echo 'test -f /.buildenv && exit 0' +echo 'exit $RET' echo '######## data below ########' cat "$tmpfile" ++++++ sysusers2shadow.sh ++++++ --- /var/tmp/diff_new_pack.kbALYT/_old 2017-10-25 17:43:30.662708083 +0200 +++ /var/tmp/diff_new_pack.kbALYT/_new 2017-10-25 17:43:30.666707896 +0200 @@ -12,7 +12,7 @@ ARGUMENTS="-g ${arr[2]} $ARGUMENTS" fi echo "groupadd -r $ARGUMENTS" - /usr/bin/getent group "${arr[1]}" >> /dev/null || /usr/sbin/groupadd -r $ARGUMENTS + /usr/bin/getent group "${arr[1]}" >> /dev/null || /usr/sbin/groupadd -r $ARGUMENTS || exit $? ;; u*) eval arr=( $LINE ) @@ -30,12 +30,12 @@ ARGUMENTS="-U $ARGUMENTS" fi echo "useradd -r -s /sbin/nologin -c \"${arr[3]}\" $ARGUMENTS" - /usr/bin/getent passwd ${arr[1]} >> /dev/null || /usr/sbin/useradd -r -s /sbin/nologin -c "${arr[3]}" $ARGUMENTS + /usr/bin/getent passwd ${arr[1]} >> /dev/null || /usr/sbin/useradd -r -s /sbin/nologin -c "${arr[3]}" $ARGUMENTS || exit $? ;; m*) eval arr=( $LINE ) echo "usermod -a -G ${arr[2]} ${arr[1]}" - /usr/sbin/usermod -a -G ${arr[2]} ${arr[1]} + /usr/sbin/usermod -a -G ${arr[2]} ${arr[1]} || exit $? ;; r*) echo "range option ignored: \"$LINE\""