Hello community, here is the log from the commit of package libgnomesu for openSUSE:Factory checked in at Fri Jun 4 14:52:49 CEST 2010. -------- --- GNOME/libgnomesu/libgnomesu.changes 2010-04-14 18:58:45.000000000 +0200 +++ /mounts/work_src_done/STABLE/libgnomesu/libgnomesu.changes 2010-06-04 01:31:14.000000000 +0200 @@ -1,0 +2,8 @@ +Fri Jun 4 01:26:05 CEST 2010 - vuntz@opensuse.org + +- Add libgnomesu-no-manual-memory-cleaning.patch to fix some bad + code that tries to remove passwords from memory the wrong way. + GTK+ already does this for us. As a side-effect, this fixes + bnc#351917. + +------------------------------------------------------------------- calling whatdependson for head-i586 New: ---- libgnomesu-no-manual-memory-cleaning.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libgnomesu.spec ++++++ --- /var/tmp/diff_new_pack.KotRB6/_old 2010-06-04 14:51:52.000000000 +0200 +++ /var/tmp/diff_new_pack.KotRB6/_new 2010-06-04 14:51:52.000000000 +0200 @@ -19,7 +19,7 @@ Name: libgnomesu Version: 1.0.0 -Release: 316 +Release: 317 License: LGPLv2.1+ Summary: GNOME su Library Url: http://members.chello.nl/~h.lai/libgnomesu/ @@ -54,6 +54,8 @@ Patch13: libgnomesu-remove-prior-cookie.patch # PATCH-FIX-UPSTREAM libgnomesu-i18n.patch bnc582085 sbrabec@suse.cz -- Fix translatability Patch14: libgnomesu-i18n.patch +# PATCH-FIX-UPSTREAM libgnomesu-no-manual-memory-cleaning.patch bnc351917 vuntz@opensuse.org -- Let GTK+ remove passwords from memory +Patch15: libgnomesu-no-manual-memory-cleaning.patch BuildRequires: fdupes BuildRequires: gconf2-devel BuildRequires: gtk2-devel @@ -112,6 +114,7 @@ %patch12 -p1 %patch13 -p1 %patch14 -p1 +%patch15 -p1 cp -a %{S:1} pam-backend/gnomesu-pam # Upstream is dead, libgnomesu.po in LCN includes strings in our patches: translation-update-upstream ++++++ libgnomesu-no-manual-memory-cleaning.patch ++++++ Index: libgnomesu-1.0.0/src/gnomesu-auth-dialog.c =================================================================== --- libgnomesu-1.0.0.orig/src/gnomesu-auth-dialog.c +++ libgnomesu-1.0.0/src/gnomesu-auth-dialog.c @@ -206,6 +206,14 @@ create_stock_button (const gchar *stock, static void clear_entry (GtkWidget *entry) { +#if GTK_CHECK_VERSION(2,18,0) + /* With GTK+ 2.18, GtkEntry uses a GtkEntryBuffer which cleans the + * memory for passwords. See trash_area() in gtkentrybuffer.c. + * The code below actually creates some bugs, like + * https://bugzilla.novell.com/show_bug.cgi?id=351917 so we shouldn't + * use it, if possible. */ + gtk_entry_set_text (GTK_ENTRY (entry), ""); +#else gchar *blank; size_t len; @@ -222,6 +230,7 @@ clear_entry (GtkWidget *entry) gtk_entry_set_text (GTK_ENTRY (entry), ""); if (blank) g_free (blank); +#endif } void ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org