Hello community,
here is the log from the commit of package mono-tools for openSUSE:Factory
checked in at Wed Mar 17 15:50:36 CET 2010.
--------
--- mono-tools/mono-tools.changes 2010-01-26 23:05:17.000000000 +0100
+++ mono-tools/mono-tools.changes 2010-03-16 17:33:39.000000000 +0100
@@ -1,0 +2,6 @@
+Tue Mar 16 16:32:23 UTC 2010 - ajorgensen@novell.com
+
+- Update to 2.6.2
+ * http://www.mono-project.com/Release_Notes_Mono_2.6.3
+
+-------------------------------------------------------------------
calling whatdependson for head-i586
Old:
----
mono-tools-2.6.1.tar.bz2
New:
----
mono-tools-2.6.2.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ mono-tools.spec ++++++
--- /var/tmp/diff_new_pack.4j49y8/_old 2010-03-17 15:47:08.000000000 +0100
+++ /var/tmp/diff_new_pack.4j49y8/_new 2010-03-17 15:47:08.000000000 +0100
@@ -1,5 +1,5 @@
#
-# spec file for package mono-tools (Version 2.6.1)
+# spec file for package mono-tools (Version 2.6.2)
#
# Copyright (c) 2010 SUSE LINUX Products GmbH, Nuernberg, Germany.
#
@@ -19,7 +19,7 @@
Name: mono-tools
-Version: 2.6.1
+Version: 2.6.2
Release: 1
License: GPLv2 ; LGPLv2.0 ; MIT License (or similar)
BuildArch: noarch
++++++ mono-tools-2.6.1.tar.bz2 -> mono-tools-2.6.2.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/configure new/mono-tools-2.6.2/configure
--- old/mono-tools-2.6.1/configure 2009-12-17 17:52:49.000000000 +0100
+++ new/mono-tools-2.6.2/configure 2010-02-02 19:29:24.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.63 for mono-tools 2.6.1.
+# Generated by GNU Autoconf 2.63 for mono-tools 2.6.2.
#
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,
# 2002, 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc.
@@ -594,8 +594,8 @@
# Identity of this package.
PACKAGE_NAME='mono-tools'
PACKAGE_TARNAME='mono-tools'
-PACKAGE_VERSION='2.6.1'
-PACKAGE_STRING='mono-tools 2.6.1'
+PACKAGE_VERSION='2.6.2'
+PACKAGE_STRING='mono-tools 2.6.2'
PACKAGE_BUGREPORT=''
ac_unique_file="README"
@@ -1368,7 +1368,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures mono-tools 2.6.1 to adapt to many kinds of systems.
+\`configure' configures mono-tools 2.6.2 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1439,7 +1439,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of mono-tools 2.6.1:";;
+ short | recursive ) echo "Configuration of mono-tools 2.6.2:";;
esac
cat <<\_ACEOF
@@ -1553,7 +1553,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-mono-tools configure 2.6.1
+mono-tools configure 2.6.2
generated by GNU Autoconf 2.63
Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,
@@ -1567,7 +1567,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by mono-tools $as_me 2.6.1, which was
+It was created by mono-tools $as_me 2.6.2, which was
generated by GNU Autoconf 2.63. Invocation command line was
$ $0 $@
@@ -2284,7 +2284,7 @@
# Define the identity of the package.
PACKAGE='mono-tools'
- VERSION='2.6.1'
+ VERSION='2.6.2'
cat >>confdefs.h <<_ACEOF
@@ -7789,7 +7789,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by mono-tools $as_me 2.6.1, which was
+This file was extended by mono-tools $as_me 2.6.2, which was
generated by GNU Autoconf 2.63. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -7843,7 +7843,7 @@
_ACEOF
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_version="\\
-mono-tools config.status 2.6.1
+mono-tools config.status 2.6.2
configured by $0, generated by GNU Autoconf 2.63,
with options \\"`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/configure.in new/mono-tools-2.6.2/configure.in
--- old/mono-tools-2.6.1/configure.in 2009-12-17 17:52:41.000000000 +0100
+++ new/mono-tools-2.6.2/configure.in 2010-02-02 19:29:16.000000000 +0100
@@ -1,4 +1,4 @@
-AC_INIT([mono-tools], [2.6.1])
+AC_INIT([mono-tools], [2.6.2])
AC_CONFIG_SRCDIR([README])
AM_INIT_AUTOMAKE([tar-ustar -Wno-portability])
AC_CANONICAL_SYSTEM
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/ChangeLog new/mono-tools-2.6.2/gendarme/ChangeLog
--- old/mono-tools-2.6.1/gendarme/ChangeLog 2009-09-25 17:24:15.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/ChangeLog 2010-02-02 19:29:16.000000000 +0100
@@ -1,3 +1,11 @@
+2009-12-20 Sebastien Pouliot
+
+ * NEWS: Updated for 2.6
+
+2009-12-20 Sebastien Pouliot
+
+ * Makefile.am: Bundle gendarme.5
+
2009-08-19 Jesse Jones
* self-test.ignore: Added a bunch more entries to allow self-test to
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/Makefile.am new/mono-tools-2.6.2/gendarme/Makefile.am
--- old/mono-tools-2.6.1/gendarme/Makefile.am 2009-09-25 17:24:15.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/Makefile.am 2009-12-20 18:06:06.000000000 +0100
@@ -95,6 +95,7 @@
cp ../bin/*.dll .; \
cp ../rules/rules.xml .; \
cp ../man/gendarme.1 .; \
+ cp ../man/gendarme.5 .; \
cp ../AUTHORS ../README ../MIT.X11 ../NEWS .; \
cp ../extra/* .; \
zip gendarme-$(GENDARME_VERSION)-bin.zip *; \
@@ -107,7 +108,7 @@
push: instruct.xsd
xmllint --schema instruct.xsd gendarme.xml
-# scp gendarme-2.2preview1-bin.zip $(USER)@upload.ohloh.net:gendarme/files; \
-# scp gendarme-2.2preview1-win32-setup.zip $(USER)@upload.ohloh.net:gendarme/files; \
-# scp gendarme.xml $(USER)@upload.ohloh.net:gendarme/instructs
+ scp gendarme-2.6-bin.zip $(USER)@upload.ohloh.net:gendarme/files; \
+ scp gendarme-2.6-win32-setup.zip $(USER)@upload.ohloh.net:gendarme/files; \
+ scp gendarme.xml $(USER)@upload.ohloh.net:gendarme/instructs
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/Makefile.in new/mono-tools-2.6.2/gendarme/Makefile.in
--- old/mono-tools-2.6.1/gendarme/Makefile.in 2009-12-17 17:52:47.000000000 +0100
+++ new/mono-tools-2.6.2/gendarme/Makefile.in 2010-02-02 19:29:22.000000000 +0100
@@ -658,6 +658,7 @@
cp ../bin/*.dll .; \
cp ../rules/rules.xml .; \
cp ../man/gendarme.1 .; \
+ cp ../man/gendarme.5 .; \
cp ../AUTHORS ../README ../MIT.X11 ../NEWS .; \
cp ../extra/* .; \
zip gendarme-$(GENDARME_VERSION)-bin.zip *; \
@@ -670,9 +671,9 @@
push: instruct.xsd
xmllint --schema instruct.xsd gendarme.xml
-# scp gendarme-2.2preview1-bin.zip $(USER)@upload.ohloh.net:gendarme/files; \
-# scp gendarme-2.2preview1-win32-setup.zip $(USER)@upload.ohloh.net:gendarme/files; \
-# scp gendarme.xml $(USER)@upload.ohloh.net:gendarme/instructs
+ scp gendarme-2.6-bin.zip $(USER)@upload.ohloh.net:gendarme/files; \
+ scp gendarme-2.6-win32-setup.zip $(USER)@upload.ohloh.net:gendarme/files; \
+ scp gendarme.xml $(USER)@upload.ohloh.net:gendarme/instructs
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/NEWS new/mono-tools-2.6.2/gendarme/NEWS
--- old/mono-tools-2.6.1/gendarme/NEWS 2009-09-25 17:24:15.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/NEWS 2010-02-02 19:29:16.000000000 +0100
@@ -1,3 +1,45 @@
+2009-12-20 Version 2.6
+
+ Released just in time for xmas Gendarme 2.6 comes with a lot of
+ enhancements and bug fixes. Rule documentation (wiki) and our MAN
+ pages were also greatly enhanced by the work of Jesse Jones.
+
+ In the ecosystem Daniel Nauck contributed Gendarme support for
+ CC.NET and a new NAnt task with reduced dependencies. With this
+ Gendarme should be easier than ever to use on your projects.
+
+ This release includes 12 new rules (207 rules total):
+
+ Gendarme.Rules.BadPractice
+ * DoNotUseEnumIsAssignableFromRule [JB Evain]
+ * OnlyUseDisposeForIDisposableTypesRule [Jesse Jones]
+ * PreferSafeHandleRule [Jesse Jones]
+
+ Gendarme.Rules.Concurrency
+ * DoNotUseThreadStaticWithInstanceFieldsRule [Jesse Jones]
+
+ Gendarme.Rules.Correctness
+ * ProvideValidXmlStringRule [Cedric Vivier]
+ * ProvideValidXPathExpressionRule [Cedric Vivier]
+
+ Gendarme.Rules.Design
+ * PreferXmlAbstractionsRule [Cedric Vivier]
+ * UseCorrectDisposeSignaturesRule [Jesse Jones]
+ * UseFlagsAttributeRule [Jesse Jones]
+
+ Gendarme.Rules.Exceptions
+ * UseObjectDisposedExceptionRule [Jesse Jones]
+
+ Gendarme.Rules.Interoperability
+ * DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule [Rolf Bjarne Kvinge]
+
+ Gendarme.Rules.Performance
+ * ReviewLinqMethodRule [Jesse Jones]
+
+ Contributors for this release are:
+ Cedric Vivier, Daniel Nauck, JB Evain, Jesse Jones, Rolf Bjarne
+ Kvinge and Sebastien Pouliot.
+
2009-01-20 Version 2.4
This release was the shortest (about 2 months) release cycle ever
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.BadPractice/OnlyUseDisposeForIDisposableTypesRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.BadPractice/OnlyUseDisposeForIDisposableTypesRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.BadPractice/OnlyUseDisposeForIDisposableTypesRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.BadPractice/OnlyUseDisposeForIDisposableTypesRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -64,6 +64,7 @@
/// </example>
/// <example>
/// Good example:
+ /// <code>
/// internal sealed class Worker
/// {
/// // This class uses one or more temporary files to do its work.
@@ -78,9 +79,9 @@
/// files.Clear ();
/// }
/// }
- /// <code>
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("A type has a method named Dispose, but does not implement IDisposable.")]
[Solution ("Rename the method or implement IDisposable.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.BadPractice/PreferSafeHandleRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.BadPractice/PreferSafeHandleRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.BadPractice/PreferSafeHandleRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.BadPractice/PreferSafeHandleRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -69,9 +69,9 @@
///
/// // If cleaning up the native resource in a timely manner is important you can
/// // implement IDisposable.
- /// public sealed class Database
- /// {
- /// ~Database () {
+ /// public sealed class Database {
+ /// ~Database ()
+ /// {
/// // This will execute even if the ctor throws so it is important to check
/// // to see if the fields are initialized.
/// if (m_database != IntPtr.Zero) {
@@ -82,13 +82,13 @@
/// public Database (string path)
/// {
/// NativeMethods.OpenFlags flags = NativeMethods.OpenFlags.READWRITE | NativeMethods.OpenFlags.CREATE;
- /// NativeMethods.Error err = NativeMethods.sqlite3_open_v2 (path, out m_database, flags, IntPtr.Zero);
+ /// int err = NativeMethods.sqlite3_open_v2 (path, out m_database, flags, IntPtr.Zero);
/// // handle errors
/// }
///
/// // exec and query methods would go here
///
- /// [SuppressUnmanagedCodeSecurity ()]
+ /// [SuppressUnmanagedCodeSecurity]
/// private static class NativeMethods {
/// [Flags]
/// public enum OpenFlags : int {
@@ -98,17 +98,11 @@
/// // ...
/// }
///
- /// public enum Error : int {
- /// OK = 0,
- /// ERROR = 1,
- /// // ...
- /// }
- ///
/// [DllImport ("sqlite3")]
- /// public static extern Error sqlite3_close (IntPtr db);
+ /// public static extern int sqlite3_close (IntPtr db);
///
/// [DllImport ("sqlite3")]
- /// public static extern Error sqlite3_open_v2 (string fileName, out IntPtr db, OpenFlags flags, IntPtr module);
+ /// public static extern int sqlite3_open_v2 (string fileName, out IntPtr db, OpenFlags flags, IntPtr module);
/// }
///
/// private IntPtr m_database;
@@ -141,17 +135,17 @@
/// private sealed class SqlitePtr : SafeHandle {
/// public SqlitePtr (string path, NativeMethods.OpenFlags flags) : base (IntPtr.Zero, true)
/// {
- /// NativeMethods.Error err = NativeMethods.sqlite3_open_v2 (path, out handle, flags, IntPtr.Zero);
+ /// int err = NativeMethods.sqlite3_open_v2 (path, out handle, flags, IntPtr.Zero);
/// // handle errors
/// }
///
- /// public override bool IsInvalid
- /// {
- /// get { return handle == IntPtr.Zero; }
+ /// public override bool IsInvalid {
+ /// get {
+ /// return (handle == IntPtr.Zero);
+ /// }
/// }
///
- /// // This will not be called if the handle is invalid. Note that this
- /// // method should not throw.
+ /// // This will not be called if the handle is invalid. Note that this method should not throw.
/// [ReliabilityContract (Consistency.WillNotCorruptState, Cer.MayFail)]
/// protected override bool ReleaseHandle ()
/// {
@@ -160,7 +154,7 @@
/// }
/// }
///
- /// [SuppressUnmanagedCodeSecurity ()]
+ /// [SuppressUnmanagedCodeSecurity]
/// private static class NativeMethods {
/// [Flags]
/// public enum OpenFlags : int {
@@ -170,24 +164,19 @@
/// // ...
/// }
///
- /// public enum Error : int {
- /// OK = 0,
- /// ERROR = 1,
- /// // ...
- /// }
- ///
/// [DllImport ("sqlite3")]
- /// public static extern Error sqlite3_close (SqlitePtr db);
+ /// public static extern int sqlite3_close (SqlitePtr db);
///
/// // Open must take an IntPtr but all other methods take a type safe SqlitePtr.
/// [DllImport ("sqlite3")]
- /// public static extern Error sqlite3_open_v2 (string fileName, out IntPtr db, OpenFlags flags, IntPtr module);
+ /// public static extern int sqlite3_open_v2 (string fileName, out IntPtr db, OpenFlags flags, IntPtr module);
/// }
///
/// private SqlitePtr m_database;
/// }
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("The type uses System.IntPtr or System.UIntPtr instead of System.Runtime.InteropServices.SafeHandle.")]
[Solution ("Consider changing the code to use SafeHandle.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Concurrency/DoNotUseThreadStaticWithInstanceFieldsRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Concurrency/DoNotUseThreadStaticWithInstanceFieldsRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Concurrency/DoNotUseThreadStaticWithInstanceFieldsRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Concurrency/DoNotUseThreadStaticWithInstanceFieldsRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -39,7 +39,7 @@
namespace Gendarme.Rules.Concurrency {
/// <summary>
- /// This rule will fire if an instance field is decorated with System.ThreadStaticAttribute.
+ /// This rule will fire if an instance field is decorated with a <c>[ThreadStatic]</c> attribute.
/// This is an error because the attribute will only work with static fields.
/// </summary>
/// <example>
@@ -78,6 +78,7 @@
/// }
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("An instance field is decorated with System.ThreadStaticAttribute.")]
[Solution ("ThreadStaticAttribute will only make static fields thread safe. To make an instance field thread safe you need to use techniques like locking or System.Threading.Thread.Thread::AllocateNamedDataSlot.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/AvoidFloatingPointEqualityRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/AvoidFloatingPointEqualityRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/AvoidFloatingPointEqualityRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/AvoidFloatingPointEqualityRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -65,17 +65,17 @@
/// // work as expected.
/// public static bool NearlyEqual (double [] lhs, double [] rhs)
/// {
- /// if (ReferenceEquals (lhs, rhs))
+ /// if (ReferenceEquals (lhs, rhs)) {
/// return true;
- ///
- /// if (lhs.Length != rhs.Length)
+ /// }
+ /// if (lhs.Length != rhs.Length) {
/// return false;
- ///
+ /// }
/// for (int i = 0; i < lhs.Length; ++i) {
- /// if (lhs [i] != rhs [i])
+ /// if (lhs [i] != rhs [i]) {
/// return false;
+ /// }
/// }
- ///
/// return true;
/// }
/// </code>
@@ -89,17 +89,17 @@
/// // be scaled accordingly).
/// public static bool NearlyEqual (double [] lhs, double [] rhs, double epsilon)
/// {
- /// if (ReferenceEquals (lhs, rhs))
+ /// if (ReferenceEquals (lhs, rhs)) {
/// return true;
- ///
- /// if (lhs.Length != rhs.Length)
+ /// }
+ /// if (lhs.Length != rhs.Length) {
/// return false;
- ///
+ /// }
/// for (int i = 0; i < lhs.Length; ++i) {
- /// if (Math.Abs (lhs [i] - rhs [i]) > epsilon)
+ /// if (Math.Abs (lhs [i] - rhs [i]) > epsilon) {
/// return false;
+ /// }
/// }
- ///
/// return true;
/// }
/// </code>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/CheckParametersNullityInVisibleMethodsRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/CheckParametersNullityInVisibleMethodsRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/CheckParametersNullityInVisibleMethodsRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/CheckParametersNullityInVisibleMethodsRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -37,6 +37,55 @@
namespace Gendarme.Rules.Correctness {
+ /// <summary>
+ /// This rule checks if all nullable parameters of visible methods are compared
+ /// with '''null''' before they get used. This reduce the likelyhood of the runtime
+ /// throwing a <c>NullReferenceException</c>.
+ /// </summary>
+ /// <example>
+ /// Bad example:
+ /// <code>
+ /// [DllImport ("message")]
+ /// internal static extern byte [] Parse (string s, int length);
+ ///
+ /// public bool TryParse (string s, out Message m)
+ /// {
+ /// // is 's' is null then 's.Length' will throw a NullReferenceException
+ /// // which a TryParse method should never do
+ /// byte [] data = Parse (s, s.Length);
+ /// if (data == null) {
+ /// m = null;
+ /// return false;
+ /// }
+ /// m = new Message (data);
+ /// return true;
+ /// }
+ /// </code>
+ /// </example>
+ /// <example>
+ /// Good example:
+ /// <code>
+ /// [DllImport ("message")]
+ /// internal static extern byte [] Parse (string s, int length);
+ ///
+ /// public bool TryParse (string s, out Message m)
+ /// {
+ /// if (s == null) {
+ /// m = null;
+ /// return false;
+ /// }
+ /// byte [] data = Parse (s, s.Length);
+ /// if (data == null) {
+ /// m = null;
+ /// return false;
+ /// }
+ /// m = new Message (data);
+ /// return true;
+ /// }
+ /// </code>
+ /// </example>
+ /// <remarks>This rule is available since Gendarme 2.2</remarks>
+
[Problem ("A visible method does not check its parameter(s) for null values.")]
[Solution ("Since the caller is unknown you should always verify all of your parameters to protect yourself.")]
[FxCopCompatibility ("Microsoft.Design", "CA1062:ValidateArgumentsOfPublicMethods")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/DisposableFieldsShouldBeDisposedRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/DisposableFieldsShouldBeDisposedRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/DisposableFieldsShouldBeDisposedRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/DisposableFieldsShouldBeDisposedRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -42,9 +42,9 @@
namespace Gendarme.Rules.Correctness {
/// <summary>
- /// The rule inspects all fields for disposable types and, if <c>System.IDisposable</c>
- /// is implemented, checks that the type's <c>Dispose</c> method does indeed call <c>Dispose</c>
- /// on all disposable fields.
+ /// The rule inspects all fields for disposable types and, if <c>System.IDisposable</c> is
+ /// implemented, checks that the type's <c>Dispose</c> method does indeed call <c>Dispose</c> on
+ /// all disposable fields.
/// </summary>
/// <example>
/// Bad example:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXPathExpressionRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXPathExpressionRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXPathExpressionRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXPathExpressionRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -67,6 +67,7 @@
/// var xpath = XPathExpression.Compile ("/book[@npages = 100]/@title");
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("An invalid XPath expression string is provided to a method.")]
[Solution ("Fix the invalid XPath expression.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXmlStringRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXmlStringRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXmlStringRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Correctness/ProvideValidXmlStringRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -69,6 +69,7 @@
/// bookElement.InnerXml = "<author>Robert J. Sawyer</author>";
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("An invalid XML string is provided to a method.")]
[Solution ("Fix the invalid XML string.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Design/PreferXmlAbstractionsRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Design/PreferXmlAbstractionsRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Design/PreferXmlAbstractionsRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Design/PreferXmlAbstractionsRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -35,16 +35,20 @@
namespace Gendarme.Rules.Design {
/// <summary>
- /// This rule fires if an externally visible method or property uses an XmlDocument, XPathDocument or XmlNode
- /// argument. The problem with this is that it ties your API to a specific implementation so it is difficult to change
- /// later. Instead use abstract types like IXPathNavigable, XmlReader, XmlWriter, or subtypes of XmlNode.
+ /// This rule fires if an externally visible method or property uses an <c>XmlDocument</c>,
+ /// <c>XPathDocument</c> or <c>XmlNode</c> argument. The problem with this is that it ties
+ /// your API to a specific implementation so it is difficult to change later. Instead use
+ /// abstract types like <c>IXPathNavigable</c>, <c>XmlReader</c>, <c>XmlWriter</c>, or subtypes
+ /// of <c>XmlNode</c>.
/// </summary>
/// <example>
/// Bad example (property):
/// <code>
/// public class Application {
/// public XmlDocument UserData {
- /// get { return userData; }
+ /// get {
+ /// return userData;
+ /// }
/// }
/// }
/// </code>
@@ -54,7 +58,9 @@
/// <code>
/// public class Application {
/// public IXPathNavigable UserData {
- /// get { return userData; }
+ /// get {
+ /// return userData;
+ /// }
/// }
/// }
/// </code>
@@ -63,7 +69,8 @@
/// Bad example (method parameter):
/// <code>
/// public class Application {
- /// public bool IsValidUserData (XmlDocument userData) {
+ /// public bool IsValidUserData (XmlDocument userData)
+ /// {
/// /* implementation */
/// }
/// }
@@ -73,7 +80,8 @@
/// Good example (method parameter):
/// <code>
/// public class Application {
- /// public bool IsValidUserData (XmlReader userData) {
+ /// public bool IsValidUserData (XmlReader userData)
+ /// {
/// /* implementation */
/// }
/// }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Design/UseCorrectDisposeSignaturesRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Design/UseCorrectDisposeSignaturesRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Design/UseCorrectDisposeSignaturesRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Design/UseCorrectDisposeSignaturesRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -35,11 +35,11 @@
namespace Gendarme.Rules.Design {
/// <summary>
- /// There is a convention that should be followed when implementing IDisposable. Part
+ /// There is a convention that should be followed when implementing <c>IDisposable</c>. Part
/// of this convention is that Dispose methods should have specific signatures. In
- /// particular an IDisposable type's Dispose methods should either be nullary or unary
- /// with a bool argument, Dispose () should not be virtual, Dispose (bool) should not be
- /// public, and unsealed types should have a protected virtual Dispose (bool) method.
+ /// particular an <c>IDisposable</c> type's Dispose methods should either be nullary or unary
+ /// with a bool argument, <c>Dispose ()</c> should not be virtual, <c>Dispose (bool)</c> should
+ /// not be public, and unsealed types should have a <c>protected virtual Dispose (bool)</c> method.
/// For more details see: [http://www.bluebytesoftware.com/blog/2005/04/08/DGUpdateDisposeFinalizationA...].
/// </summary>
/// <example>
@@ -68,7 +68,10 @@
/// }
/// }
///
- /// protected bool Disposed { get; set; }
+ /// protected bool Disposed {
+ /// get;
+ /// set;
+ /// }
/// }
/// </code>
/// </example>
@@ -119,10 +122,14 @@
/// }
/// }
///
- /// protected bool Disposed { get; private set; }
+ /// protected bool Disposed {
+ /// get;
+ /// private set;
+ /// }
/// }
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("An IDisposable type does not conform to the guidelines for its Dispose methods.")]
[Solution ("Fix the signature of the methods or add the Dispose (bool) overload.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Design/UseFlagsAttributeRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Design/UseFlagsAttributeRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Design/UseFlagsAttributeRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Design/UseFlagsAttributeRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -39,9 +39,9 @@
/// <summary>
/// This rule will fire if an enum's values look like they are intended to
- /// be composed together with the bitwise OR operator and the enum
- /// is not decorated with System.FlagsAttribute. Using FlagsAttribute
- /// will allow System.Enum.ToString to return a better string when
+ /// be composed together with the bitwise OR operator and the enum is not
+ /// decorated with <c>System.FlagsAttribute</c>. Using <c>FlagsAttribute</c> will
+ /// allow <c>System.Enum.ToString()</c> to return a better string when
/// values are ORed together and helps indicate to readers of the code
/// the intended usage of the enum.
/// </summary>
@@ -70,6 +70,7 @@
/// }
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("The enum seems to be composed of flag values, but is not decorated with [Flags].")]
[Solution ("Add [Flags] to the enum, change the values so that they are not powers of two, or ignore the defect.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Exceptions/UseObjectDisposedExceptionRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Exceptions/UseObjectDisposedExceptionRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Exceptions/UseObjectDisposedExceptionRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Exceptions/UseObjectDisposedExceptionRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -110,7 +110,8 @@
/// }
/// </code>
/// </example>
-
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
+
[Problem ("A method of an IDisposable type does not throw System.ObjectDisposedException.")]
[Solution ("Throw ObjectDisposedException if the object has been disposed.")]
public sealed class UseObjectDisposedExceptionRule : Rule, IMethodRule {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Interoperability/DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Interoperability/DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Interoperability/DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Interoperability/DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -40,8 +40,8 @@
namespace Gendarme.Rules.Interoperability {
/// <summary>
- /// <code>Every delegate which is passed to native code must include an exception
- /// block which spans the entire method and has a catch all handler.</code>
+ /// Every delegate which is passed to native code must include an exception
+ /// block which spans the entire method and has a catch all handler.
/// </summary>
/// <example>
/// Bad example:
@@ -59,36 +59,30 @@
/// {
/// try {
/// Console.WriteLine ("{0}", 1);
- /// } catch {
+ /// }
+ /// catch {
/// }
/// }
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("Every delegate passed to native code must include an exception block which spans the entire method and has a catch all handler.")]
[Solution ("Surround the entire method body with a try/catch block.")]
[EngineDependency (typeof (OpCodeEngine))]
public class DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule : Rule, IMethodRule {
- /// <summary>
- /// A list of methods which have been verified to be safe to call from native code.
- /// </summary>
+ // A list of methods which have been verified to be safe to call from native code.
Dictionary verified_methods;
- /// <summary>
- /// A list of methods which have been reported to be unsafe (to not report the same method twice).
- /// </summary>
+ // A list of methods which have been reported to be unsafe (to not report the same method twice).
List<MethodDefinition> reported_methods;
- /// <summary>
- /// A list of all the fields which have been passed to pinvokes (as a delegate parameter).
- /// We report an error if a ld[s]fld stores an unsafe function pointer into any of these fields.
- /// </summary>
+ // A list of all the fields which have been passed to pinvokes (as a delegate parameter).
+ // We report an error if a ld[s]fld stores an unsafe function pointer into any of these fields.
List<FieldDefinition> fields_loads;
- /// <summary>
- /// A list of all the fields which have been assigned function pointers.
- /// We report an error if a pinvoke loads any of these fields.
- /// </summary>
+ // A list of all the fields which have been assigned function pointers.
+ // We report an error if a pinvoke loads any of these fields.
Dictionary field_stores;
public RuleResult CheckMethod (MethodDefinition method)
@@ -236,9 +230,7 @@
return Runner.CurrentRuleResult;
}
- /// <summary>
- /// Verifies that the method is safe to call as a callback from native code.
- /// </summary>
+ // Verifies that the method is safe to call as a callback from native code.
private bool VerifyCallbackSafety (MethodDefinition callback)
{
bool result;
@@ -342,9 +334,7 @@
}
}
- /// <summary>
- /// Parses the ILRange and return all delegate pointers that could end up on the stack as a result of executing that code.
- /// </summary>
+ // Parses the ILRange and return all delegate pointers that could end up on the stack as a result of executing that code.
private List<MethodDefinition> GetDelegatePointers (MethodDefinition method, List locals, ILRange range)
{
List<MethodDefinition> result = null;
@@ -392,10 +382,8 @@
}
- /// <summary>
- /// Verifies that all methods in the list are safe to call from native code,
- /// otherwise reports the correspoding result.
- /// </summary>
+ // Verifies that all methods in the list are safe to call from native code,
+ // otherwise reports the correspoding result.
private void VerifyMethods (List<MethodDefinition> pointers)
{
if (pointers == null)
@@ -405,9 +393,7 @@
ReportVerifiedMethod (pointer, VerifyCallbackSafety (pointer));
}
- /// <summary>
- /// Reports the result from verifying the method.
- /// </summary>
+ // Reports the result from verifying the method.
private void ReportVerifiedMethod (MethodDefinition pointer, bool safe)
{
if (!safe) {
@@ -437,10 +423,8 @@
return -1;
}
- /// <summary>
- /// Return the index of the load opcode.
- /// This could probably go into InstructionRocks.
- /// </summary>
+ // Return the index of the load opcode.
+ // This could probably go into InstructionRocks.
public static int GetLoadIndex (this Instruction ins)
{
switch (ins.OpCode.Code) {
@@ -458,10 +442,8 @@
}
}
- /// <summary>
- /// Return the index of the store opcode.
- /// This could probably go into InstructionRocks.
- /// </summary>
+ // Return the index of the store opcode.
+ // This could probably go into InstructionRocks.
public static int GetStoreIndex (this Instruction ins)
{
switch (ins.OpCode.Code) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Naming/UsePreferredTermsRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Naming/UsePreferredTermsRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Naming/UsePreferredTermsRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Naming/UsePreferredTermsRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -127,12 +127,10 @@
{ "Writeable", "Writable" }
};
- /// <summary>
- /// Reports a defect when 'name' contains a non-recommended term.
- /// </summary>
- /// <param name="identifier">Metadata token for 'name' or null if it is a namespace.</param>
- /// <param name="name">Name to check.</param>
- /// <param name="severity">Severity for the defect to be reported (if any).</param>
+ // Reports a defect when 'name' contains a non-recommended term.
+ // * identifier: Metadata token for 'name' or null if it is a namespace.
+ // * name: Name to check.
+ // * severity: Severity for the defect to be reported (if any).
private void CheckIdentifier (IMetadataTokenProvider identifier, string name, Severity severity)
{
// scan for any obsolete terms
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -43,7 +43,7 @@
/// Linq extension methods operate on sequences of values so they generally
/// have linear time complexity. However you may be able to achieve better
/// than linear time performance if you use a less general method or take
- /// advantage of a method provided by an Sytem.Collections.Generic.IEnumerable<T>
+ /// advantage of a method provided by an <c>Sytem.Collections.Generic.IEnumerable<T></c>
/// subclass.
/// </summary>
/// <example>
@@ -54,9 +54,8 @@
/// // Count () is O(n)
/// if (sequence.Count () > 0) {
/// return sequence.First ();
- /// } else {
- /// return missing;
/// }
+ /// return missing;
/// }
///
/// public void Append (List<string> lines, string line)
@@ -76,9 +75,8 @@
/// // We don't need an exact count so we can use the O(1) Any () method.
/// if (sequence.Any ()) {
/// return sequence.First ();
- /// } else {
- /// return missing;
/// }
+ /// return missing;
/// }
///
/// public void Append (List<string> lines, string line)
@@ -91,6 +89,7 @@
/// }
/// </code>
/// </example>
+ /// <remarks>This rule is available since Gendarme 2.6</remarks>
[Problem ("A linq extension method with linear time complexity is used, but a more efficient method is available.")]
[Solution ("Use the more efficient method.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Portability/MonoCompatibilityReviewRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Portability/MonoCompatibilityReviewRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Portability/MonoCompatibilityReviewRule.cs 2009-12-13 22:59:34.000000000 +0100
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Portability/MonoCompatibilityReviewRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -54,13 +54,12 @@
/// or <c>C:\Documents and Settings\{username}\Local Settings\Application Data\Gendarme</c>
/// (on Windows) and checking for calls to the methods therein. The rule will work without
/// MoMA but if it does fire it may be useful to download and run MoMA.
- /// </summary>
- /// <remarks>
+ ///
/// By default the rule will use the latest local version available. This can be overriden to use a
/// specific, local, version if you want to review compatibility against a specific Mono version.
/// You can also manually remove them, now and then, to ensure you are using the latest version.
/// Also upgrading Gendarme will try to download a newer version of the definitions files.
- /// </remarks>
+ /// </summary>
[Problem ("The method is either missing or partially implemented on Mono.")]
[Solution ("Review and test the code to ensure that it works properly on Mono. Also delete the definitions.zip to ensure that the latest version is downloaded.")]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Serialization/MarkEnumerationsAsSerializableRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Serialization/MarkEnumerationsAsSerializableRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Serialization/MarkEnumerationsAsSerializableRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Serialization/MarkEnumerationsAsSerializableRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -32,6 +32,32 @@
namespace Gendarme.Rules.Serialization {
+ /// <summary>
+ /// This rule warns when it founds an <c>enum</c> that is not decorated with
+ /// a <c>[Serializable]</c> attribute. Enums, even without the attribute,
+ /// are always serializable. Marking them as such makes the source code more readable.
+ /// </summary>
+ /// <example>
+ /// Bad example:
+ /// <code>
+ /// public enum Colors {
+ /// Black,
+ /// White
+ /// }
+ /// </code>
+ /// </example>
+ /// <example>
+ /// Good example:
+ /// <code>
+ /// [Serializable]
+ /// public enum Colors {
+ /// Black,
+ /// White
+ /// }
+ /// </code>
+ /// </example>
+ /// <remarks>This rule is available since Gendarme 2.2</remarks>
+
[Problem ("An enumeration, even if not decorated with [Serializable], is always serializable.")]
[Solution ("For better source code readability always decorate enumerations with [Serializable].")]
public class MarkEnumerationsAsSerializableRule : Rule, ITypeRule {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Smells/AvoidSwitchStatementsRule.cs new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Smells/AvoidSwitchStatementsRule.cs
--- old/mono-tools-2.6.1/gendarme/rules/Gendarme.Rules.Smells/AvoidSwitchStatementsRule.cs 2009-09-25 17:24:14.000000000 +0200
+++ new/mono-tools-2.6.2/gendarme/rules/Gendarme.Rules.Smells/AvoidSwitchStatementsRule.cs 2009-12-19 18:46:06.000000000 +0100
@@ -63,16 +63,19 @@
/// int balance = 0;
/// foreach (Movie movie in movies) {
/// switch (movie.GetTypeCode ()) {
- /// case MovieType.OldMovie:
- /// balance += movie.DaysRented * movie.Price / 2;
- /// break
- /// case MovieType.ChildMovie:
- /// //its an special bargain !!
- /// balance += movie.Price;
- /// break;
- /// case MovieType.NewMovie:
- /// balance += (movie.DaysRented + 1) * movie.Price;
- /// break:
+ /// case MovieType.OldMovie: {
+ /// balance += movie.DaysRented * movie.Price / 2;
+ /// break;
+ /// }
+ /// case MovieType.ChildMovie: {
+ /// //its an special bargain !!
+ /// balance += movie.Price;
+ /// break;
+ /// }
+ /// case MovieType.NewMovie: {
+ /// balance += (movie.DaysRented + 1) * movie.Price;
+ /// break:
+ /// }
/// }
/// }
/// </code>
@@ -84,24 +87,28 @@
/// abstract int GetPrice ();
/// }
/// class OldMovie : Movie {
- /// public override int GetPrice () {
+ /// public override int GetPrice ()
+ /// {
/// return DaysRented * Price / 2;
/// }
/// }
/// class ChildMovie : Movie {
- /// public override int GetPrice () {
+ /// public override int GetPrice ()
+ /// {
/// return movie.Price;
/// }
/// }
/// class NewMovie : Movie {
- /// public override int GetPrice () {
+ /// public override int GetPrice ()
+ /// {
/// return (DaysRented + 1) * Price;
/// }
/// }
///
/// int balance = 0;
- /// foreach (Movie movie in movies)
+ /// foreach (Movie movie in movies) {
/// balance += movie.GetPrice ()
+ /// }
/// </code>
/// </example>
/// <remarks>This rule is available since Gendarme 2.4</remarks>
Files old/mono-tools-2.6.1/po/ca.gmo and new/mono-tools-2.6.2/po/ca.gmo differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/po/ca.po new/mono-tools-2.6.2/po/ca.po
--- old/mono-tools-2.6.1/po/ca.po 2009-12-17 17:52:54.000000000 +0100
+++ new/mono-tools-2.6.2/po/ca.po 2010-02-02 19:29:31.000000000 +0100
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: Mono Tools\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-17 09:52-0700\n"
+"POT-Creation-Date: 2010-02-02 11:29-0700\n"
"PO-Revision-Date: 2004-05-28 19:18+0200\n"
"Last-Translator: Jordi Mas i Hernàndez \n"
"Language-Team: Jordi Mas i Hernàndez \n"
Files old/mono-tools-2.6.1/po/da.gmo and new/mono-tools-2.6.2/po/da.gmo differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/po/da.po new/mono-tools-2.6.2/po/da.po
--- old/mono-tools-2.6.1/po/da.po 2009-12-17 17:52:54.000000000 +0100
+++ new/mono-tools-2.6.2/po/da.po 2010-02-02 19:29:31.000000000 +0100
@@ -7,7 +7,7 @@
msgstr ""
"Project-Id-Version: GNUnit\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-17 09:52-0700\n"
+"POT-Creation-Date: 2010-02-02 11:29-0700\n"
"PO-Revision-Date: 2004-08-05 11:11+0200\n"
"Last-Translator: Martin Willemoes Hansen \n"
"Language-Team: Martin Willemoes Hansen \n"
Files old/mono-tools-2.6.1/po/es.gmo and new/mono-tools-2.6.2/po/es.gmo differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/po/es.po new/mono-tools-2.6.2/po/es.po
--- old/mono-tools-2.6.1/po/es.po 2009-12-17 17:52:54.000000000 +0100
+++ new/mono-tools-2.6.2/po/es.po 2010-02-02 19:29:31.000000000 +0100
@@ -7,7 +7,7 @@
msgstr ""
"Project-Id-Version: GNUnit\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-17 09:52-0700\n"
+"POT-Creation-Date: 2010-02-02 11:29-0700\n"
"PO-Revision-Date: 2004-08-05 11:14+0200\n"
"Last-Translator: Gonzalo Paniagua Javier \n"
"Language-Team: Gonzalo Paniagua Javier \n"
Files old/mono-tools-2.6.1/po/fr.gmo and new/mono-tools-2.6.2/po/fr.gmo differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/po/fr.po new/mono-tools-2.6.2/po/fr.po
--- old/mono-tools-2.6.1/po/fr.po 2009-12-17 17:52:54.000000000 +0100
+++ new/mono-tools-2.6.2/po/fr.po 2010-02-02 19:29:31.000000000 +0100
@@ -7,7 +7,7 @@
msgstr ""
"Project-Id-Version: GNUnit\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-17 09:52-0700\n"
+"POT-Creation-Date: 2010-02-02 11:29-0700\n"
"PO-Revision-Date: 2004-08-05 11:14+0200\n"
"Last-Translator: Sebastien Pouliot \n"
"Language-Team: Sebastien Pouliot \n"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/po/mono-tools.pot new/mono-tools-2.6.2/po/mono-tools.pot
--- old/mono-tools-2.6.1/po/mono-tools.pot 2009-12-17 17:52:54.000000000 +0100
+++ new/mono-tools-2.6.2/po/mono-tools.pot 2010-02-02 19:29:31.000000000 +0100
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-17 09:52-0700\n"
+"POT-Creation-Date: 2010-02-02 11:29-0700\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME \n"
"Language-Team: LANGUAGE \n"
Files old/mono-tools-2.6.1/po/pt_BR.gmo and new/mono-tools-2.6.2/po/pt_BR.gmo differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mono-tools-2.6.1/po/pt_BR.po new/mono-tools-2.6.2/po/pt_BR.po
--- old/mono-tools-2.6.1/po/pt_BR.po 2009-12-17 17:52:54.000000000 +0100
+++ new/mono-tools-2.6.2/po/pt_BR.po 2010-02-02 19:29:31.000000000 +0100
@@ -7,7 +7,7 @@
msgstr ""
"Project-Id-Version: Mono Tools\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2009-12-17 09:52-0700\n"
+"POT-Creation-Date: 2010-02-02 11:29-0700\n"
"PO-Revision-Date: 2004-07-06 00:13-0300\n"
"Last-Translator: Maurício de Lemos Rodrigues Collares Neto \n"
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Remember to have fun...
--
To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-commit+help@opensuse.org