Hello community, here is the log from the commit of package rpmlint for openSUSE:Factory checked in at Mon Jan 12 12:17:09 CET 2009. -------- --- rpmlint/rpmlint.changes 2009-01-08 11:14:56.000000000 +0100 +++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes 2009-01-12 10:49:42.000000000 +0100 @@ -1,0 +2,6 @@ +Mon Jan 12 10:48:19 CET 2009 - lnussel@suse.de + +- CheckFilelist: add exceptions for kde and pam +- CheckPolkitPrivs: use info instead of warning to avoid badness assignment + +------------------------------------------------------------------- calling whatdependson for head-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rpmlint.spec ++++++ --- /var/tmp/diff_new_pack.O15474/_old 2009-01-12 12:16:38.000000000 +0100 +++ /var/tmp/diff_new_pack.O15474/_new 2009-01-12 12:16:38.000000000 +0100 @@ -22,7 +22,7 @@ BuildRequires: rpm-python Summary: Rpm correctness checker Version: 0.84 -Release: 7 +Release: 9 Source0: %{name}-%{version}.tar.bz2 Source1: config Source1001: config.in @@ -220,6 +220,9 @@ /usr/share/man/man1/rpmlint.1.gz %changelog +* Mon Jan 12 2009 lnussel@suse.de +- CheckFilelist: add exceptions for kde and pam +- CheckPolkitPrivs: use info instead of warning to avoid badness assignment * Thu Jan 08 2009 lnussel@suse.de - prefix dbus check with suse- - add filelist check ++++++ CheckFilelist.py ++++++ --- /var/tmp/diff_new_pack.O15474/_old 2009-01-12 12:16:39.000000000 +0100 +++ /var/tmp/diff_new_pack.O15474/_new 2009-01-12 12:16:39.000000000 +0100 @@ -27,6 +27,13 @@ or pkg.name.endswith('-debug'): return True +def notsymlink(pkg, f): + files = pkg.files() + enreg = files[f] + mode = enreg[0] + type = (mode>>12)&017 + return type != 012 + _checks = [ { 'good': [ @@ -47,16 +54,16 @@ 'bad': [ '/usr/share/info/dir', '*~', - '*/CV', - '*/CVS/', - '*/.cvsignor', + '*/CVS', + '*/CVS/*', + '*/.cvsignore', '*/.svn', - '*/RC', - '*/RCS/', + '*/RCS', + '*/RCS/*', '*,v', - '*.ba', - '*/.xvpic', - '*.ori', + '*.bak', + '*/.xvpics', + '*.orig', '*.orig.gz', '/usr/share/*/.libs*', '/usr/share/*/.deps*', @@ -79,15 +86,28 @@ 'error': 'suse-filelist-forbidden-devel-in-lib', 'details': 'please move la files, static libs and .so symlinks out of /', 'bad': [ - "/lib/*.so", "/lib/*.la", "/lib/*.a", "/lib64/*.la", "/lib64/*.a", - "/lib64/*.so", ] }, { + 'error': 'suse-filelist-forbidden-devel-in-lib', + 'details': 'please move la files, static libs and .so symlinks out of /', + 'good': [ + # exception for pam + "/lib/security/*.so", + "/lib64/security/*.so", + ], + 'bad': [ + "/lib/*.so", + "/lib64/*.so", + ], + # some libs without proper soname are packaged directly + 'ignorefileif': notsymlink, + }, + { 'error': 'suse-filelist-forbidden-fhs22', 'msg': '%(file)s is not allowed in FHS 2.2', 'details': 'see http://www.pathname.com/fhs/ to find a better location', @@ -147,7 +167,7 @@ '/opt/kde3/lib64/*', '/usr/lib/pkgconfig/*', ], - 'ignoreif': notnoarch, + 'ignorepkgif': notnoarch, }, { 'error': 'suse-filelist-forbidden-debuginfo', @@ -155,7 +175,7 @@ 'bad': [ '/usr/lib/debug/*', ], - 'ignoreif': isdebuginfo, + 'ignorepkgif': isdebuginfo, }, { 'error': 'suse-filelist-forbidden-locale', @@ -242,6 +262,18 @@ ], }, { + 'error': 'suse-filelist-forbidden-opt', + 'details': """/opt may not be used by a distribution. It is reserved for 3rd party packagers""", + 'good': [ + # KDE3 legacy exception + '/opt/kde3', + '/opt/kde3/*', + ], + 'bad': [ + '/opt/*', + ], + }, + { 'error': 'suse-filelist-forbidden-fhs22', 'good': [ '/bin', @@ -263,6 +295,8 @@ '/media/*', '/mnt', '/opt', + # handled in separate check + '/opt/*', '/proc', '/root', '/root/.exrc', @@ -412,8 +446,8 @@ for check in _checks: - if 'ignoreif' in check: - if check['ignoreif'](pkg): + if 'ignorepkgif' in check: + if check['ignorepkgif'](pkg): continue if 'msg' in check: @@ -430,16 +464,19 @@ ok = False if 'good' in check: for g in check['good']: - if (not isinstance(g, str)) and g.match(f) or g == f: + if (not isinstance(g, str) and g.match(f)) or g == f: ok = True break if ok: continue for b in check['bad']: - if (not isinstance(b, str)) and b.match(f) or b == f: - msg = msg % { 'file':f } - printError(pkg, error, msg) + if 'ignorefileif' in check: + if check['ignorefileif'](pkg, f): + continue + if (not isinstance(b, str) and b.match(f)) or b == f: + m = msg % { 'file':f } + printError(pkg, error, m) check=FilelistCheck() ++++++ CheckPolkitPrivs.py ++++++ --- /var/tmp/diff_new_pack.O15474/_old 2009-01-12 12:16:39.000000000 +0100 +++ /var/tmp/diff_new_pack.O15474/_new 2009-01-12 12:16:39.000000000 +0100 @@ -103,7 +103,7 @@ if iserr: printError(pkg, 'polkit-unauthorized-privilege', action) else: - printWarning(pkg, 'polkit-unauthorized-privilege', action) + printInfo(pkg, 'polkit-unauthorized-privilege', action) if foundno or not anyseen: printWarning(pkg, 'polkit-cant-acquire-privilege', action) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org