Hello community, here is the log from the commit of package rpmlint checked in at Thu Jul 3 13:01:54 CEST 2008. -------- --- rpmlint/rpmlint.changes 2008-06-29 15:54:36.000000000 +0200 +++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes 2008-07-01 09:17:28.000000000 +0200 @@ -1,0 +2,5 @@ +Tue Jul 1 09:14:36 CEST 2008 - dmueller@suse.de + +- update cron dependency checker (bnc#400921) + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rpmlint.spec ++++++ --- /var/tmp/diff_new_pack.o21252/_old 2008-07-03 13:01:43.000000000 +0200 +++ /var/tmp/diff_new_pack.o21252/_new 2008-07-03 13:01:43.000000000 +0200 @@ -15,7 +15,7 @@ BuildRequires: rpm-python Summary: Rpm correctness checker Version: 0.83 -Release: 5 +Release: 7 Source0: %{name}-%{version}.tar.bz2 Source1: config Source1001: config.in @@ -196,6 +196,8 @@ /usr/share/man/man1/rpmlint.1.gz %changelog +* Tue Jul 01 2008 dmueller@suse.de +- update cron dependency checker (bnc#400921) * Sun Jun 29 2008 schwab@suse.de - No PT_GNU_STACK on ia64 and ppc64. * Sat Jun 28 2008 dmueller@suse.de ++++++ check-cron-dependency.diff ++++++ --- /var/tmp/diff_new_pack.o21252/_old 2008-07-03 13:01:43.000000000 +0200 +++ /var/tmp/diff_new_pack.o21252/_new 2008-07-03 13:01:43.000000000 +0200 @@ -1,24 +1,33 @@ --- FilesCheck.py +++ FilesCheck.py -@@ -835,6 +835,9 @@ +@@ -832,6 +832,12 @@ logrotate_file=res or logrotate_file if res and res.group(1) != pkg.name: printError(pkg, 'incoherent-logrotate-file', f) -+ if (f.startswith('/etc/cron.') or res) \ -+ and not ('cron' in pkg.requires()+pkg.recommends()+pkg.suggests()): -+ printError(pkg, 'missing-dependency-to-cron', "for logrotate script", f) ++ deps=[x[0] for x in pkg.requires()+pkg.recommends()+pkg.suggests()] ++ if res and not ('logrotate' in deps) and pkg.name != "logrotate": ++ printError(pkg, 'missing-dependency-to-logrotate', "for logrotate script", f) ++ if f.startswith('/etc/cron.') \ ++ and not ('cron' in deps) and pkg.name != "cron": ++ printError(pkg, 'missing-dependency-to-cron', "for cron script", f) link=enreg[3] if link != '': ext=compr_regex.search(link) -@@ -1463,6 +1466,12 @@ +@@ -1464,6 +1470,18 @@ if there's no way to produce useful debuginfo out of it, disable creation of the debuginfo package.''', +'missing-dependency-to-cron', -+'''This package installs a file in /etc/logrotate.d/ or in /etc/cron.*/ but ++'''This package installs a file in /etc/cron.*/ but +doesn't require cron to be installed. as cron is not part of the essential packages, -+your package should explicitely require cron to make sure that your logrotate -+or cron job is executed.''', ++your package should explicitely require cron to make sure that your cron job is ++executed. If it is an optional feature of your package, recommend or suggest cron.''', ++ ++'missing-dependency-to-logrotate', ++'''This package installs a file in /etc/logrotate.d/ but ++doesn't require logrotate to be installed. Because logrotate is not part of the essential packages, ++your package should explicitely depend on logrotate to make sure that your logrotate ++job is executed. If it is an optional feature of your package, recommend or suggest logrotate.''', + 'read-error', '''This file could not be read. A reason for this could be that the info about ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org