Mailinglist Archive: opensuse-buildservice (95 mails)

< Previous Next >
Re: [opensuse-buildservice] Release trigger via token behaves differently than releasing via osc.
Am 14.01.20 um 13:45 schrieb Stefan Seyfried:

I'd say the "matched_repo?" function in
src/api/app/controllers/trigger_controller.rb is broken, trying to debug
now...

fix:

--- a/src/api/app/controllers/trigger_controller.rb
+++ b/src/api/app/controllers/trigger_controller.rb
@@ -28,7 +28,12 @@ class TriggerController < ApplicationController
def release
raise NoPermissionForPackage.setup('no_permission', 403, "no permission
for package #{@pkg} in project
#{@pkg.project}") unless policy(@pkg).update?

- matched_repo = @pkg.project.repositories.includes(:release_targets).any? {
|repo| matched_repo?(repo) }
+ matched_repo = FALSE
+ @pkg.project.repositories.includes(:release_targets).each do |repo|
+ if matched_repo?(repo) then
+ matched_repo = TRUE
+ end
+ end

".any?" will return after first successful release 🤦

Pullrequest is on its way.
--
Stefan Seyfried

"For a successful technology, reality must take precedence over
public relations, for nature cannot be fooled." -- Richard Feynman
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-buildservice+owner@xxxxxxxxxxxx

< Previous Next >