Mailinglist Archive: opensuse-buildservice (88 mails)

< Previous Next >
Re: [opensuse-buildservice] Re: bs_srcserver seems stuck at a specific lastnotification number
On 20.06.2018 13:11, Stefan Botter wrote:
I seem to have similar problems with Packman's PMBS:


Notice the "�%9F%98%91", a hexdump excerpt is here:

00000270 69 6c 64 20 66 72 6f 6d 20 74 68 65 20 72 69 67 |ild from the rig|
00000280 68 74 20 70 6c 61 63 65 20 f0 25 39 46 25 39 38 |ht place .%9F%98|
00000290 25 39 31 25 30 41 20 20 2a 20 63 6d 61 6b 65 3a |%91%0A * cmake:|


So a user managed to sneak in an invalid character 0xC2 into a
comment and this breaks OBS.

Looks like that in my case also.

Yes.
Note that just editing out the one invalid character was not enough, because
bs_srcserver (who processes this file) then
returned an empty object to obsapidelayed.

I had to remove the invalid character and the following %-escaped one for
everything to proceed (or better: it just
jumped to the end of the queue, so just empying lastnotifications file would
proabably have had the same effect ;-)

Maybe more input checking is needed to prevent this.

I second this!

Thank you Stefan, for pointing this out!

It was a hard day of debugging. If I ever meet the guy who decided to use ruby
on rails for OBS, I will not buy him a
beer ;-)
--
Stefan Seyfried

"For a successful technology, reality must take precedence over
public relations, for nature cannot be fooled." -- Richard Feynman
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-buildservice+owner@xxxxxxxxxxxx

< Previous Next >