Mailinglist Archive: opensuse-buildservice (223 mails)

< Previous Next >
Re: [opensuse-buildservice] regression in API request handling by commit 6fd139a1dbc2dfff9cbce7f6555c4c63e11f6a65
  • From: Stephan Kulow <coolo@xxxxxxx>
  • Date: Thu, 24 May 2012 17:38:56 +0200
  • Message-id: <4FBE5610.40602@suse.de>
On 24.05.2012 17:15, Robert Schiele wrote:

Anyone with an explanation what goes wrong here or even a fix? I am
personally quite confused since I don't even understand at the moment
what exactly this change is trying to achieve. Was that checking
probably applied to the wrong content in this XML file?

Hi,

This shows clearly what goes wrong:

Started POST "/request?cmd=create" for 127.0.0.1 at 2012-05-24 17:31:50 +0200
[INFO |#10954] Processing by RequestController#create as XML
[INFO |#10954] Parameters: {"<request><description>"=>nil,
"T"=>[{"</description></request>"=>nil}], "cmd"=>"create"}

Your -f test.xml data is transferred as FORM data and as such it's split at []
This happens in rails - Adrian's funtion is then validating that paramters are
pure strings and they are not - but in this case there shouldn't be any
parameters
beside cmd=create

Greetings, Stephan

--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-buildservice+owner@xxxxxxxxxxxx

< Previous Next >
Follow Ups
References