Mailinglist Archive: opensuse-buildservice (158 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] small fix for the acl+remoteproject handling
On 2010-12-29 08:57:01 +0100, Jan-Simon Möller wrote:
Am Montag, 27. Dezember 2010, 19:35:56 schrieb Marcus Huewe:
Hi,

I just wrote a patch to fix some small issues with acl+remoteprojects:

Ok, please apply.

Ok - done.

- app/controllers/build_controller.rb
* def index: added support for remoteprojects (also added acl code for
hidden remoteprojects)
- app/controllers/source_controller.rb
* def index_project: added acl code for hidden remoteprojects
- app/models/db_project.rb
* def is_remote_project?, def find_remote_project:
added "skip_access=false" parameter to skip acl checks (by default
they're enabled)

I'm a bit unhappy with the easy override. Perhaps use an own function name ?
But up to you.

Hmm I wanted to avoid code duplication that's why I simply added the
new parameter.


Marcus
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >