Mailinglist Archive: opensuse-buildservice (158 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] small fix for the acl+remoteproject handling
  • From: "Jan-Simon Möller" <dl9pf@xxxxxx>
  • Date: Wed, 29 Dec 2010 08:57:01 +0100
  • Message-id: <201012290857.01560.dl9pf@xxxxxx>
Am Montag, 27. Dezember 2010, 19:35:56 schrieb Marcus Huewe:
Hi,

I just wrote a patch to fix some small issues with acl+remoteprojects:

Ok, please apply.

- app/controllers/build_controller.rb
* def index: added support for remoteprojects (also added acl code for
hidden remoteprojects)
- app/controllers/source_controller.rb
* def index_project: added acl code for hidden remoteprojects
- app/models/db_project.rb
* def is_remote_project?, def find_remote_project:
added "skip_access=false" parameter to skip acl checks (by default
they're enabled)

I'm a bit unhappy with the easy override. Perhaps use an own function name ?
But up to you.

- added new testcases

Btw sometimes it's possible to "detect" hidden projects. For instance
compare the output of

GET /source/<hiddenproject>
and
GET /source/<non-existent>

(I'm not quite sure if this is intended)

No, not intended. Error messages should and will be synchronized to rule out
such a case.

Best,
Jan-Simon
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups
References