Mailinglist Archive: opensuse-buildservice (158 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] Notifications do not support multiple action requests
  • From: Islam Amer <islam.amer@xxxxxxxxx>
  • Date: Sat, 4 Dec 2010 02:02:31 +0200
  • Message-id: <4CF98517.5000300@xxxxxxxxx>
Hello Klaas,

Sorry for the long delay, this patch was almost forgotten.

I have applied this patch to a build-service clone at gitorious. This is
still without fixing hermes, which I can't seem to be able to fix (or I
am not trying hard enough :) )

http://gitorious.org/~iamer/opensuse/iamers-build-service/commit/9193efdb32e5edeff985861bc330f9fd31476de7

I'll try to work on the hermes patch, any help is appreciated.


On 10/05/2010 04:56 PM, Islam Amer wrote:
Hello Klaas,

Welcome back :)

We are using a different notification plugin (AMQP, BOSS). I can fix the
hermes notification plugin, but I don't know where to start with hermes
itself.

But at least is the basic idea of the patch acceptable ?

Thanks,
Islam Amer

On 10/05/2010 03:56 PM, ext Klaas Freitag wrote:
On Thursday 30 September 2010 10:01:28 Adrian Schröter wrote:

Hi Islam,

thanks for working on that. That is a long outstanding feature request.

I was trying out multiple actions in one request and noticed that the
notifications contain only the last action.

I looked at the code and found this in /usr/lib/obs/server/BSNotify.pm
line 82 :

# FIXME: how to handle multiple actions in one request here ?
# right now the last one just wins ....

So here's a proposed fix : add an actions key in the reqinfo hash, that
contains an ordered list of hashes that contain the details of the actions.
That is, in our case, only half the way. We're using Hermes as notification
system. As your patch changes the format of what is sent to Hermes via http
we have to make Hermes understanding that as well.

I think your proposal is great, but please remember that we need to change
the notification systems before we can deploy it.

Are you also using Hermes or another system?

Thanks for your help,

Klaas

--
Thanks,
Islam Amer

< Previous Next >
This Thread
  • No further messages