On 2010-11-24 18:23:38 +0100, Pavol Rusnak wrote:
On 24/11/10 16:44, Marcus Hüwe wrote:
I just committed a slightly modified version of your patch (see 6d89fee500ba29fffd9385903ffd1cbb4886c866). Thanks for the patch!
I just pushed a commit[1] which renames requestmaintainership command to requestrole. It makes much more sense and is nicer.
Hmm I'm not quite sure if this is a good change. If we change it to requestrole I would expect something like "osc requestrole <role> [<project> <package>]" (instead of specifying a different role via a "--role" option).
Do we want osc to write "requestmaintainership is obsolete, use requestrole instead" when requestmaintainership is used? IMHO the "old" cmds should be aliases for "requestrole" instead of simply dropping them. What do you think?
OSC CLI commands have never been stable so users are probably used to checking manpage or --help, right?
Yes the UI has never been consistent... but that doesn't justify an unnecessary (IMHO) breakage:) Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org