Mailinglist Archive: opensuse-buildservice (272 mails)

< Previous Next >
Re: [opensuse-buildservice] Re: [PATCH] Revert "[backend] Indentation fixes."
  • From: Michael Schroeder <mls@xxxxxxx>
  • Date: Tue, 2 Nov 2010 16:31:40 +0100
  • Message-id: <20101102153140.GA21284@xxxxxxx>
On Tue, Nov 02, 2010 at 04:26:10PM +0100, Sascha Peilicke wrote:
On Tuesday 02 November 2010 16:14:40 you wrote:
On Tue, Nov 02, 2010 at 04:10:36PM +0100, Sascha Peilicke wrote:
This is rather odd, currently the Perl code consists of an ugly mix of
whitespaces and tabs. The code has ~95% whitespaces, so IMO the above
should be rephrased to 'please use whitespaces as everyone else'.

No, we're using perl not python in the backend.

That was below the belt and I don't see the relation. Currently, the _Perl_
backend uses a 2 spaces indentation scheme AFAICS. This is also followed
quite well with the exceptions of some tabs here and there, which the
patch tried to fix, simply.

The *indentation scheme* is 2 spaces, but that has nothing to do
with used tabs. Vi automatically converts the leading spaces to
tabs, assuming the standard tab setting at every 8 characters.


Michael Schroeder mls@xxxxxxx
SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups