Mailinglist Archive: opensuse-buildservice (245 mails)

< Previous Next >
[opensuse-buildservice] [PATCH] personal navigation alignment
  • From: Sascha Peilicke <sasch.pe@xxxxxx>
  • Date: Tue, 12 Oct 2010 09:50:12 +0200
  • Message-id: <201010120950.17051.sasch.pe@xxxxxx>
Hi,

the personal navigation bar is quite confusing currently. This patch renames
the link to the user's home project to 'Home project' and adds another link to
the user page named by the users login. This should clarify the purpose of the
links and aligns them to what is found in the bottom left.

Should also be more future prov in case the user page should be expanded with
some social stuff (e.g. like 'My contributions').
--
Mit freundlichen Grüßen,
Sascha Peilicke
http://saschpe.wordpress.com
From 9b81cd44b7ef5220cbd0395d252e6480c9ffb8f2 Mon Sep 17 00:00:00 2001
From: Sascha Peilicke <sasch.pe@xxxxxx>
Date: Tue, 12 Oct 2010 09:40:06 +0200
Subject: [PATCH] [webui] Personal navigation aligned to application template.

Previously, the personal nav area (right to breadcrumps) looks like
'user | Log out', now its 'user | Home project | Log out'. This is more
consisten to what is found down left and clarifies that the link
redirects to the users home project.
---
.../views/layouts/_personal_navigation.html.erb | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/webui/app/views/layouts/_personal_navigation.html.erb
b/src/webui/app/views/layouts/_personal_navigation.html.erb
index 7f7c4c3..c9bcb20 100644
--- a/src/webui/app/views/layouts/_personal_navigation.html.erb
+++ b/src/webui/app/views/layouts/_personal_navigation.html.erb
@@ -3,12 +3,13 @@

<% if session[:login] -%>

- <%= link_to CGI::escapeHTML(session[:login]), :controller => 'project',
:action => :show, :project => "home:#{session[:login]}" %>
+ <%= link_to session[:login], :controller => 'home', :action => :index %>
<%=
if @nr_involved_requests and @nr_involved_requests > 0
"(" + link_to(pluralize(@nr_involved_requests, 'request'), {:controller
=> 'home', :action => :list_requests}, {:title => "Number of requests
concerning #{@user}"}) + ")"
end
-%>
+ | <%= link_to "Home project", :controller => 'project', :action => :show,
:project => "home:#{session[:login]}" %>
| <%= link_to 'Log out', { :controller => 'user', :action => 'logout' },
:method => "POST" %>

<% else %>
--
1.7.1

< Previous Next >
Follow Ups