Mailinglist Archive: opensuse-buildservice (348 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH 4/6] obs-server, webui: update SPARC definitions
  • From: Martin Mohring <martin.mohring@xxxxxxxxxxxx>
  • Date: Tue, 13 Apr 2010 15:08:12 +0200
  • Message-id: <4BC46CBC.8000505@xxxxxxxxxxxx>
Ludwig Nussel wrote:
Martin Mohring wrote:

Ludwig Nussel wrote:

Adrian Schröter wrote:


Am Montag, 12. April 2010 22:27:53 schrieb Jan Engelhardt:
...


diff --git a/src/backend/bs_worker b/src/backend/bs_worker
index 6feb6bd..f779e37 100755
--- a/src/backend/bs_worker
+++ b/src/backend/bs_worker


...


@@ -1393,6 +1394,8 @@ sub dobuild {
push @args, '--release', "$release" if defined $release;
push @args, '--debug' if $buildinfo->{'debuginfo'};
push @args, '--arch', $arch;
+ # target can be different from arch (e.g. target=sparcv9, arch=sparc64)
+ push @args, '--target', $target;
push @args, '--jobs', $jobs if $jobs;
push @args, '--reason', "Building $buildinfo->{'package'} for project
'$projid' repository '$repoid' arch '$arch' srcmd5
'$buildinfo->{'srcmd5'}'";
push @args, '--disturl', $disturl;


This can have been side effects. Michael mumbled something about buggy rpm
versions in some
distros.
You may want to make this for sparc only for now.

There's a hack for ARM in the build script, it looks at
'changetarget' in prjconf in order to define the target I think.
Maybe that feature could be used here too.


This is not a hack, it is due to the behavior of rpm. We found no other
way working with all rpm versions to handle this. And: the problem
solved with this is not limited to ARM.


Atm it is both a hack (conflicts with ABUILD_TARGET_ARCH AFAICS) and
is limited to ARM :-)

1613 # case arm, extract changetarget
1614 # this is restricted to arm to make sure it doesn't interfere
with x86
1615 if [ "$BUILD_ARCH" != "${BUILD_ARCH#arm}" ]; then

cu
Ludwig


Ok. Let me say it another way: Yes, it is of course a hack (and the #arm
is a hack). But how does the "solution" instead of the hack look like? I
the only solution we found is to pass in worst case the full triple to
rpm. If the implementation of this is a hack, lets fix it.
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups