Mailinglist Archive: opensuse-buildservice (306 mails)

< Previous Next >
[opensuse-buildservice] build-2009.12.10-66.1 breaks OBS 1.6 KIWI builds
  • From: <Michael_E_Brown@xxxxxxxx>
  • Date: Tue, 19 Jan 2010 15:17:48 -0600
  • Message-id: <F757EE5C3631ED4DBDFD7709119219FE012E10EBD8@xxxxxxxxxxxxxxxxxxxxxxxxxx>
In /usr/lib/build/Build/Kiwi.pm, line 201:
$ret->{'exclarch'} = [ unify(@requiredarch) ];

The 'exclarch' is set to an empty array if there are no required arches.

In bs_srcserver, line 1222:
$rinfo->{'error'} = 'excluded' if $d->{'exclarch'} && !grep {$_ eq $arch}
@{$d->{'exclarch'}};

Which checks if the arch is in the exclarch array. If the array is empty, then
the current build arch can *never* be in this empty array, thus disabling all
KIWI builds.

My fix was to change Kiwi.pm to this:
$ret->{'exclarch'} = [ unify(@requiredarch) ] if scalar(@requiredarch);

ie. only set exclarch array if there are, in fact, exclusive arches.

There is another possible way to fix this by changing bs_srcserver to check for
the empty array, but I believe that changing Kiwi.pm is the more logical choice.
--
Michael
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages