Mailinglist Archive: opensuse-bugs (4790 mails)

< Previous Next >
[Bug 1046591] [lvm test] thin-overprovisioning.sh failed
  • From: bugzilla_noreply@xxxxxxxxxx
  • Date: Tue, 04 Jul 2017 06:17:13 +0000
  • Message-id: <bug-1046591-21960-ArVNZdF1FG@http.bugzilla.suse.com/>
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c4

zhen ren <zren@xxxxxxxx> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(hare@xxxxxxxx)

--- Comment #4 from zhen ren <zren@xxxxxxxx> ---
DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG is set to indicate not creating symlink
like /dev/${vg_name}/${lv_name} for LV that should not be visible to user, like
a thin pool LV.

lib/activate/dev_manager.c : _get_udev_flags()
"""
1665 /*
1666 * Is this top-level and visible device?
1667 * If not, create just the /dev/mapper content.
1668 */
1669 /* FIXME: add target's method for this */
1670 if (lv_is_new_thin_pool(lv))
1671 /* New thin-pool is regular LV with -tpool UUID suffix. */
1672 udev_flags |= DM_UDEV_DISABLE_DISK_RULES_FLAG |
1673 DM_UDEV_DISABLE_OTHER_RULES_FLAG;
1674 else if (layer || !lv_is_visible(lv) || lv_is_thin_pool(lv))
1675 udev_flags |= DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG |
1676 DM_UDEV_DISABLE_DISK_RULES_FLAG |
1677 DM_UDEV_DISABLE_OTHER_RULES_FLAG;
"""

udev/11-dm-lvm.rules.in:
"""
38 ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}=="1", GOTO="lvm_end"
...
46 # Create symlinks for top-level devices only.
47 ENV{DM_VG_NAME}=="?*", ENV{DM_LV_NAME}=="?*",
SYMLINK+="$env{DM_VG_NAME}/$env{DM_LV_NAME}", GOTO="lvm_end"
"""

But, this patch "Subject: [PATCH] 10-dm.rules: Reset state variables for
spurious events" cleared DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG by:
"""
+ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}=""
"""

@Hannes, this testcase will pass if I remove the line above from your patch.
But, I'm not sure if it's safe. What do you think?

--
You are receiving this mail because:
You are on the CC list for the bug.
< Previous Next >