Mailinglist Archive: opensuse-bugs (4661 mails)

< Previous Next >
[Bug 1037795] ReiserFS module crashes but contunies
  • From: bugzilla_noreply@xxxxxxxxxx
  • Date: Thu, 22 Jun 2017 19:02:19 +0000
  • Message-id: <bug-1037795-21960-4yoTbhDWh5@http.bugzilla.suse.com/>
http://bugzilla.suse.com/show_bug.cgi?id=1037795
http://bugzilla.suse.com/show_bug.cgi?id=1037795#c5

Jeff Mahoney <jeffm@xxxxxxxx> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED

--- Comment #5 from Jeff Mahoney <jeffm@xxxxxxxx> ---
This was fixed in 4.12 via:

commit 1e0e653f1136a413a9969e5d0d548ee6499b9763
Author: Jan Kara <jack@xxxxxxx>
Date: Wed Apr 5 14:17:30 2017 +0200

reiserfs: Protect dquot_writeback_dquots() by s_umount semaphore

dquot_writeback_dquots() expects s_umount semaphore to be held to
protect it from other concurrent quota operations. reiserfs_sync_fs()
can call dquot_writeback_dquots() without holding s_umount semaphore
when called from flush_old_commits().

Fix the problem by grabbing s_umount in flush_old_commits(). However we
have to be careful and use only trylock since reiserfs_cancel_old_sync()
can be waiting for flush_old_commits() to complete while holding
s_umount semaphore. Possible postponing of sync work is not a big deal
though as that is only an opportunistic flush.

Fixes: 9d1ccbe70e0b14545caad12dc73adb3605447df0
Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>


I've backported the fix to the 4.11 TW kernel. The fixed kernel will contain
the following changelog entries:

- reiserfs: Make cancel_old_flush() reliable (bsc#1037795).
- reiserfs: Protect dquot_writeback_dquots() by s_umount semaphore
(bsc#1037795).

Closing as FIXED.

--
You are receiving this mail because:
You are on the CC list for the bug.
< Previous Next >
This Thread
  • No further messages