Mailinglist Archive: opensuse-bugs (4655 mails)

< Previous Next >
[Bug 1042772] xload crashes
  • From: bugzilla_noreply@xxxxxxxxxx
  • Date: Tue, 06 Jun 2017 19:31:01 +0000
  • Message-id: <bug-1042772-21960-jN8AJklVfZ@http.bugzilla.opensuse.org/>
http://bugzilla.opensuse.org/show_bug.cgi?id=1042772
http://bugzilla.opensuse.org/show_bug.cgi?id=1042772#c5

--- Comment #5 from Egbert Eich <eich@xxxxxxxx> ---
(In reply to Martin Schröder from comment #4)
(In reply to Egbert Eich from comment #2)
This is an application that has been waiting for this report to be dropped.

Drop xload? WTF? Egbert, we need to talk. :-)

Well, it's broken. So it doesn't do any good.

Now, who is going to fix it? Who - if not the people who are most interested in
it ...?

So I'd suggest the following:

1. you can take a shot at it yourself.

Some hints: this is the line which crashes:
567 if (icl->count == 1) {
The only reason why it would crash is that icl is not set up properly.
We have:
562 if (!icl) {

This code should take care of icl not set up properly. It will only be detected
as not being properly set if it is NULL. So you need to check where icl comes
from.
- Is it uninitialized - ie contains some random number that happened to be in
memory?
- Is it stale - ie has it been set before and the memory it pointed to has been
freed without NULLing it?
563 UNLOCK_APP(app);
564 return;
565 }
566 cl = ToList(icl);
Surprising it survived this!

If you have a patch, I'd be happy to review it!

2. You can report the problem on bugs.freedesktop.org - your mileage may vary.

--
You are receiving this mail because:
You are on the CC list for the bug.
< Previous Next >
References