Mailinglist Archive: opensuse-bugs (5243 mails)

< Previous Next >
[Bug 802861] %restart_on_update macro generates warning: Stop syslog.service before reloading the daemons!

https://bugzilla.novell.com/show_bug.cgi?id=802861

https://bugzilla.novell.com/show_bug.cgi?id=802861#c3


--- Comment #3 from Marius Tomaschewski <mt@xxxxxxxx> 2013-03-01 12:25:01 UTC
---
Well.. IMO this is a general problem and the %restart_on_update macro
should be fixed to call "daemon-reload" before "try-restart <service>".


Further: I've noticed recently, that /usr/lib/rpm/(suse_)macros are
different than the macros added by the build service, where e.g.
guards like YAST_IS_RUNNING or DISABLE_RESTART_ON_UPDATE are gone.

In /usr/lib/rpm/macros there is:

%service_del_postun() %{restart_on_update %{1}}

And in /usr/lib/rpm/suse_macros is a:

%restart_on_update() \
test -n "$FIRST_ARG" || FIRST_ARG=$1 \
if test "$FIRST_ARG" -ge 1 ; then \
test -f /etc/sysconfig/services && . /etc/sysconfig/services \
if test "$YAST_IS_RUNNING" != "instsys" -a
"$DISABLE_RESTART_ON_UPDATE" != yes ; then \
test -x /bin/systemctl && /bin/systemctl daemon-reload >/dev/null
2>&1 || : \
for service in %{?*} ; do \
/etc/init.d/$service try-restart > /dev/null || : \
done \
fi \
fi \
%nil


Current rpm's (from 12.2 and from 12.3) contain:

postuninstall scriptlet (using /bin/sh):

test -n "$FIRST_ARG" || FIRST_ARG=$1
if [ $FIRST_ARG -ge 1 ]; then
# Package upgrade, not uninstall
/usr/bin/systemctl try-restart XYZ.service >/dev/null 2>&1 || :
else # package uninstall
for service in XYZ.service ; do
sysv_service=${service%.*}
rm -f "/var/lib/systemd/migrated/$sysv_service" 2> /dev/null || :
done
/usr/bin/systemctl daemon-reload >/dev/null 2>&1 || :
fi

--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

< Previous Next >