Mailinglist Archive: opensuse-bugs (3517 mails)

< Previous Next >
[Bug 673303] convert spits out rubbish to standard output

https://bugzilla.novell.com/show_bug.cgi?id=673303

https://bugzilla.novell.com/show_bug.cgi?id=673303#c15


--- Comment #15 from Petr Gajdos <pgajdos@xxxxxxxx> 2011-09-06 15:26:01 UTC ---
Yep,

use of strerror_r, no use of strerror is culprit here. I could read man-pages
more carefully :-). Thanks Marcus!

So following could be upstreamable? As far as I can see this is issue in trunk
too (even if they added *exception = '\0' before strerror_r call, so garbage
vanished from the error message).

--- magick/exception.c 2011-09-06 15:31:15.000000000 +0200
+++ magick/exception.c 2011-09-06 17:11:20.000000000 +0200
@@ -458,7 +458,11 @@ MagickExport char *GetExceptionMessage(c
exception[MaxTextExtent];

#if defined(MAGICKCORE_HAVE_STRERROR_R)
- (void) strerror_r(error,exception,sizeof(exception));
+ #if !defined(_GNU_SOURCE)
+ (void) strerror_r(error,exception,sizeof(exception));
+ #else
+ (void) CopyMagickString(exception,strerror_r(error, exception,
sizeof(exception)),sizeof(exception));
+ #endif
#else
(void) CopyMagickString(exception,strerror(error),sizeof(exception));
#endif

--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

< Previous Next >