http://bugzilla.novell.com/show_bug.cgi?id=533459 Summary: atftp-0.7.0-132.58: code in wrong order Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package atftp-0.7.0-132.58 For source code file atftp-0.7/tftpd_mtftp.c, around line 250 is the following source code int tftpd_mtftp_clean(struct mtftp_data *data) { struct mtftp_thread *thread = data->thread_data; struct mtftp_thread *tmp = data->thread_data; if (data == NULL) return OK; This code will crash if data is NULL. Suggest put if condition *BEFORE* the use of data, like if (data == NULL) return OK; struct mtftp_thread *thread = data->thread_data; struct mtftp_thread *tmp = data->thread_data; -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.