Mailinglist Archive: opensuse-bugs (6630 mails)

< Previous Next >
[Bug 530377] New: scsires-0.7-2.47: missing call to close
  • From: bugzilla_noreply@xxxxxxxxxx
  • Date: Wed, 12 Aug 2009 07:58:27 -0600
  • Message-id: <bug-530377-21960@xxxxxxxxxxxxxxxxxxxxxxxx/>
http://bugzilla.novell.com/show_bug.cgi?id=530377


Summary: scsires-0.7-2.47: missing call to close
Classification: openSUSE
Product: openSUSE 11.2
Version: Factory
Platform: All
OS/Version: openSUSE 11.1
Status: NEW
Severity: Normal
Priority: P5 - None
Component: Other
AssignedTo: bnc-team-screening@xxxxxxxxxxxxxxxxxxxxxx
ReportedBy: dcb314@xxxxxxxxxxx
QAContact: qa@xxxxxxx
Found By: ---


I just had a look at factory package scsires-0.7-2.47

For source code file scsires-0.7/scsires.c
around line 680 is the source code for the
function scsires_init_persistent_reservations.

I notice the following line of code

if ((fd = open(path, O_RDONLY | O_NDELAY)) == -1) {

but I fail to notice a matching call to close.
This looks like a resource leak to me. Suggest add call to close.

--
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

< Previous Next >
Follow Ups