http://bugzilla.novell.com/show_bug.cgi?id=528583 Summary: novel-pinyin-0.2.4-1.9: two file handling problems Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package novel-pinyin-0.2.4-1.9 For source code file novel-pinyin-0.2.4/utils/storage/gen_pinyin_table.cpp around line 210 is the source code for the function gen_phrase_file. I notice the following line of code FILE * outfile = fopen(outfilename, "w"); I can find two problems. 1. No check that the fopen succeeded. 2. No matching call to fclose. Suggest code rework, -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.