https://bugzilla.novell.com/show_bug.cgi?id=424100 Summary: asm-1.5.3 : 22 * Java source code errors Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Depends on: 424099 Found By: --- Hello there, I just tried to analyse the Suse Linux package asm-1.5.3 with the most excellent Java static analysis tool pmd. A subset of the results were /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/attrs/Annotation.java:725 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/attrs/Annotation.java:731 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/attrs/StackMapType.java:113 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/ASMifierClassVisitor.java:559 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/ASMifierClassVisitor.java:577 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/ASMifierClassVisitor.java:584 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/ASMifierClassVisitor.java:592 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:182 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:193 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:204 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:212 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:215 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:226 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:237 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:245 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:248 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:256 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMAnnotationDefaultAttribute.java:259 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/util/attrs/ASMStackMapAttribute.java:117 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/xml/Processor.java:658 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/xml/Processor.java:659 Avoid appending characters as strings in StringBuffer.append. /usr/src/packages/BUILD/asm-1.5.3/src/org/objectweb/asm/xml/SAXClassAdapter.java:251 Avoid appending characters as strings in StringBuffer.append. In each of the 22 cases, changing the string of length one into a character will save some execution time. Tests show that some 20% execution time for each statement can be made. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.