https://bugzilla.novell.com/show_bug.cgi?id=399975
User mmeeks@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=399975#c5
Michael Meeks changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
Info Provider|mmeeks@novell.com |
--- Comment #5 from Michael Meeks 2008-08-05 02:30:49 MDT ---
Looks good to commit to me; I have a few esthetic sillies ;-)
I prefer !strcmp() personally rather than == 0 - easier for me to read.
+ link_protocol_post_create_unix, /* get_sockinfo */
comment looks off ;-)
+ if (proto->post_create) (*proto->post_create) (fd, saddr);
two lines, but no extra { } is good for me ;-) ditto - removing redundant
braces in the fragment above, ditto for the fix_permissions code: cf. Linus'
coding style - vspace is a non-renewable resource ;-)
Otherwise, this looks great. I think we should conditionally compile these out
on Windows - since, well - the security model is so different there that we
will certainly break Tor. Can you add: #ifndef G_OS_WIN32 type guards around
that good stuff ?
Otherwise - this is exciting stuff.
Thanks muchly Mike ! :-) [ and can you use yast2 nicely now with the patch ? ]
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.