https://bugzilla.novell.com/show_bug.cgi?id=304399#c22
Federico Mena Quintero
Federico, please review the last attached patch
I'd compress the various instances of + if (xvkbd_running) + kill (xvkbd_pid, 9); into a helper function. Also, the part where you invoke hal-find-by-property is commented out... should that be uncommented? I don't like using system() there. Can it simply use g_spawn_sync() for safety? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.