AppleTalk atrtr_create missing write_unlock_bh

16 Nov 2004

Hello,

I found a possible missing unlock in the AppleTalk atrtr_create 
function. I believe it could be that kmalloc returns NULL which results 
into an missing unlock of atalk_routes_lock.


Helmut Tschemernjak

----------- 2.6.9 diff -u patch for net/appletalk/dpp.c ---------

--- ddp.c.sav   2004-11-15 17:31:30.091290400 +0100
+++ ddp.c       2004-11-16 09:50:38.631154808 +0100
@@ -570,7 +570,7 @@

                 retval = -ENOBUFS;
                 if (!rt)
-                       goto out;
+                       goto out_unlock;
                 memset(rt, 0, sizeof(*rt));

                 rt->next = atalk_routes;

    