From: Sascha Peilicke <saschpe@suse.de> --- src/webui/app/views/request/show.html.erb | 10 +++++----- src/webui/app/views/shared/_sourcediff.html.erb | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/webui/app/views/request/show.html.erb b/src/webui/app/views/request/show.html.erb index fbc45aa..8177f88 100644 --- a/src/webui/app/views/request/show.html.erb +++ b/src/webui/app/views/request/show.html.erb @@ -286,8 +286,8 @@ <% javascript_tag do %> $('#diff_action').change(function () { $('#diff_action option:selected').each(function() { - $('diff_action_display').hide(); - $('#diff_action_" + $(this).attr('value')).show(); + $('.diff_action_display').addClass("hidden"); + $('#diff_action_' + $('#diff_action option:selected').attr('value')).removeClass("hidden"); }); }); <% end %> @@ -295,14 +295,14 @@ <div> <% @diff_per_action.each do |index_and_type, diff| %> <% index, _ = index_and_type.split('_', 2) %> - <% table_class = "diff_action_display" %> - <% table_class += " hidden" if index != '0' %> + <% css_class = "diff_action_display" %> + <% css_class += " hidden" if index != '0' %> <% if diff[:action].source %> <% project, package, rev = diff[:action].source.project, diff[:action].source.package, diff[:action].source.rev %> <% elsif diff[:action].target # delete requests %> <% project, package, rev = diff[:action].target.project, diff[:action].target.package, diff[:action].target.rev %> <% end %> - <%= render(:partial => 'shared/sourcediff', :locals => {:filenames => diff[:filenames], :files => diff[:files], :bugs => diff[:bugs], :source => {:project => project, :package => package, :rev => rev}, :table_id => "diff_action_#{index}", :table_class => table_class}) %> + <%= render(:partial => 'shared/sourcediff', :locals => {:filenames => diff[:filenames], :files => diff[:files], :bugs => diff[:bugs], :source => {:project => project, :package => package, :rev => rev}, :css_id => "diff_action_#{index_and_type}", :css_class => css_class}) %> <% end %> </div> <% end %> diff --git a/src/webui/app/views/shared/_sourcediff.html.erb b/src/webui/app/views/shared/_sourcediff.html.erb index cd7549a..2783616 100644 --- a/src/webui/app/views/shared/_sourcediff.html.erb +++ b/src/webui/app/views/shared/_sourcediff.html.erb @@ -25,11 +25,11 @@ } <% end %> -<% table_class ||= nil %> -<% table_id ||= nil %> +<% css_class ||= nil %> +<% css_id ||= nil %> <% bugs ||= nil %> -<div> +<div <%= "class="#{css_class}"".html_safe if css_class %> <%= "id="#{css_id}"".html_safe if css_id %> > <% if bugs && bugs.length > 0 %> <%# TODO: Anything but nice, move to 'box' when request view is restructured: %> <div style="float:right;"> @@ -47,7 +47,7 @@ <% end %> <% end %> <% if filenames && filenames.length > 0 %> - <table <%= "class="#{table_class}"".html_safe if table_class %> <%= "id="#{table_id}"".html_safe if table_id %> > + <table> <tbody> <% filenames.each_with_index do |filename, index| %> <% file_element = files[filename] %> -- 1.7.7 -- To unsubscribe, e-mail: obs-commits+unsubscribe@opensuse.org To contact the owner, e-mail: obs-commits+owner@opensuse.org