Am 08.06.2013 17:07, schrieb Angelo Naselli:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Il 02/06/2013 22:57, Angelo Naselli ha scritto:
I finally implementated it, could you please give it a look?
My fork is as usual at https://github.com/anaselli
libyui, libyui-qt, libyui-ncurses, libyui-gtk.
There's something i think it could be improved, but now does what we talked about. Tomorrow i'll try on suse for regressions. Rebuilt all and yast-ycp-ui-bindings under opensuse 12.3, I seem not to see any regressions, running yast2 disk and some Table ycp examples.
Of course i think you should change something there to have play with new YTable options :)
I think i could ask for a push, but i'd prefer to get a feedback from you before... just to know if i forget something important in suse. (I'll remove some prints first :) ) I have checked the code changes for libyui-ncurses.
AFAICS the only difference to former code is that the column to check can at be at first or last column now. I think this complicates the code unnessecarily. For me YTableMode is not clearly defined, e.g. what's the difference between YTableCheckBoxOnFirstColumn and YTableMultiSelection? I think it doesn't make sense to have the checkable column at last column for ncurses (not as easy to scroll here as in qt/gtk). My suggestion is not to change libyui-ncurses because 'old' code fulfills the requirements (in my opinion). Greetings Gabi Another remark: Change below would break usage in yast disk: diff --git a/src/NCTable.cc b/src/NCTable.cc @@ -543,7 +587,7 @@ NCursesEvent NCTable::wHandleInput( wint_t key ) else { toggleCurrentItem(); - if ( notify() && immediateMode() ) + if ( notify() || immediateMode() ) -> breaks 'yast disk' module/volume management (when adding a volume group and selecting a device). { return NCursesEvent::ValueChanged; }
Angelo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlGzSMgACgkQqEs9DA4DquDs7gCZAcUUmJryfeUAG+z3RcwRlQbS xScAnRInrF7sbgcXpKMD8aNDieqldC45 =fO4S -----END PGP SIGNATURE-----
-- Gabriele Mohr SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstr. 5 Tel: +49 911 740 53 362 90409 Nürnberg Email: gs@suse.de ----------------------------------------------------------------- -- To unsubscribe, e-mail: libyui-devel+unsubscribe@opensuse.org To contact the owner, e-mail: libyui-devel+owner@opensuse.org