On Tue, Jun 27, 2017 at 04:06:22PM +0200, Theo Chatzimichos wrote:
On Sun, Jun 18, 2017 at 10:58:44PM +0200, Christian Boltz wrote:
Hello,
I linkpac'ed (with the -c option) the mediawiki and elasticsearch packages into openSUSE:infrastructure:wiki.
These packages don't come from a devel project, so please review them before we start to use them in production ;-)
BTW: You might want to read https://blog.cboltz.de/archives/76-Packaging-MediaWiki-extensions.html to understand some packaging decisions I made.
Hello,
thanks for your work! I started already checking them, I'll give you feedback in the next one-two days
I took a look, in general they are fine and production ready imho. I took the
following notes, but they are mostly minor:
elasticsearch
- why not linkpac from security:logging:elma, take changes from :devel, andrew
and his and send them all as SR to security:logging:elma
- why it has old distro / non-systemd support?
- why is the Source1 URL commented out?
- what is %setup -a1?
- what is %build true? maybe just remove the "true"?
- getent group || groupadd
- on package removal, user and group should be preserved
- instead of systemctl reload, it should do the same %service_*_* as it did for
the main package
mediawiki-1_27
- instead of linkpac to home:cboltz:infra, I would suggest to remove the _link
and osc branch openSUSE:infrastructure:wiki/$pkg
- remove the commented out Requires and Conflicts
- mediawiki gets installed in /usr/share/mediawiki-1_27, how are you handling
it in production? copying it somewhere or using it from there directly?
--
Theo Chatzimichos