[yast-devel] Travis Support: Scripts
Hi, I'm checking the current implementation of Travis support in Yast, which is a great idea indeed. One little issue I have is what the before_install: contains: - curl http://download.opensuse.org/repositories/YaST:/Head:/Travis/xUbuntu_12.04/R... | sudo apt-key add - - echo "deb http://download.opensuse.org/repositories/YaST:/Head:/Travis/xUbuntu_12.04/ ./" | sudo tee -a /etc/apt/sources.list From my POV, the "xUbuntu_12.04" is a constant used for ALL Yast module and maybe even the whole before_install: section. So, I was thinking about this: what will happen when we start using newer version of Ubuntu? Will we need to change all .travis.yml files at once? Why this is not solved by a simple script, e.g. [#1]: - prepare_travis yast2-devtools yast2-testsuite \ yast2-perl-bindings yast2 yast2-pam Then we would just need to update one place (the script itself) that would start downloading Release.key from somewhere else. Automation is a great thing, but additional work in the future should be IMO limited. So, what do you think of the proposal? Thanks Lukas #1 https://github.com/yast/yast-samba-client/pull/34/files -- Lukas Ocilka, Systems Management (Yast) Team Leader Cloud & Systems Management Department, SUSE Linux -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 30.10.2014 v 13:50 Lukas Ocilka napsal(a):
From my POV, the "xUbuntu_12.04" is a constant used for ALL Yast module and maybe even the whole before_install: section. So, I was thinking about this: what will happen when we start using newer version of Ubuntu? Will we need to change all .travis.yml files at once? Why this is not solved by a simple script, e.g. [#1]:
- prepare_travis yast2-devtools yast2-testsuite \ yast2-perl-bindings yast2 yast2-pam
Yes, I was thinking whether to use some shared script or not and decided that this could be solved later if needed... The question is where we should place the script? The "devtools" package looks like a good candidate for me. But keep in mind that we might still need to change the script location later, we cannot avoid mass changes completely...
So, what do you think of the proposal?
Yes, makes sense, I'll look at it how to improve it after the current pull requests are merged. I'd create one PR as an example and the rest could be applied globally in "master" to avoid PR flooding... (Should be doable by a simple sed script...) And I forgot to mention this: You should add a new mail filter for notifications@travis-ci.org, it will send you an email when your commit fails. See details here: http://docs.travis-ci.com/user/notifications/ -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (2)
-
Ladislav Slezak -
Lukas Ocilka