-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/21/2014 09:18 AM, Gabriele Mohr wrote:
Am 21.03.2014 08:50, schrieb Vladimir Moravec:
On 03/20/2014 03:38 PM, Lukas Ocilka wrote:
On 20.3.2014 15:31, Vladimir Moravec wrote:
So, does it mean we should change the Service.rb to use `service_start` instead of `systemctl` during (first stage) installation? Is there a `service_stop` command?
Vlado, would you have a look, please?
Yes, I will patch the Yast::Service module and I'm considering to add this also into the Yast::SystemdService to have consistent API in installation environment for both modules.
IIUC, there should be just one module to be changed and not two of them. For historical reasons we maybe have Service and SystemdService, but if we keep Service as "THE" API, then it probably just needs to call SystemdService underneath (or vice versa?).
I agree, but currently they are not merged and their API is different. Now it's easier to add support for inst-sys for both of them separatelly than to share the implementation of SystemdService within Service.
Or if the need for starting a service in inst-sys is not that urgent, I would add it later with changing the implementation of Service at once.
It's required and urgent for iSCSI client and FCoE client. These modules run during installation and need running services in inst-sys.
I added support for the /bin/service_start script in inst-sys [1], please review and comment. [1] https://github.com/yast/yast-yast2/pull/190 Vlado -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTLBLwAAoJEK0W0ULJ7Ug//0UQAKfIm/+vE5ohlyoSWflRRkOb 3aPgZKQ8gOJNF5s9DLZAcXLsE8zCKBw+D7hXaxc9fnS2O+AziSwAR+o2hycFW3xY AefzkCeFbtcgGvw0WHjSbkIZUK2kK0Nfir0fA2aQXSSxjdE+8RqT57W4aMFvXRLT 78d7VOGut3QPkz1SOPH5Ei8uPWBUqQGVXfIrGXeGzj0TB5TvR/+9LlhyG/KE1vss ODvJPYUiHCvCRNJenEDsCyATw/F380tq0uttPYmc63bVzVcdcGFrPPR3/qdZOWlo rHprsNAty9CLA7VKGDti4u3IM3QPky0I34CwrrytjMczc/wyqQiTvbXDtqZFIF+O n9mMhc6+i4aAr7QAY9Rb9FqWnBEUvsvUtKbeBaYMid+95C33EGgNAftoLPkkm4SI xUBuhAFVbKsSH44l8hdTCcI9b3WxD0X6W57LFkmU5YVyrLO4fbeh957omFn5ZAtA QF9dtLWsAOfkd51EVhthsExbSxYOqh+Gkp6zW/M2KwBBOEEQ5DN7g3qK4/gCbBq2 5eXy3t+dUepUZakqRyCHLqE8ag/1lXywDa0vn8ens9PaOJ5l9RU8s+fFajOTN036 5B2YSMjEkdIHMbK4VooIBwwaXQ9OSXbxpz45gYy4wb1GdjBYYxlAET/SL4piZ2iL Tfx9068z1egTbcJJuRhK =GivT -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org