September 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] use-activeresource: continuation
by Martin Kudlvasr 12 Oct '09

12 Oct '09

Hi, I've been continuing with the work, which Martin Vidner and Karel started 2 weeks ago - trying to use ActiveResource without service_resource.rb . This is currently the "use-activeresource" branch. I've added support for discovering controller paths from interface name. So currently there are no hard coded controller paths. Previously resources were used like this: *** Example from network_controller.rb *** hn = load_proxy "org.opensuse.yast.modules.yapi.network.hostname" *** Now they can be used like this: *** plugins/network/app/model/hostname.rb *** class Hostname < YastResource uses_interface "org.opensuse.yast.modules.yapi.network.hostname" end *** Example from network_controller.rb *** Hostname.initialize_from_interface hn = Hostname.find :one *** I think, that: - this newer approach better follows the MVC philosophy (with service_resource.rb, no model class is possible) - the YastResource < ActiveResource class is much shorter and more readable - individual model classes can be enriched by resource-specific methods - YastResource and individual models are not created dynamically - and so are easier to test (in contrast with service_resource.rb) - test can be made for the model. Currently we depend on tests in controller. - it is Black Magic Free (TM) :-) Please note, that "use-activeresource" branch depends on "resource-restful" branch, because it needs to discover individual resources (which is not possible with current "/resources" on web-service). This work was done to show, that there are other (and many think better) approaches to the problem than dynamic creation of classes in service_resource.rb. So I especially ask Duncan and Klaas, what other problems service_resource solves and YastResource does not. Please let me know what you think. Martin Kudlvasr -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 6

[yast-devel] appliance status
by Martin Vidner 05 Oct '09

05 Oct '09

VM: - I have appliance #202, sized 1GB - if you want access, I need to share a browser session with you and add your openid (which is NOT used by another istudio account) to my account - or download http://istudio.suse.de/download/8e499474d56157c0b46b041762fc1c5b/WebYaST_on… Webyast: - REST runs on port 443 so that it is accessible from outside the test drive - this fix is needed: (%post only migrates in development env.) cd /srv/www/yastws su yastws -s /bin/sh -c 'RAILS_ENV=production rake db:migrate' rcyastws restart - collectd does not run and complains about fqdn lookup, a fix is easy Next: - add mising webservice rpms, fix dependencies -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

8 20

[yast-devel] WebYaST status call 25-Sep-2009
by Ladislav Slezak 05 Oct '09

05 Oct '09

WebYaST call 25-Sep-2009 kkaempf, jsrain, lslezak, mzugec, jreidinger Status update - kkaempf: DBus service mocking - jsrain: no update - lslezak: admin config - fixed input validation - mzugec: network - data validation - jreidinger: bugfixes, build fixes -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 4

[yast-devel] Re: [yast-commit] <rest-service> master : yast2-webservice.spec - fixed yast2-core requires
by josef reidinger 01 Oct '09

01 Oct '09

Ladislav Slezak napsal(a): > ref: refs/heads/master > commit f7da8445fb1e5e934ce6d88e12f9a5b9e6f714f1 > Author: Ladislav Slezak <lslezak(a)novell.com> > Date: Wed Sep 30 18:10:41 2009 +0200 > > yast2-webservice.spec - fixed yast2-core requires > > - requires yast2-core >= 2.18.10 in Factory and > yast2-core >= 2.17.31 in SLE11 > --- > webservice/package/yast2-webservice.spec | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/webservice/package/yast2-webservice.spec b/webservice/package/yast2-webservice.spec > index b018153..b67d1a8 100644 > --- a/webservice/package/yast2-webservice.spec > +++ b/webservice/package/yast2-webservice.spec > @@ -10,7 +10,16 @@ > > > Name: yast2-webservice > -Requires: yast2-core >= 2.18.10, lighttpd-mod_magnet, ruby-fcgi, ruby-dbus, sqlite > + > +%if 0%{?suse_version} == 0 || %suse_version > 1110 > +# 11.2 or newer > +Requires: yast2-core >= 2.18.10 > +%else > +# 11.1 or SLES11 > +Requires: yast2-core >= 2.17.31 > +%endif > + > +Requires: lighttpd-mod_magnet, ruby-fcgi, ruby-dbus, sqlite > Requires: rubygem-yast2-webservice-tasks > Recommends: avahi-utils > Requires: yast2-dbus-server ^^^^ Hi, yast2-dbus-server is also on SLE11? I think that in factory is dbus splitted, but SLE11 has it in one package. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] WebYaST packages building
by Jiri Srain 30 Sep '09

30 Sep '09

Hi! We have inconsistencies in the WebYaST build (see details below (*)). In order to move forward, we need to have the package versions consistent. Therefore I suggest: - keep the webyast-specific packages the same for both build targets (as it is now); just ensure proper dependencies of the packages (see http://lists.opensuse.org/yast-devel/2009-09/msg00123.html) - use Factory (without modifications) yast2 packages to build against Factory - for SLE11 use the Code11-SP1 branch in the YaST SVN and submit the packages to YaST:Web enabling build only for SLE11. Any comments? Jiri (*) Currently, yast2-network is still not building in the YaST:Web (resp. Devel:WebYaST) repository for SLE11, some packages are failing to build against Factory. yast2-network is currently failing in initializing the build system because of conflict between yast2-2.18 and yast2-installation-2.17. The classic YaST packages with API for WebYaST, which are in the repo, are mostly coming from the SVN trunk (2.18), however, not all of YaST are there. This results in an incompatible mix of SLE11 and 11.2 packages in the buildsystem. -- Regards, Jiri Srain YaST Team Leader --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: jsrain(a)suse.cz Lihovarska 1060/12 tel: +420 284 028 959 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 4

[yast-devel] Re: [yast-commit] Build failed in Hudson: webyast-service-11.1-i586 #378
by Klaus Kaempf 30 Sep '09

30 Sep '09

* Hudson Integration Service <hudson(a)suse.de> [Sep 30. 2009 13:40]: > See http://yast.suse.de:3334/job/webyast-service-11.1-i586/378/ I've re-opened bnc#542845 to track this now. Any help appreciated. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: My status for today
by Klaus Kaempf 30 Sep '09

30 Sep '09

Hi, I've catched a cold and will stay at home for today. As I won't be able to attend our WebYaST call, here's my status. Exec summary: We haven't reached our goal yet. AI, everyone: Get your packages to build and install. Schubi did a great job yesterday in submitting packages, but we still have e.g. file conflicts. - External buildservice (OBS) is slow, so we moved to the internal one (IBS) -> See https://wiki.innerweb.novell.com/index.php/Build_Service/Internal on how to use it - The internal project is Devel:WebYaST and linked to YaST:Web, so we can continue to check into OBS. - Hudson, our test and build server, still has problems in completing a build. -> Submit your packages directly to OBS - The Hudson setup is still a mystery. Although the test and build succeeds, Hudson reports failure. - Coverage testing crashed with an internal rcov error. I've added rubygem-rcov-0.9.3 to YaST:Web and changed the buildroot on Hudson accordingly. - Current problem: Systemtime(s) test failing. All issues are tracked in Bugzilla (product 'openSUSE 11.2', component 'WebYaST'). Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] yast2 package and SLES11
by Stefan Schubert 29 Sep '09

29 Sep '09

Hi, ich have tried to build the version yast2-2.18.26 on SLES11 and have gotten missing directories. After I have changed the spec file manually it has build. Has anyone an idea why these directories are not available on SLES11 ? Greetings Stefan Index: yast2.spec =================================================================== --- yast2.spec (revision 12) +++ yast2.spec (working copy) @@ -219,17 +219,17 @@ %doc %{prefix}/share/doc/packages/yast2/autodocs %doc %{prefix}/share/doc/packages/yast2/commandline -%doc %{prefix}/share/doc/packages/yast2/control +#%doc %{prefix}/share/doc/packages/yast2/control %doc %{prefix}/share/doc/packages/yast2/cron %doc %{prefix}/share/doc/packages/yast2/cwm %doc %{prefix}/share/doc/packages/yast2/desktop %doc %{prefix}/share/doc/packages/yast2/gpg %doc %{prefix}/share/doc/packages/yast2/log -%doc %{prefix}/share/doc/packages/yast2/network +#%doc %{prefix}/share/doc/packages/yast2/network %doc %{prefix}/share/doc/packages/yast2/packages %doc %{prefix}/share/doc/packages/yast2/runlevel %doc %{prefix}/share/doc/packages/yast2/sequencer %doc %{prefix}/share/doc/packages/yast2/system %doc %{prefix}/share/doc/packages/yast2/types %doc %{prefix}/share/doc/packages/yast2/wizard -%doc %{prefix}/share/doc/packages/yast2/xml +#%doc %{prefix}/share/doc/packages/yast2/xml -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] JFYI: Ruby/Rails screencasts and conference recorgings
by Jiri Srain 29 Sep '09

29 Sep '09

Hi! I updated the WebYaST learning page and added links to Ruby/Rails screencasts and conference reconrdings which I got from our local consultant. Hope that helps, Jiri http://en.opensuse.org/YaST/Web/Development/TrainingKit#General_knowledge_f… -- Regards, Jiri Srain YaST Team Leader --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: jsrain(a)suse.cz Lihovarska 1060/12 tel: +420 284 028 959 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: Submit packages manually to OBS !
by Klaus Kaempf 29 Sep '09

29 Sep '09

Hi, Hudson, our integration testing tool, still has troubles submitting packages to the build service. Since the inner workings of this beast are a complete mystery, I do not want to lose further time by depending on it. Stefan will now submit all WebYaST packages to the build service. After that, the respective package maintainers are responsible for regular submissions to obs. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] UI workflow network during first boot
by Martin Schmidkunz 29 Sep '09

29 Sep '09

Hi, please find a first idea of network UI workflow during first boot at: http://en.opensuse.org/YaST/Web/Docu/Workflow_Network_Firstboot Thanks, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> network : correctly handle netmask/prefixlen (bnc#539889)
by josef reidinger 28 Sep '09

28 Sep '09

Michal Zugec napsal(a): > ref: refs/heads/network > commit 409cd7667168c6d03628ef0cc3b78f1fb280a54f > Author: Michal Zugec <mzugec(a)suse.cz> > Date: Mon Sep 28 21:56:38 2009 +0200 > > correctly handle netmask/prefixlen (bnc#539889) > --- > .../network/app/controllers/network_controller.rb | 16 +++++----------- > 1 files changed, 5 insertions(+), 11 deletions(-) > > diff --git a/plugins/network/app/controllers/network_controller.rb b/plugins/network/app/controllers/network_controller.rb > index 65c8f46..8c82060 100644 > --- a/plugins/network/app/controllers/network_controller.rb > +++ b/plugins/network/app/controllers/network_controller.rb > @@ -50,26 +50,20 @@ class NetworkController < ApplicationController > ipaddr = "-/-" > end > @ip, @netmask = ipaddr.split "/" > - > + # when detect PREFIXLEN with leading "/" > + @netmask = "/"+@netmask if ifc.bootproto == "static" && @netmask.to_i >= 0 && @netmask.to_i <= 32 ^^^ I think that this complex condition should be in separated if statement. This version is not much readable. I suggest use constant for netmask and test range. Somethink like: NETMASK_RANGE = 0..32 if ifc.bootproto == "static" && NETMASK_RANGE.include?(netmask.to_i) @netmask = "/"+@netmask end > + > @name = hn.name > @domain = hn.domain > @nameservers = dns.nameservers > @searchdomains = dns.searches > @default_route = rt.via > - #FIXME: this is ugly and keys are duplicated, but otherwise seems it doesn't work > - @conf_modes = [["",""], ["static","static"], ["dhcp", "dhcp"]] > - # if unknown item, just add it into list > - found = false > - @conf_modes.each {|a| found=true if a[0] == @conf_mode} > - @conf_modes << [@conf_mode, @conf_mode] if !found > + @conf_modes = {""=>"", _("static")=>"static", _("dhcp")=>"dhcp"} > + @conf_modes[@conf_mode] ||=@conf_mode Hi, you mix two sollution which I suggest to you and this doesn't work For example you have static...translated to cz is staticky and on second line you test if exist @conf_modes["static"] but you have @conf_mode["staticky"] so this is not produce valid output. As I suggest revert this hash (so conf_mode is keys and localized strings is values) and in options_for use @conf_modes.invert. When I come to work we should look at it together. > > end > > > - # GET /users/1/edit > - def edit > - end > - > > # PUT /users/1 > # PUT /users/1.xml -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 1

[yast-devel] Building WebYaST packages locally
by Klaus Kaempf 28 Sep '09

28 Sep '09

Hi, at http://en.opensuse.org/YaST/Web/Development/Packaging you can now find a page describing how to build WebYaST packages locally. Enjoy ! Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : small fixes to restfull resource
by Josef Reidinger 25 Sep '09

25 Sep '09

Martin Kudlvasr write: > ref: refs/heads/master > commit aa80f8228d1d0d9cd349a7b0d2f054b0138e67ed > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Tue Sep 15 16:15:15 2009 +0200 > > small fixes to restfull resource > --- > webservice/app/controllers/resources_controller.rb | 14 ++++++-------- > webservice/app/models/resource.rb | 10 ++++++++-- > webservice/app/views/resources/index.html.erb | 5 ++--- > webservice/app/views/resources/show.html.erb | 4 ++-- > webservice/config/routes.rb | 3 ++- > 5 files changed, 20 insertions(+), 16 deletions(-) > > diff --git a/webservice/app/controllers/resources_controller.rb > b/webservice/app/controllers/resources_controller.rb index > 087010a..ae90e04 100644 > --- a/webservice/app/controllers/resources_controller.rb > +++ b/webservice/app/controllers/resources_controller.rb > @@ -3,23 +3,21 @@ class ResourcesController < ApplicationController > > def index > @resources = Resource.all > + do_respond > + end > + > + def do_respond > @node = "Yast" > > - logger.debug("Ahoj!") > - debugger > respond_to do |format| > format.html > format.xml { render :xml => @resources.to_xml } > + format.json{ render :json=> @resources.to_json} > end > end > > def show > @resources = Resource.find(params[:id]) > - @node = "Yast" > - > - respond_to do |format| > - format.html > - format.xml { render :xml => @resources.to_xml } > - end > + do_respond > end > end > diff --git a/webservice/app/models/resource.rb > b/webservice/app/models/resource.rb index 8cd8b1e..417ec2b 100644 > --- a/webservice/app/models/resource.rb > +++ b/webservice/app/models/resource.rb > @@ -7,6 +7,8 @@ class Resource > attr_accessor :implementations > > class Implementation > + attr_accessor :controller, :interface > + > def initialize(interface, impl_hash) > @interface = interface > @policy = impl_hash[:policy] > @@ -15,18 +17,22 @@ class Resource > end > > def link_to > - "/#{@controller}/#{@singular ? "show" : "index"}" > + "/#{@controller}/#{action}" ^^^ This is root of actual problems. It is not true, that route is controller. It is not how is routes created in lib/resource_registration. So this two values dismatch and all plugin that have different last identifier from interface and controller name is broken. (now systemtime plugin) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Webyast - Serious problem with backend routing
by Josef Reidinger 25 Sep '09

25 Sep '09

Hi, I think it is related to last mkudlvasr changes, but he maybe just fix something which open Pandora box. So where is problem - backend create routes based on interace last item (so from org.opensuse.yast.modules.YaPI.time it create /time route). Problem is that for systemtime controller name is systemtime route which expect another part of code from resource_service. So I ended up with non-working frontend because proxy_for return me /systemtimes path but on backend is registered /time path. I create test case and send it to git. So now git is broken, but I think it is better then created broken package. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] webyast on SLE11: no ruby-fcgi
by Martin Vidner 25 Sep '09

25 Sep '09

Hi, I have tried installing from RPMs on SLE11, and now I have another thing to consider when choosing our webserver: the availability of SLE packages. So far I miss - lighttpd-mod_magnet (in OBS server:http SLE_11) - ruby-fcgi (no build for SLE_11) If we do want a provisional demo on SLE11, I suggest using an available OBS repo (for mod_magnet) or copying the package (ruby-fcgi) to YaST:Web with a fat note like PROVISIONAL, NOT IN SLE, REPLACE WITH SOMETHING SUPPORTABLE Sorry, I will not have time to fix this, I am on vacation from Friday to Tuesday. -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] SuSE-Code-11-SP1-Branch created
by Martin Vidner 25 Sep '09

25 Sep '09

Hi, >From SuSE-Code-11-Branch r58747 (which should have only SLE11 maintenance updates) I have branched SuSE-Code-11-SP1-Branch. The changes in the SP1-Stash (there are 80 of them BTW) will be merged soon by jsrain. As always, please refer to http://en.opensuse.org/YaST/Development/SVN_branches -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <web-client> network : for configuration mode use combo box (bnc#540229)
by josef reidinger 24 Sep '09

24 Sep '09

Michal Zugec napsal(a): > ref: refs/heads/network > commit da9fb271b2b1b5b2885702cc7a2ca1261da29664 > Author: Michal Zugec <mzugec(a)suse.cz> > Date: Thu Sep 24 19:23:44 2009 +0200 > > for configuration mode use combo box (bnc#540229) > --- > .../network/app/controllers/network_controller.rb | 8 +++++++- > plugins/network/app/views/network/index.html.erb | 2 +- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/plugins/network/app/controllers/network_controller.rb b/plugins/network/app/controllers/network_controller.rb > index 29c2f74..65c8f46 100644 > --- a/plugins/network/app/controllers/network_controller.rb > +++ b/plugins/network/app/controllers/network_controller.rb > @@ -56,7 +56,13 @@ class NetworkController < ApplicationController > @nameservers = dns.nameservers > @searchdomains = dns.searches > @default_route = rt.via > - > + #FIXME: this is ugly and keys are duplicated, but otherwise seems it doesn't work ^^^^^^ If you properly read how options for select works you understand why it is. You can read it here -> http://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.htm… > + @conf_modes = [["",""], ["static","static"], ["dhcp", "dhcp"]] so you can change it to hash version or use array, but translate it ;) @conf_modes = {""=>"", _("static") =>"static", _("dhcp") => "dhcp"} # disclaimer - writed without try, so maybe it can be buggy, just for demonstration ;) > + # if unknown item, just add it into list > + found = false > + @conf_modes.each {|a| found=true if a[0] == @conf_mode} > + @conf_modes << [@conf_mode, @conf_mode] if !found change to: @conf_modes[@conf_mode]=@conf_mode unless @conf_modes.has_value(@conf_mode) #warning, unknown mode is not translated, at least log it > + > end > > > diff --git a/plugins/network/app/views/network/index.html.erb b/plugins/network/app/views/network/index.html.erb > index 50a20b1..104d2e4 100644 > --- a/plugins/network/app/views/network/index.html.erb > +++ b/plugins/network/app/views/network/index.html.erb > @@ -34,7 +34,7 @@ > </tr> > <tr> > <td class="first" width="120"><strong><%=_("Configuration Mode")%></strong></td> > - <td class="last"><%=text_field_tag :conf_mode, @conf_mode, :disabled => disabled %></td> > + <td class="last"><%= select_tag(:conf_mode, options_for_select(@conf_modes, @conf_mode), :disabled => disabled)%></td> > </tr> > <tr> > <td class="first" width="120"><strong><%=_("IP Address")%></strong></td> If you have any question, you can ask me tomorrow. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] r58757 - in /trunk/registration/src: config/org.opensuse.yast.modules.yapi.ysr.policy modules/YSR.pm_web
by josef reidinger 24 Sep '09

24 Sep '09

jdsn(a)svn.opensuse.org napsal(a): > Author: jdsn > Date: Thu Sep 24 18:51:20 2009 > New Revision: 58757 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=58757&view=rev > Log: > files for webyast support - not yet included > > Added: > trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.policy > trunk/registration/src/modules/YSR.pm_web > > Added: trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.policy > URL: http://svn.opensuse.org/viewcvs/yast/trunk/registration/src/config/org.open… > ============================================================================== > --- trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.policy (added) > +++ trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.policy Thu Sep 24 18:51:20 2009 > @@ -0,0 +1,20 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<!DOCTYPE policyconfig PUBLIC "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN" > + "http://www.freedesktop.org/standards/PolicyKit/1.0/policyconfig.dtd"> > + > +<policyconfig> > + <vendor>Novell, Inc.</vendor> > + <vendor_url>http://www.novell.com</vendor_url> > + > + <action id="org.opensuse.yast.modules.yapi.ysr.stateless_register"> > + <description>Run a registration in stateless context.</description> > + <message>Could not run YSR.stateless_register.</message> > + <defaults> > + <allow_any>no</allow_any> > + <allow_inactive>no</allow_inactive> > + <allow_active>auth_admin_keep_session</allow_active> > + </defaults> > + </action> > + > +</policyconfig> > + > > Added: trunk/registration/src/modules/YSR.pm_web > URL: http://svn.opensuse.org/viewcvs/yast/trunk/registration/src/modules/YSR.pm_… > ============================================================================== > --- trunk/registration/src/modules/YSR.pm_web (added) > +++ trunk/registration/src/modules/YSR.pm_web Thu Sep 24 18:51:20 2009 > @@ -0,0 +1,308 @@ > +# > +# Copyright (c) 2008 SUSE LINUX Products GmbH. All rights reserved. > +# > +# Author: Michael Calmer <mc(a)suse.de>, 2008 > +# Editor: J. Daniel Schmidt <jdsn(a)suse.de>, 2008,2009 > +# > +# YSR.pm - interface for YaST to interact with SUSE::SuseRegister > +# > + > +package YSR; > + > +use strict; > +use SUSE::SuseRegister; > +use Data::Dumper; > + > +use YaPI; > + > +our %TYPEINFO; > + > +my $global_ctx = {}; > + > + > +BEGIN { $TYPEINFO{init_ctx} = ["function", "void", [ "map", "string", "any"]]; } > +sub init_ctx > +{ > + my $self = shift; > + my $data = shift; > + > + if(defined $global_ctx && ref($global_ctx) eq "HASH" && exists $global_ctx->{debug}) > + { > + # ctx is initialized; clean it before we re-init it > + $self->del_ctx(); > + } > + > + $global_ctx = SUSE::SuseRegister::init_ctx($data); > +} > + > +BEGIN { $TYPEINFO{del_ctx} = ["function", "void"]; } > +sub del_ctx > +{ > + my $self = shift; > + > + if(defined $global_ctx && ref($global_ctx) eq "HASH" && exists $global_ctx->{debug}) > + { > + # only call del_ctx if it is initialized > + SUSE::SuseRegister::del_ctx($global_ctx); > + } > + > + $global_ctx = {}; > +} > + > +BEGIN { $TYPEINFO{get_errorcode} = [ "function", "integer"]; } > +sub get_errorcode > +{ > + my $self = shift; > + > + return $global_ctx->{errorcode}; > +} > + > +BEGIN { $TYPEINFO{get_errormsg} = [ "function", "string"]; } > +sub get_errormsg > +{ > + my $self = shift; > + > + return $global_ctx->{errormsg}; > +} > + > +BEGIN { $TYPEINFO{listParams} = ["function", "string"]; } > +sub listParams > +{ > + my $self = shift; > + > + return SUSE::SuseRegister::listParams($global_ctx); > +} > + > +BEGIN { $TYPEINFO{register} = ["function", "integer"]; } > +sub register > +{ > + my $self = shift; > + > + my $ret = SUSE::SuseRegister::register($global_ctx); > + > + return $ret; > +} > + > +BEGIN { $TYPEINFO{getTaskList} = ["function", [ "map", "string", "any"] ]; } > +sub getTaskList > +{ > + my $self = shift; > + > + return SUSE::SuseRegister::getTaskList($global_ctx); > +} > + > +BEGIN { $TYPEINFO{get_args} = [ "function", [ "map", "string", ["map", "string", "string"]]]; } > +sub get_args > +{ > + my $self = shift; > + > + return $global_ctx->{args}; > +} > + > +BEGIN { $TYPEINFO{set_args} = [ "function", "void", [ "map", "string", ["map", "string", "string"]]]; } > +sub set_args > +{ > + my $self = shift; > + my $args = shift; > + > + if(defined $args && ref($args) eq "HASH") > + { > + $global_ctx->{args} = $args; > + } > +} > + > +BEGIN { $TYPEINFO{set_arg} = [ "function", "void", "string", [ "map", "string", "string"]]; } > +sub set_arg > +{ > + my $self = shift; > + my $key = shift; > + my $value = shift; > + > + if(defined $key && $key ne "") > + { > + if(defined $value && ref($value) eq "HASH" ) > + { > + $global_ctx->{args}->{key} = $value; > + } > + else > + { > + delete $global_ctx->{args}->{key}; > + } > + } > +} > + > +BEGIN { $TYPEINFO{get_manualURL} = [ "function", "string"]; } > +sub get_manualURL > +{ > + my $self = shift; > + > + return $global_ctx->{registerManuallyURL}; > +} > + > +BEGIN { $TYPEINFO{get_registerReadableText} = [ "function", "string"]; } > +sub get_registerReadableText > +{ > + my $self = shift; > + > + return join('', @{$global_ctx->{registerReadableText}}); > +} > + > +BEGIN { $TYPEINFO{get_registerPrivPol} = [ "function", "string"]; } > +sub get_registerPrivPol > +{ > + my $self = shift; > + > + return $global_ctx->{registerPrivPol}; > +} > + > +BEGIN { $TYPEINFO{saveLastZmdConfig} = [ "function", ["list", "any"]]; } > +sub saveLastZmdConfig > +{ > + my $self = shift; > + > + return SUSE::SuseRegister::saveLastZmdConfig($global_ctx); > +} > + > +BEGIN { $TYPEINFO{set_proxy} = ["function", "void", "string", "string"]; } > +sub set_proxy > +{ > + my $self = shift; > + my $http_proxy = shift; > + my $https_proxy = shift; > + > + if(defined $http_proxy && $http_proxy =~ /^http/) > + { > + $ENV{http_proxy} = $http_proxy; > + } > + > + if(defined $https_proxy && $https_proxy =~ /^http/) > + { > + $ENV{https_proxy} = $https_proxy; > + } > +} > + > + > +BEGIN { $TYPEINFO{stateless_register} = ["function", [ "map", "string", "any"], ["map", "string", "any"] ]; } > +sub stateless_register > +{ > + my $self = shift; > + my $args = shift; > + > +#return { 'msg' => '4711' }; > + > + unless ( defined $args && ref($args) eq "HASH" ) > + { > + print "args is not a hash in YSR::statless_register. This is a bug. Please report this error.\n"; > + #return { 'error' => 'The call of the registration failed because of missing arguments.' } > + return { 'error' => { 'args' => 'The call of the registration failed because of missing arguments.' } }; > + } > + > +#return { 'msg' => '4712' }; > + # check if the system is still initialized - otherwise run init_ctx again > + unless ( defined $global_ctx && ref($global_ctx) eq "HASH" && exists $global_ctx->{debug} ) > + { > + # not initialized - need to reinitialize > + > +#return { 'msg' => '4713' }; > + # 1. proxy > + if ( exists $args->{'proxy'} && ref($args->{'proxy'}) eq "HASH" ) > + { > + my $http = $args->{'proxy'}{'http_proxy'} || undef; > + my $https = $args->{'proxy'}{'https_proxy'} || undef; > + $self->set_proxy($http, $https); > + } > + > +#return { 'msg' => '4714' }; > + # 2. registration context > + if ( exists $args->{'ctx'} && $args->{'ctx'} eq "HASH" ) > + { > + $self->init_ctx($args->{'ctx'}); > + my $init_err = $self->get_errorcode(); > + > + unless ($init_err == 0) > + { > + # init failed > + return { 'error' => { 'init' => 'The initialization of the registration failed.' } }; > + } > + } > + else > + { > +#return { 'msg' => '4715' }; > + # context is broken - return error message > + return { 'error' => { 'ctx' => 'The context for the registration is invalid.' } }; > + } > + } > + > + return { 'success' => { 'msg' => 'This is the return string.' } }; > + > +} > + > +1; > + > +############################################################################# > +############################################################################# > +# > +# internal functions that should not be used directly by YaST (to prevent zypp deadlocks) > +# they are here for documentation purposes or future use > +# > + > +# BEGIN { $TYPEINFO{get_ctx} = ["function", [ "map", "string", "any"]]; } > +# sub get_ctx > +# { > +# my $self = shift; > + > +# return $global_ctx; > +# } > + > +# BEGIN { $TYPEINFO{manageUpdateSources} = ["function", "void", [ "map", "string", "any"] ]; } > +# sub manageUpdateSources > +# { > +# my $self = shift; > + > +# return SUSE::SuseRegister::manageUpdateSources($global_ctx); > +# } > + > + > +# BEGIN { $TYPEINFO{addService} = ["function", ["list", "any"], [ "map", "string", "any"], [ "map", "string", "any"]]; } > +# sub addService > +# { > +# my $self = shift; > +# $global_ctx = shift; > +# my $service = shift || undef; > + > +# return SUSE::SuseRegister::addService($global_ctx, $service); > +# } > + > + > +# BEGIN { $TYPEINFO{enableCatalog} = ["function", ["list", "any"], [ "map", "string", "any"], "string", [ "map", "string", "string"]]; } > +# sub enableCatalog > +# { > +# my $self = shift; > +# $global_ctx = shift; > +# my $name = shift || undef; > +# my $catalog = shift || undef; > + > +# return SUSE::SuseRegister::enableCatalog($global_ctx, $name, $catalog); > +# } > + > +# BEGIN { $TYPEINFO{deleteService} = ["function", ["list", "any"], [ "map", "string", "any"], [ "map", "string", "any"]]; } > +# sub deleteService > +# { > +# my $self = shift; > +# $global_ctx = shift; > +# my $service = shift || undef; > + > +# return SUSE::SuseRegister::deleteService($global_ctx, $service); > +# } > + > +# BEGIN { $TYPEINFO{disableCatalog} = ["function", ["list", "any"], [ "map", "string", "any"], "string", [ "map", "string", "string"]]; } > +# sub disableCatalog > +# { > +# my $self = shift; > +# $global_ctx = shift; > +# my $name = shift || undef; > +# my $catalog = shift || undef; > + > +# return SUSE::SuseRegister::disableCatalog($global_ctx, $name, $catalog); > +# } > + > Hi, I think it is not good idea to add to YaPI methods which doesn't have defined permissions. You can add this function to internal function without exporting signature or add to permissions list. (these methods is placed to dbus service, but you have problems to get this permissions) Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] on webyast local builds
by Martin Kudlvasr 24 Sep '09

24 Sep '09

Hi, well, that was quick. When finding out how to make local build work (because packages from other projects are needed), I have found out that they actually DO work! In particular packages from devel:languages:ruby:extensions are used in the build by default and without any problem. # osc meta prj YaST:Web ... <repository name="openSUSE_Factory"> <path project="devel:languages:ruby:extensions" repository="openSUSE_Factory"/> <arch>x86_64</arch> <arch>i586</arch> </repository> ... So it is the <path> element, which does the work. Cheers, Martin -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST status call 2009-09-24
by Jiri Srain 24 Sep '09

24 Sep '09

present: kkaempf, schubi, lslezak, jsrain, mzugec, mkudlvasr, mvidner kkaempf: - looked into patch model mocking (D-Bus, PackageKit) - refactored, added more comments - TODO: factor out generic D-Bus and PackageKit mocking schubi: - finished language translation stuff, sent to translators - fixing bugs (looks like gettext gem) lslezak: - REST API documentation - looking at administrator UI validation problems mzugec: - no progress mkudlvasr: - merged resource restful branch to master - finished YaST resource class - TODO: research local package build mvidner: - fixing base system setup workflow - put yast2-network for SLES11 into OBS to make network plug-in working from RPM AI everybody: check that all packages build -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] custom log merged
by Duncan Mac-Vicar Prett 23 Sep '09

23 Sep '09

I have just merged the log monitor into master. The documentation will go here: http://en.opensuse.org/YaST/Web/VendorCustomization However the config file format is still on RFC: http://lists.opensuse.org/yast-devel/2009-09/msg00056.html Known bugs: - If the service goes down, the ajax update shows infinite errors ( https://bugzilla.novell.com/show_bug.cgi?id=540623 ) Together with the merge, a new model class called Metrics went into the service, together with a MetricsController. This classes are supposed to replace Status and StatusController by providing a cleanuped version using collectd name conventions and a more ActiveResource complaint interface, plus tests done from the beginning, and I intend to port the client so the graphs can be overlapped by instance (see http://auxesis.github.com/visage/) but this is no priority for now. -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] 6.17.1: New method ui::Selectable::updateCandidateObj
by Michael Andres 23 Sep '09

23 Sep '09

Hi! I added a new method ui::Selectable::updateCandidateObj. As you know it's not sufficient to simply look for an available package with higher version, when looking for an update candidate. There are more policies to respect, like the ones for arch and vendor changes. Also repo priorities may influence the result. updateCandidateObj will return you whether the candidateObj matches the active solver policies and has a greater version, and no PoolItem otherwise. So if the UI wants to suggest Selectables that could be updated, it could suggest the ones providing an updateCandidateObj, and not all where the candidate has 'just' a greater version. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma(a)novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 2009-09-23
by Jiri Srain 23 Sep '09

23 Sep '09

present: mschmidkunz, lslezak, jsrain, jreidinger, mzugec jdsn: - no progress mschimidkunz: - UI mock-ups for network administration and time - TODO: look at bugs lslezak: - spec-file versioning on ML - documenting the documentation process of REST service jreidinger: - debugging problems of FireFox and base system, working on testcase for Firefox mzugec: - no progress - TODO: bzilla -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Registration Rest Api
by J. Daniel Schmidt 22 Sep '09

22 Sep '09

Hi hackers, I want to share my current thoughts about the Rest Api for the registration. Please have a look and feel free to comment and ask. Registration Configuration: --------------------------------- * /registration/config GET get registration server returns: <registrationconfig> <server> <url>https://myregistration.server.com/center/regsvc</url> </server> </registrationconfig> PUT set new registration server the certificate is inclueded as well post data: <registrationconfig> <server> <url>https://somewhere.else.com/center/regsvc</url> </server> <certificate> <data> <![CDATA[ -----BEGIN CERTIFICATE----- MIIFIDCCBAigAwIBAgIJAPP6cY6saTFlMA0GCSqGSIb3DQEBBQUAMIGPMQswCQYD VQQGEwJERTEPMA0 ......... 60QTef32lxeuVH9Kve8gGZiMwDqcJfl J8NLO3kNW3Zys2p4agg22yttmUs= -----END CERTIFICATE----- ]]> </data> </certificate> </registrationconfig> return value is the same as for GET Run Registration: --------------------------------- * /registration POST run registration and return the/a result post data: <registration> <options> <debug>2</debug> <nooptional>1</nooptional> <nohwdata>1</nohwdata> <forcereg>0</forcereg> <httpproxy>http://my.proxy</httpproxy> <httpsproxy>http://my.proxy</httpsproxy> </options> <arguments> <argument> <name>key</name> <value>val</value> </argument> ... </arguments> <registration> returns: <registration> <status>finished|missinginfo|error</status> <message>Some text to display</message> <guid>systemsguid</guid>  <missingarguments> <argument> <name>missingkey</name> <type>string|text|number</type> </argument> ... </missingarguments>  <changedrepos> <repo> <name>repoName</name> <alias>myRepoName</alias> <urls> <url>http://some.host/repo/xy</url> ... </urls> <priority>80</priority> <autorefresh>true</autorefresh> <enabled>true</enabled> <status>added|deleted</status> </repo> ... </changedrepos> <changedservices> <service> <name>some-serv1</name> <url>http://some.host/services/serv1</url> <status>added|deleted</status> </service> ... </changedservices> </registration> There is only one action to perform the registration. And all data has to be send for each request, as it operates in stateless context. The following action depends on the answer to the request. If there are arguments missing a following call is needed (together with the additional arguments). Otherwise the changes to the package system are returned if the registration succeeded. Thanks for comments. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

5 11

[yast-devel] Distribution dependent Requires: in *.spec file (SLE11 vs. 11.2)
by Ladislav Slezak 22 Sep '09

22 Sep '09

Hi all, We need to have correct WebYaST package dependencies to YaST in both 11.2 and SLE11 distributions. Because yast packages have completely different version numbers we have to explicitly check this in *.spec file using %suse_version macro. Example (just committed in 'service' REST plugin): ----------------------------------------------------------- # YaPI/SERVICES.pm %if 0%{?suse_version} == 0 || %suse_version > 1110 # 11.2 or newer Requires: yast2 >= 2.18.24 %else # 11.1 or SLES11 Requires: yast2 >= 2.17.10.2 %endif ----------------------------------------------------------- Please adapt your packages accordingly. See http://en.opensuse.org/Build_Service/cross_distribution_package_how_to for more details. -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-09-21
by Jiri Srain 22 Sep '09

22 Sep '09

present: kkaempf, dmacvicar, schubi, mschmidkunz, lslezak, jsrain, jreidinger kkaempf: - administrative stuff dmacvicar: - merged log into master - ongoing discussion on ML schubi: - continued translation stuff jreidinger: - merged NTP code to master - exceptions discussion on ML - TBD: testing, bugfixing mschmidkunz: - learning jquery - redesign of network mock-up -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : Change calling conventions for Invalid parameters to follow DRY
by Klaus Kaempf 22 Sep '09

22 Sep '09

* Josef Reidinger <jreidinger(a)suse.cz> [Sep 22. 2009 10:29]: > else > logger.warn("No argument to update") > - raise InvalidParameters.new [{:name => "language", :error => "Missing"}] > + raise InvalidParameters.new :language => "Missing" This is looking way better now, thanks Josef. Now I wonder if the "Missing" string shouldn't be replaced by a constant to make its semantic meaning clearer ?! Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYast: Error reporting in backend and how to use it in plugin
by Josef Reidinger 22 Sep '09

22 Sep '09

Hi, I done error reporting in backend based on exceptions (Universal exceptions is in file exceptions in webservice/lib). There is two type of error: First is invalid or missing parameters. For this case exist InvalidParameters exceptions. For example usage and details please see documentation of this exceptions. After you throw it, then if you don't catch it, it response 422 and use Error reporting structure for ActiveResource. So it return false on ActiveResource#save see ActiveResource::Base documentation for details (section validations errors). Second is problem on target machine like missing file, failed call of script, missing permissions etc. For this case exist ancestor BackendError which if not catched response 503 and serialized xml with description of problem (exceptions.rb contains few child for inspiration). If you don't catch error on frontend it end up in error reporting page which print error. For translated error is neccesarry to add translated string to ErrorConstructor module in libs directory at frontend (see already translated messages for usage). If you have any question, suggestion or problem please say it -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] Hudson does not build anymore
by Stefan Schubert 22 Sep '09

22 Sep '09

-------- Original-Nachricht -------- Betreff: Hudson does not build anymore Datum: Tue, 22 Sep 2009 10:00:50 +0200 Von: Stefan Schubert <schubi(a)suse.de> An: YaST-devel <yast-devel(a)opensuse.org> Hi, since my last chances in translation Hudson reports errors while building packages. Sorry for that. I will take care .... Greetings Stefan -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : Switched to the InvalidParameters exception.
by Josef Reidinger 21 Sep '09

21 Sep '09

On Monday 21 September 2009 12:48:10 Martin Vidner wrote: > ref: refs/heads/master > commit 31a423025739c568c47ccd8a49faca381da583da > Author: Martin Vidner <mvidner(a)suse.cz> > Date: Mon Sep 21 12:18:07 2009 +0200 > > Switched to the InvalidParameters exception. > --- > .../app/controllers/network/dns_controller.rb | 2 +- > .../app/controllers/network/hostname_controller.rb | 2 +- > .../controllers/network/interfaces_controller.rb | 2 +- > .../app/controllers/network/routes_controller.rb | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/plugins/network/app/controllers/network/dns_controller.rb > b/plugins/network/app/controllers/network/dns_controller.rb index > 810b7df..bcfe961 100644 > --- a/plugins/network/app/controllers/network/dns_controller.rb > +++ b/plugins/network/app/controllers/network/dns_controller.rb > @@ -11,7 +11,7 @@ class Network::DnsController < ApplicationController > def update > root = params[:dns] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Dns", :error => > "Missing"}] end > > root["searches"]=root["searches"].split > diff --git a/plugins/network/app/controllers/network/hostname_controller.rb > b/plugins/network/app/controllers/network/hostname_controller.rb index > cd85d66..86c51d3 100644 > --- a/plugins/network/app/controllers/network/hostname_controller.rb > +++ b/plugins/network/app/controllers/network/hostname_controller.rb > @@ -12,7 +12,7 @@ class Network::HostnameController < ApplicationController > def update > root = params[:hostname] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Hostname", :error => > "Missing"}] end > > @hostname = Hostname.new(root) > diff --git > a/plugins/network/app/controllers/network/interfaces_controller.rb > b/plugins/network/app/controllers/network/interfaces_controller.rb index > 5571039..a377a09 100644 > --- a/plugins/network/app/controllers/network/interfaces_controller.rb > +++ b/plugins/network/app/controllers/network/interfaces_controller.rb > @@ -11,7 +11,7 @@ class Network::InterfacesController < > ApplicationController def update > root = params[:interfaces] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Interfaces", :error > => "Missing"}] end > > @iface = Interface.new(root) > diff --git a/plugins/network/app/controllers/network/routes_controller.rb > b/plugins/network/app/controllers/network/routes_controller.rb index > 571d132..011620a 100644 > --- a/plugins/network/app/controllers/network/routes_controller.rb > +++ b/plugins/network/app/controllers/network/routes_controller.rb > @@ -11,7 +11,7 @@ class Network::RoutesController < ApplicationController > def update > root = params[:routes] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Routes", :error => > "Missing"}] end > @route = Route.find(root[:id]) > @route.via = root[:via] > Hi, just note, that you don't need set name to humanized string, I already do it, so just name parameter like if routes is not set, then you can set name to "routes" -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] user feedback for webyast
by Martin Vidner 21 Sep '09

21 Sep '09

(randy-sk in irc://irc.freenode.net/susecz) He installed it from YaST:Web, I helped him with https://bugzilla.novell.com/show_bug.cgi?id=538039#c4 - collectd is not working [he needed to start collectd] - I need to install termcap... did not help [he tried Users, did not work] Cannot find termcap: TERM not set at /usr/lib/perl5/5.10.0/Term/ReadLine.pm line 351 false Cannot find termcap: TERM not set at /usr/lib/perl5/5.10.0/Term/ReadLine.pm line 351 0 false 0 pali false pali 0 randy false randy 0 - it is mostly working. it is funny. it is only missing icons in the control panel [he means to launch webyast locally. I told him we don't want that] - pity that you can't install packages - getting the health status is slow. (I would understand patches being slow, but not this) - a log viewer would be useful [ ;-) ] -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-07
by Josef Reidinger 21 Sep '09

21 Sep '09

missing: duncan, daniel(public transport),mschidkunz (vacation) kkampf - moving things to bugzilla dmacvicar (reported by klaus) - log feature (highlight), vendor settings, review collectd (new version) schubi - working on package module mvidner - working on network ( provide available interfaces) mzugec - same as mvidner jsrain - no update jsuchome - no webyast related issues jreidinger - finishing basic system setup, start on setting time via ntp all - look at bugzilla and check if something is not clear -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

7 14

[yast-devel] Re: [yast-commit] <rest-service> master : more unit tests, exception handling
by josef reidinger 18 Sep '09

18 Sep '09

Jiri Suchomel napsal(a): > ref: refs/heads/master > commit 942d45274e1c9ca229bba8768436cced98d17e56 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Fri Sep 18 09:41:46 2009 +0200 > > more unit tests, exception handling > --- > .../app/controllers/administrator_controller.rb | 2 +- > plugins/administrator/app/models/administrator.rb | 4 +- > .../administrator/test/unit/administrator_test.rb | 27 +++++++++++++++++++- > 3 files changed, 29 insertions(+), 4 deletions(-) > > diff --git a/plugins/administrator/app/controllers/administrator_controller.rb b/plugins/administrator/app/controllers/administrator_controller.rb > index 5a06f0a..3478c45 100644 > --- a/plugins/administrator/app/controllers/administrator_controller.rb > +++ b/plugins/administrator/app/controllers/administrator_controller.rb > @@ -37,7 +37,7 @@ class AdministratorController < ApplicationController > begin > @admin.save_aliases(data[:aliases]) > rescue Exception => e > - render ErrorResult.error(500, 2, e.message) and return > + render ErrorResult.error(404, 2, e.message) and return Please don't return 404 when error occure, this is quite confusing. I write separate mail about error handling when I mention it. If you use my second suggestion you don't need catch anything unless you want somehow rescue from it (which render is not). > end > end > show > diff --git a/plugins/administrator/app/models/administrator.rb b/plugins/administrator/app/models/administrator.rb > index 2327ebe..7580965 100644 > --- a/plugins/administrator/app/models/administrator.rb > +++ b/plugins/administrator/app/models/administrator.rb > @@ -35,7 +35,7 @@ class Administrator > new_aliases = "" if new_aliases.nil? || new_aliases == "NONE" > if @aliases.split(",").sort == new_aliases.split(",").sort > Rails.logger.debug "mail aliases have not been changed" > - return > + return true > end > parameters = { > "aliases" => ["as", new_aliases.split(",")] > @@ -43,7 +43,7 @@ class Administrator > yapi_ret = YastService.Call("YaPI::ADMINISTRATOR::Write", parameters) > Rails.logger.debug "YaPI returns: '#{yapi_ret}'" > > - raise yapi_ret unless yapi_ret.empty? > + raise Exception.new(yapi_ret) unless yapi_ret.empty? Don't raise anonymous exception, please use error handling feature and define own exception with proper handling. for example see how I handle response from NTP: http://git.opensuse.org/?p=projects/yast/rest-service.git;a=blob;f=plugins/… > @aliases = new_aliases > end > > diff --git a/plugins/administrator/test/unit/administrator_test.rb b/plugins/administrator/test/unit/administrator_test.rb > index 008977d..374b1d2 100644 > --- a/plugins/administrator/test/unit/administrator_test.rb > +++ b/plugins/administrator/test/unit/administrator_test.rb > @@ -6,6 +6,8 @@ class AdministratorTest < ActiveSupport::TestCase > > def setup > @model = Administrator.instance > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > + @model.read_aliases > end > > def test_save_password > @@ -15,7 +17,7 @@ class AdministratorTest < ActiveSupport::TestCase > end > > def test_read_aliases > - YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a(a)b.c" ] }) > ret = @model.read_aliases > assert ret > assert @model.aliases.split(",").size == 1 > @@ -29,4 +31,27 @@ class AdministratorTest < ActiveSupport::TestCase > assert @model.aliases.split(",").size == 2 > end > > + def test_save_empty_aliases > + new_aliases = "NONE" > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"aliases" => [ "as", [] ]}).returns("") > + ret = @model.save_aliases(new_aliases) > + assert ret > + assert @model.aliases.empty? > + end > + > + def test_save_failure > + new_aliases = [ "test(a)domain.com" ]; > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"aliases" => [ "as", new_aliases ]}).returns("YaPI error") > + assert_raise Exception do > + ret = @model.save_aliases(new_aliases.join(",")) > + end > + end > + > + def test_save_no_change > + new_aliases = [ "a@b" ]; > + ret = @model.save_aliases(new_aliases.join(",")) > + assert ret > + assert @model.aliases.split(",").size == 1 > + end > + > end -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] reverting the Yast icon in 11.2
by Jakub Steiner 18 Sep '09

18 Sep '09

Hi folks, I'd like to propose to revert the Yast launcher icon to the original wrench for usability reasons. This would be the first time we'd expose people to a cute little animal as an icon. Of course it's a chicken and egg problem setting up a brand. There are a few cases where building a brand for a product has preference over a clear metaphor giving insight on what the tool does. But I don't think it's the case with Yast. Yasti, the aardvark is a great mascot, perfect for conference swag. Exposing him everywhere it mentions Yast is a bad choice in my opinion. I don't think we aim for people on Fedora or Ubuntu to switch their configuration tools to YaST. We want people to switch to openSUSE. Our brand focus should be on openSUSE. I think it's best to revert back to the wrench for the icon. cheers -- Jakub Steiner <jimmac(a)gmail.com> http://jimmac.musichall.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] rest-service ResourcesController should be more RESTful
by Martin Kudlvasr 17 Sep '09

17 Sep '09

Hi, see http://bugzilla.novell.com/show_bug.cgi?id=539290 for introduction. Basically, we currently discover resources from interface using path like: /resources.xml?interface=org.opensuse.yast.modules.yapi.network this is not restful, so service_resource.rb circumvents this by always using "proxy.find :all" and then searching for the resource in the list (/resources.xml works well). Simply because "proxy.find 'org.opensuse.yast.modules.yapi.network'" does not work ("proxy" is a proxy for /resources). Goal: Make it work! Currently finding a single resource is not used, so we have a bit of freedom, when figuring that out. There are 2 problems: 1) /resources/org.opensuse.yast.modules.yapi.network is a problematic path, because "." is a format separator (for .xml, .json, ...). proposed solution: use dashes instead of dots in the URI. /resources/org-opensuse-yast-modules-yapi-network.xml We can say, that dashes cannot be part of interface name (thanks to mvidner for http://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol- names). The interface name has to be transliterated, but this happens only once on server and once on client. 2) there can be more resources found for a single interface name. In current implementation, ResourcesController returns this for /resources.xml: <resources> <resource> <interface> ... </resource> ... </resources> and the same format for /resources.xml?interface=org.opensuse.yast.modules.yapi.network . Returning a list of items, where (according to ActiveResource) a single item is expected. ActiveResource has a problem with that. **imho optimal solution:** remake the xml format, so that single resource can contain several implementations (the same way it is in internal structures of rest- service/webservice/lib/resource_registration.rb). The format for /resources.xml can then look like this: <resources> <resource> <implementations> <implementation> <interface> ... </implementation> </implementations> </resource> ... </resources> with the same (but only single <resource>) for /resources/$interface_name.xml . By remaking the xml, service_resource.rb would have to be changed. I tried that and did not succeed. **proposed solution:** Make server return only single implementation/resource, when asked for a single interface. This would preserve current format of /resources.xml and work with ActiveResource mechanisms at the same time. The only thing that changes is, that server decides which implementation of resource is used by the client. Until now, this was decided in web-client by the rule "take first" (service_resource.rb:315). Both proposed solutions are implemented in resource-restful branch and pushed to git.opensuse.org. Please comment, if this can be merged, and say why, if not. Martin Kudlvasr -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status 02-Sep-2009
by J. Daniel Schmidt 17 Sep '09

17 Sep '09

WebYaST 02-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mschmidkunz, jdsn, mzugec, mvidner, jsuchomel absent: jsrain, visnov, lslezak, fnadge Status: ----------- kkaempf: no progress due to a day off dmacvicar: error handling, see wiki page for details (and eMail on ML) http://en.opensuse.org/YaST/Web/Development/Error_Handling schubi: find a way for the customer to change setup (like theming paths) mschmidkunz: extended the styleguide (message boxes) jdsn: investigation for the registration module underlying perl module might be problematic to integrate in REST context mzugec: no progress due to L3 work plan to read system data via YaPI for network plugin mvidner: several fixes for tests (in own branch) not yet commited due to pending bugs jsuchomel: plan to do customizations for custom services plugin Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST build still failing
by Klaus Kaempf 17 Sep '09

17 Sep '09

Hi, building WebYaST on Hudson is failing since yesterday afternoon. Currently its a packaging bug in yast2-webclient-administrator. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Installation server, tftp and netinstall
by Birger Kollstrand 16 Sep '09

16 Sep '09

Hi, I'm wondering if there is a possibility to do some adaptations to the "Installation server" module in 11.2? I would very much like to see that when I start the Installation Server module the first time that it asks for installtion of the tftp module. For a netinstall system the two are linked together. I use this kind of setup now when I'm testing openSUSE and its realy nifty to be able to select between a number of releases and being able to have it running in a few minutes by netinstalling with the relevant release. The next step would be to enhance the Instalation server module to: - edit the pxelinux.cfg/default config file with the new version to make available. below is a copy of my current netinstall config. DEFAULT pxelinux.cfg/vesamenu.c32 #DEFAULT OS11.1_32 PROMPT 0 MENU TITLE Birger's boot palace MENU BACKGROUND pxelinux.cfg/background.jpg #TIMEOUT 300 # Install i386 Linux LABEL OS11.1_32 kernel OS11.1_32/linux append initrd=OS11.1_32/initrd splash=silent vga=0x317 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ # Sub menu for x86_64 linux with different VGA modes MENU BEGIN OS11.1_64_sub LABEL OS11.1_64_0x317 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x317 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x318 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x318 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x323_Elitebook 6930p kernel OS11.1_64/linux append initrd=OS11.1_64/initrd acpi=off pnpbios=off splash=silent vga=0x323 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x31B_1280x1024 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent splash=silent vga=0x31B showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x346 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ MENU END # Sub menu for x86_64 linux with different autoyast files MENU BEGIN OS11.1_64_autoyast LABEL OS11.1_64_homeserv kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x346 autoyast=ftp://10.0.0.192/distros/autoyast/homeserv_22_12_08.xml showopts install=ftp://10.0.0.192/distros/OS11.1_64/CD1/ LABEL OS11.1_64_0x318 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x318 showopts install=ftp://10.0.0.192/distros/OS11.1_64/CD1/ LABEL OS11.1_64_0x346 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.192/distros/OS11.1_64/CD1/ MENU END # Sub menu for 11.2 MENU BEGIN OS11.2 LABEL OS11.2MS5_32 kernel OS11.2MS5_32/linux append initrd=OS11.2MS5_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_32/CD1/ LABEL OS11.2MS5_64_0x346 kernel OS11.2MS5_64/linux append initrd=OS11.2MS5_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_64/CD1/ LABEL OS11.2MS5_32 kernel OS11.2MS5_32/linux append initrd=OS11.2MS5_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_32/CD1/ LABEL OS11.2MS5_64_0x346 kernel OS11.2MS5_64/linux append initrd=OS11.2MS5_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_64/CD1/ LABEL OS11.2MS6_32 kernel OS11.2MS6_32/linux append initrd=OS11.2MS6_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS6_32/CD1/ LABEL OS11.2MS6_64 kernel OS11.2MS6_64/linux append initrd=OS11.2MS6_64/initrd splash=silent splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS6_64/CD1/ LABEL OS11.2MS7_32 kernel OS11.2MS7_32/linux append initrd=OS11.2MS7_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2Build0268_32/CD1/ MENU END - and copy the initrd and linux file from the new image to the tftpserver directory. this looks like this on one of my servers now: linserve2:/srv/tftpboot # ls OS11.1_32 OS11.2MS5_32 OS11.2MS6_32 OS11.2MS7_32 pxelinux.cfg OS11.1_64 OS11.2MS5_64 OS11.2MS6_64 pxelinux.0 vesamenu.c32 :-) Much to ask for, but it would be lovely! It is really neat when I do installs on 5 computers at a time and with different version. cu / birger.... -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: how to pass empty string to rest-service?
by Jiří Suchomel 16 Sep '09

16 Sep '09

Hi, in administrator module I have a POST request from client that contains the information about root password and mail aliases. Sometimes I would like to pass an empty value (for mail aliases, to reset it to no alias) and to distinguish the empty value from nil (nil has a meaning do not try to save this, while empty means save empty). So, for example I have this object in webclient controller: @administrator.password = nil @administrator.aliases = "" and I'm calling POST with @administrator.save However, on the server part, I get this as parameters: {"format"=>"xml", "action"=>"create", "administrator"=>{"aliases"=>nil, "password"=>nil}, "controller"=>"administrator"} So both values are set to nil. When debugging, we saw that the RAW_POST_DATA has a value "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<administrator>\n <aliases></aliases>\n <password nil=\"true\"></password>\n</administrator>\n" which is converted by from_xml this way even if aliases tag looks differently from password tag: Hash.from_xml("<?xml?>\n<administrator>\n <aliases></aliases>\n <password nil=\"true\"></password>\n</administrator>\n") {"administrator"=>{"aliases"=>nil, "password"=>nil}} It would work if the request would contain <aliases type='string'></aliases> instead of <aliases></aliases>, however I don't know how to achieve this; using xml.aliases aliases, {:type => "string"} in models/administrator.rb's to_xml doesn't seem to help. Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 5

[yast-devel] WebYaST status, 2009-09-14
by Jiri Srain 16 Sep '09

16 Sep '09

present: kkaempf, dmacvicar, jdsn, schubi, mschmidkunz, mvidner, mzugec, jsrain kkaempf: - looking into patch model dmacvicar: - log module - refactoring the status controller, to be merged jdsn: - working on registration, YaPI interface - first working version ETA today (general registration working) schubi: - patch installation - should be able to install patch today or tomorrow mschmidkunz: - getting glimpse on what happened during FTO mvidner: - REST documentation of network WIP - will submit RPMs mzugec: - small progress in network - can configure default route + hostname, DNS in progress - interface setting - hopefully today jsuchome (via jsrain): - admin module basically working - TBD: testcases, docu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 1

[yast-devel] Re: [yast-commit] <rest-service> network : Added a note to s/404/422/ in test_update_noparams.
by Josef Reidinger 15 Sep '09

15 Sep '09

Martin Vidner wrote: > ref: refs/heads/network > commit 95f714b375f3dadfb35060427a0280c8a9f04bc6 > Author: Martin Vidner <mvidner(a)suse.cz> > Date: Tue Sep 15 13:13:48 2009 +0200 > > Added a note to s/404/422/ in test_update_noparams. > --- > webservice/test/plugin_basic_tests.rb | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/webservice/test/plugin_basic_tests.rb b/webservice/test/plugin_basic_tests.rb > index f77ffb7..11907cd 100644 > --- a/webservice/test/plugin_basic_tests.rb > +++ b/webservice/test/plugin_basic_tests.rb > @@ -66,6 +66,8 @@ module PluginBasicTests > def test_update_noparams > @model_class.stubs(:save) > put :update > + # FIXME: it is not 404, but 422 unprocessable entity, > + # see "Validation errors" in http://api.rubyonrails.org/classes/ActiveResource/Base.html > assert_response :missing > end > Hi, I think that this is one of thinks when we should use our new error reporting in backend. So I prefer throwing exception where is defined what parameter is invalid or missing (due to rest service should be used without webclient). I prefer solution with exception because it provide better description of problem and also it is easier to handle in frontend. Any reason why not use exceptions? Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] style guide add-on: module titles
by Martin Schmidkunz 15 Sep '09

15 Sep '09

Hi everybody, because of the recent version of webYaST it was necessary to add some lines about module titles into the style guide (http:// en.opensuse.org/YaST/Web/Docu/Style_Guide) Again: this is all to increase consistency and therefore the usability of webYaST. So, when you create a module title, please keep the following in mind: * Use title style for the module title. * Keep the title short and meaningful. * The module title is consistent with the module title in „Show All“ or "Home" page. * Do not use "Configure" or any other verb in the title. * If the module is used to configure a client, use the word "Client" in the title. * If the module is used to configure a server, use the word "Server" in the title. Thanks and have a nice week! Martin -- Crossmedialer Kontakt via: Martin Schmidkunz Forchheimer Str. 3 90542 Eckental Tel.: +499126/2090189 Mobil: +49176/80127858 ICQ: 457001671/Schmidi1803 --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] Power Outage
by ml-admin＠opensuse.org 11 Sep '09

11 Sep '09

Broadcast message from ml-admin(a)opensuse.org (/dev/pts/0) at 07:30 GMT ... The system is going down for halt NOW! -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYast: Documenting REST API - findings
by Ladislav Slezak 10 Sep '09

10 Sep '09

Hi all, Currently we don't have any standard or guidelines how to document Yast REST API. Duncan sent me two links: Rapidoc ------- (http://code.google.com/p/rapidoc/) It generates on-line documentation (controller and view) which is part of the application. The API is documented in the code (inline). Unfortunately it needs quite a lot of changes (where to search for input files, where stote generated files) and the templates need to be modified for our needs. This seems be not a trivial task... Anyway, I like the fact that the documentation is provided by the REST server itself - the documentation is automatically available (no need to install extra packages or search the web) and there is no problem with versions, the documentation will (or should) always match the current API on the server. Vasco ----- (http://blog.thinkrelevance.com/2008/10/22/introducing-vasco-a-route-explore…) Actually this is not a documentation generator, but it provides a nice GUI to REST API (see the link). This would be a good tool for testing during development - you should be able to browse the available methods and even test them without need to code a frontend first. Unfortunately it didn't work for me, the page was empty telling me to run a rake task to collect the data even though it had been already called and the data file was present... I'd like to discuss the REST documentation problem with Karel tomorrow, maybe he knows better tools... BTW I found that twitter documentation might be a good example how a REST API documentation could look like and what it should contain. (See e.g. http://apiwiki.twitter.com/Twitter-Search-API-Method%3A-search) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 7

[yast-devel] Documenting REST API using restility
by Ladislav Slezak 10 Sep '09

10 Sep '09

Hi all, I have integrated restility to WebYaST - restility is now available as a ruby gem (rubygem-restility) and there is a new rake task 'restdoc' which is called from 'package' task (the REST documentation is automatically generated during package build). If you want to check how it looks like then - install restility gem from YaST:Web repository [ well, the build has not been finished completely yet, e.g. FACTORY package still waits in the queue... :-( ] - update to the latest rest service from GIT - call 'rake restdoc' in plugins/system - restart the rest service (because of the new public/ overlay) - and finally point your browser to http://localhost:8080/system/restdoc/index.html You can look at plugins/system/restdoc/api.txt to see the source. (I'm going to write a wiki page how to create a REST documentation...) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] Re: [yast-commit] Build failed in Hudson: webyast-service-11.1-i586 #296
by Klaus Kaempf 10 Sep '09

10 Sep '09

* Hudson Integration Service <hudson(a)suse.de> [Sep 10. 2009 16:53]: > error: Failed build dependencies: > rubygem-restility is needed by yast2-webservice-0.0.3-0.noarch Can we postpone requiring rubygem-restility until after the power-down ? Else I guess the build will fail until next week. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Howto prepare your module for base system settings
by Josef Reidinger 10 Sep '09

10 Sep '09

Hi, if your module should be used in base system sequence it needs little change. I describe it in wiki http://en.opensuse.org/YaST/Web/Development/Client It is just two lines changes that allows correct redirect and use different labels for form submit buttons. If you have any question I welcome it. jsuchome - administration should be used in basic system settings so please read it and add it to code, thanks. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : call the real YaPI, update tests
by Josef Reidinger 10 Sep '09

10 Sep '09

Jiri Suchomel wrote: > ref: refs/heads/master > commit 61f65df178461f324728e5de041e91936a62d2b3 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Thu Sep 10 16:07:16 2009 +0200 > > call the real YaPI, update tests > --- > .../app/controllers/administrator_controller.rb | 9 ++++++++- > plugins/administrator/app/models/administrator.rb | 20 ++++++++++++++++---- > .../administrator/test/unit/administrator_test.rb | 19 ++++++++++--------- > 3 files changed, 34 insertions(+), 14 deletions(-) > > diff --git a/plugins/administrator/app/controllers/administrator_controller.rb b/plugins/administrator/app/controllers/administrator_controller.rb > index 2542c4c..60b90e0 100644 > --- a/plugins/administrator/app/controllers/administrator_controller.rb > +++ b/plugins/administrator/app/controllers/administrator_controller.rb > @@ -4,7 +4,10 @@ class AdministratorController < ApplicationController > > # GET action > def show > -# @aliases = Administrator.instance.aliases > + unless permission_check("org.opensuse.yast.modules.yapi.administrator.read") > + render ErrorResult.error(403, 1, "no permission for reading") and return > + end > + Hi, new error reporting uses exceptions os for check if permission is set use just permission_check("org.opensuse.yast.modules.yapi.administrator.read") and because I create for yapi shortcut you can use just yapi_perm_check "administrator.read" > @admin = Administrator.instance > @aliases = @admin.read_aliases > > @@ -17,6 +20,10 @@ class AdministratorController < ApplicationController > > # PUT action > def update > + > + unless permission_check("org.opensuse.yast.modules.yapi.administrator.write") > + render ErrorResult.error(403, 1, "no permission for writing") and return > + end > > @admin = Administrator.instance > > diff --git a/plugins/administrator/app/models/administrator.rb b/plugins/administrator/app/models/administrator.rb > index c51bbf5..87186fd 100644 > --- a/plugins/administrator/app/models/administrator.rb > +++ b/plugins/administrator/app/models/administrator.rb > @@ -22,13 +22,25 @@ class Administrator > end > > def save_password(pw) > - Rails.logger.debug "--------------------- saving password #{pw}--------" > + parameters = { > + "password" => ["s", pw ] > + } > + yapi_ret = YastService.Call("YaPI::ADMINISTRATOR::Write", parameters) > + Rails.logger.debug "YaPI returns: '#{yapi_ret}'" > end > > def save_aliases(new_aliases) > - # TODO compare new_aliases with aliases > - Rails.logger.debug "--------------------- current aliases #{aliases.inspect}" > - Rails.logger.debug "--------------------- saving aliases #{new_aliases.inspect}" > + if @aliases.sort == new_aliases > + Rails.logger.debug "mail aliases have not been changed" > + return > + end > + parameters = { > + "aliases" => ["as", new_aliases] > + } > + yapi_ret = YastService.Call("YaPI::ADMINISTRATOR::Write", parameters) > + Rails.logger.debug "YaPI returns: '#{yapi_ret}'" > + > + raise yapi_ret unless yapi_ret.empty? > @aliases = new_aliases > end > > diff --git a/plugins/administrator/test/unit/administrator_test.rb b/plugins/administrator/test/unit/administrator_test.rb > index bff12ab..1e8ef08 100644 > --- a/plugins/administrator/test/unit/administrator_test.rb > +++ b/plugins/administrator/test/unit/administrator_test.rb > @@ -9,21 +9,22 @@ class AdministratorTest < ActiveSupport::TestCase > end > > def test_save_password > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"password" => ["s", "new password"]}).returns("") > ret = @model.save_password("new password") > assert ret > end > > -# def test_read_aliases > -# assert @model.aliases.size == 0 > -# YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > -# ret = @model.read_aliases > -# assert ret > -# assert @model.aliases.size == 1 > -# end > + def test_read_aliases > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > + ret = @model.read_aliases > + assert ret > + assert @model.aliases.size == 1 > + end > > def test_save_aliases > - assert @model.aliases.size == 0 > - ret = @model.save_aliases([ "test(a)domain.com", "a@b" ]) > + new_aliases = [ "test(a)domain.com", "a@b" ]; > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"aliases" => [ "as", new_aliases ]}).returns("") > + ret = @model.save_aliases(new_aliases) > assert ret > assert @model.aliases.size == 2 > end -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] SLE-11 SP1 development, which svn branch?
by Ralf Haferkamp 10 Sep '09

10 Sep '09

Hi, will there be a special development branch in svn for SP1 features? If not, which branch should SP1 features go to? -- regards, Ralf -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Webyast - base system module and error reporting
by Josef Reidinger 10 Sep '09

10 Sep '09

Hi, I merge basesystem branch to master. So after you login to your machine ,if you don't install it from rpm,you find another new cool feature - backend error reporting. It says that some file missing for basesystem settings. So just install file from package to location which error hint you ;) Welcome any bug reports on base system settings or backend error reporting. ( I plan write to wiki what you must do in your module to allow it in basesystem settings) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-10
by Josef Reidinger 10 Sep '09

10 Sep '09

kkampf: - cleaning Patch module and continue with it - study rails constant for ENV versus env variable - continue with reviewing commited code dmacvicar: - vendor settings in log, will merge code to master mzugec: - network send data from frontend to backend to write and find problem with ruby dbus - will work on dbus write mvidner: - add tests yesterday fix - inspecting mzugec ruby dbus bug - start discussion on mailing list about change for ActiveResource in lslezak: - document debug rest service via curl - document restibility of plugin and generate output to public jsuchome: - commit rest api for administrator setting, simple webclient for it jsrain: no update jreidinger: - try merge basesystem branch to master - add reporting of backend problems to frontend jdns: - try solve registering repositories and services in backend -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] RFC logs API, settings
by Duncan Mac-Vicar Prett 10 Sep '09

10 Sep '09

Right now there is a resource /logs which support only index (in all formats) and show (only in txt format) <logs type="array"> <log> <id>system</id> <path>/var/log/messages</path> <description>System messages</description> </log> <log> <id>apache</id> <path>/var/log/apache2/access_log</path> <description>Apache</description> </log> </logs> The other supported API is /logs/id?lines=x which only answers in .txt format. I experimented with two ways to define those logs, you can't pass an arbitrary filename to the API because that would be a security hole, but you can define them in vendor config files. Here are the two approaches. 1) in /etc/YaST2/vendor.yml together with other vendor settings: bug_url: http://www.bugs.com packages: - mydb-server - mydb-console log_files: - /var/log/messages - /var/log/apache2/access_log And then you get them as /logs/0, logs/1 However, this has the drawback that you dont know anything else from the log to display it in the user interface. Then a second approach, cat /etc/YaST2/vendor/logs.yml system: path: /var/log/messages description: System messages apache: description: Apache path: /var/log/apache2/access_log Then the client can display more information about them. Which approach seems better? simplicity vs usefulness? -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Ruby-Perl binding
by J. Daniel Schmidt 09 Sep '09

09 Sep '09

Hi Hackers, In case somebody needs to evaluate Perl code from Ruby you can get the package "ruby-perl" from: https://build.opensuse.org/package/show?package=ruby- perl&project=home%3Ajdsn%3Atesting I only did some small tests with it (but now went for a different solution of my problem). Please report if there are any issues with the package. Don't know yet if I submit it to factory as it is not maintained. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Using curl for sending REST API requests
by Ladislav Slezak 09 Sep '09

09 Sep '09

Hi all, While documenting a REST API I realized that I'd like to test the XML examples which I have created. I have added a new section on the Tips wiki page [1] describing how to use curl for this task. The page describes how to authenticate to the REST API, how to send PUT/POST requests and how to send a XML input file. Enjoy! [1] http://en.opensuse.org/YaST/Web/Development/Tips#Using_curl_for_sending_RES… -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST: Registration RFC
by J. Daniel Schmidt 09 Sep '09

09 Sep '09

Hi, The last days I did some research about how to implement the registration in WebYaST. And the more I found out about the stuff the more complicated everthing got. I want to give a short summary and ask for your comments here. The registration itself is realised in a Perl module. There are currently two wrappers that do the workflow for this module. The first is a command line tool called "suse_register" and the second is the YaST module "inst_suse_register" which represents the GUI pendant. My first idea was to use the Perl module directly from Ruby. After a lot failures it finally works with the bindings from: http://www.yoshidam.net/Ruby.html#perl I will prepare a package of these in the BS in case somebody needs to evaluate Perl code from Ruby. When I realised that the rest-service does not run as root (it did on my workstation) but registration must run as root it made the bindings worthless. So we have to go through the needle eye of a DBus-SCR-call and run a commandline script (as root) and parse its output. Well, as I only need to call a script I don't see the need to go over DBus here. What about configuring sudo for the webservice user? Or using a tiny setuid wrapper script? Security-wise this would make no difference, as we can do everything via SCR-calls as root anyway. It would just make things less complicated (1). Fortunately I can rely on the fact that the NCC registration server (and soon SLMS as well) offer server side caching, that means, I don't need to implement a client side statemachine (which is hard in REST context where each next call is the first one). One tricky part is the zypp lock. If somebody locked the package manager on the system and then somebody else tries to register, the zypper calls will fail. The YaST module tells the user about it as it initialises the package manager on startup. But how to this in REST contect? Just return an error like "The service you are calling is temporarily not available. Please call again later"? :) This gets less funny when it happens during a registration, as we can/should not keep a package management lock in a REST service and thus the lock might be taken in the meanwhile. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg (1) For me all this has too many layers already: Ok, lets skip the users browser that does HTTP(S) requests to the web-client which in turn does HTTP(S) requests to the rest-service. The rail rest-service then needs to do an SCR-DBus call which starts a DBus- Service and so does an Execute as root and runs a new script (the current suse_register is not sufficient for this) which is a new wrapper for the registration Perl module that talks to the NCC-server via HTTPS requests and parses their XML. The dumped result needs to get parsed again in the rest- service. In case there is information missing the user needs to get asked again. In case the registration is done there are (most likely) changes to be done to the package system (which might fail because of a zypp lock of a different user) that need to go there the SCR-DBus-way. Can we reduce the number of layers somehow? Or did I forget about some, that need to be added to make it more interesting? :) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 5

[yast-devel] Lazy package requirements of YaST modules
by Martin Vidner 09 Sep '09

09 Sep '09

Hi, yast2-nfs-server requires nfs-kernel-server, but it does not say so in .spec. Instead, it checks at run time and offers to install it then. Other modules are similar. Should we not list these packages as Recommends in .spec? IIRC the current practice was esablished before Recommends was available. ( https://bugzilla.novell.com/show_bug.cgi?id=535544 ) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] Re: [Bug 537200] [task] [fate 307141] Admin password and e-mail rest service
by Jiří Suchomel 08 Sep '09

08 Sep '09

On Tuesday 08 of September 2009 13:44:03 Bugzilla_NoReply Bugzilla_NoReply wrote: > http://bugzilla.novell.com/show_bug.cgi?id=537200 > > User kkaempf(a)novell.com added comment > http://bugzilla.novell.com/show_bug.cgi?id=537200#c3 > > > > > > --- Comment #3 from Klaus Kämpf <kkaempf(a)novell.com> 2009-09-08 05:44:01 > MDT --- (In reply to comment #2) > > > Lets discuss such things on yast-devel ! > > Move the final documentation into git, link it from the wiki, and put the > wiki url here. > > > Admin password module proposal (fate #307141) > > --------------------------------------------- > > > > Tasks: > > - change administrator (root's) password > > - configure notification e-mail addresses > > (mail aliases for root) > > - possibly more in the future > > > Model > > > > singleton class Administrator > > > > attributes > > string password > > list aliases > > Why would aliases be a list ? I understand the request as "single email > address" to send mails to. And, is 'alias' the right name for this ? I'm thinking about the implementation as an entry in /etc/aliases (we have MailAliases.ycp for that). And here it is possible to assign multiple aliases for one e-mail. > > methods > > (access the system, probably using YaPI::USERS) > > > > set_password > > set_aliases > > get_aliases > > You don't need set/get prefixes in Ruby. Ah, well, get_aliases is actually part of find method. set_password and set_aliases are meant as a methods that actually access the system (call YaPI or whatever), not that they just fill the variables. Or there can be one save method, handling both, but I thought more granularity can help testing. > > > Policies > > > > org.opensuse.yast.modules.yapi.users.administrator.read > > org.opensuse.yast.modules.yapi.users.administrator.write > > > > API > > > > URL: /administrator > > > > REST service pseudo-code: > > > > # GET method > > def show > > > > read and return current mail aliases > > > > # PUT method > > def update (params) > > > > if password changed > > > > save the new password > > > > if aliases changed > > > > save new list of aliases -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] ** [webyast] Reminder: set your tasks to 'assigned'
by Klaus Kaempf 08 Sep '09

08 Sep '09

WebYaST developers, this is a friendly reminder to set the tasks you're working on to 'assigned' in Bugzilla. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: Transition of tasks to Bugzilla complete
by Klaus Kaempf 07 Sep '09

07 Sep '09

Hi, the initial round of moving tasks from the Wiki to Bugzilla is now done. All tasks are for 'WebYaST'/'openSUSE 11.2' and start with '[task]' in the summary. The tasks are sized to be reasonably small, typically two to three days. Every WebYaST developer should have one or more tasks assigned to him via bugzilla. ** Please check that the task assignment matches your current ** work. Set the bug to 'assigned' if this hasn't been done before. All tasks must have a 'target date' set. Please set this field according to your own estimate. Thanks ! Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : more readable
by Josef Reidinger 07 Sep '09

07 Sep '09

On 09/07/2009 01:05 PM, Stefan Schubert wrote: > ref: refs/heads/master > commit 32be3734b62d83a68169620cf8ebaa8b5f4908e8 > Author: Stefan Schubert <schubi(a)suse.de> > Date: Mon Sep 7 13:05:09 2009 +0200 > > more readable > --- > .../app/controllers/patch_updates_controller.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/patch_updates/app/controllers/patch_updates_controller.rb b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > index 4747342..10daa3e 100644 > --- a/plugins/patch_updates/app/controllers/patch_updates_controller.rb > +++ b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > @@ -29,7 +29,7 @@ class PatchUpdatesController < ApplicationController > patches_summary = { :security => 0, :important => 0, :optional => 0} > > [:security, :important, :optional].each do |patch_type| > - patches_summary[patch_type] = patch_updates.collect { |p| p.kind == patch_type.to_s ? p : nil }.nitems > + patches_summary[patch_type] = patch_updates.find_all { |p| p.kind == patch_type.to_s }.size Hi, little note to efficiency. This code iterate through patch_updates three times, creates three array for which then get size. I think that better is iterate only once and add size to. So you can instead [:security, :important, :optional].each do |patch_type| patches_summary[patch_type] = patch_updates.find_all { |p| p.kind == patch_type.to_s }.size use (you already init it to zero in hash initializer) patch_updates.each { |pu| patches_summary[pu.kind.to_sym] += 1 } you get some result, efficienty and I think that it is has same readability. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Starting Rails application in debugger
by Ladislav Slezak 04 Sep '09

04 Sep '09

Miso needed to start a Rails application in debugger some time ago, using 'debugger' keyword doesn't help if you want to debug application loading. Now I have found the correct way - call the debugger directly: cd web-client/webclient rdebug script/server -- --debugger (the application parameters are passed after -- options) Enjoy! :-) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-04
by Klaus Kaempf 04 Sep '09

04 Sep '09

WebYaST 04-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mzugec, mvidner, jsrain, lslezak, bbrunner, jsuchome, visnov absent: fnadge, mschmidkunz Status: ----------- kkaempf: started to move todo list to bnc working on bnc#533178 (test environment set too late) dmacvicar: working system logs view, including 'live' ajax updates research on colorizing output eta 2009-sep-11 schubi: found easy way for vendor translations next: wiki documentation mzugec: network YaPI now reads real system data Next: improve test make 'index' function work mvidner: network module 'read only' done Next: improve test make 'index' function work jsrain: - lslezak: wrote test in services plugin next: document rest interface research on how others document such apis bbrunner: learning Next: set up KVM environment for testing virtual appliance jsuchome: created package next: service ui documentation visnov: - --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] TCP port for webyast?
by Martin Vidner 04 Sep '09

04 Sep '09

Hi, how long are we going to stay with 8080 and 3000? Wouldn't it be useful to decide before the next milestone? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] first draft of webyast style guide
by Martin Schmidkunz 03 Sep '09

03 Sep '09

Hi, please find a first draft of a webYaST style guide at: http:// en.opensuse.org/YaST/Web/Docu/Style_Guide Is there anything missing? Or is there anything you would like to discuss? Looking forward to your comments! Thanks, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] TraditionalYaST: searching YaST modules by keywords
by Katarina Machalkova 03 Sep '09

03 Sep '09

YaST hackers, I've just finished implementing ground for feature #305845 [1], that is support for defining additional keywords for YaST module and querying those (in addition to module names) in (Qt4) control centre search. However, to put the feature really into practice, I need your help. It is very simple: all you have to do is to modify .desktop file(s) your YaST module ships by adding a new key-value pair to it. The key name is 'X-SuSE-YaST- Keywords' (to conform to xdg standards [2]) and its value is comma-separated list of words describing the function of the module. Example: [Desktop Entry] Type=Application //those you already have Name=Flinstones GenericName=Modern Stone Age Family //this you will need to add X-SuSE-YaST-Keywords=fred,wilma,barney,betty I'm sure you know best which keywords to put in in order to make it easier for the users to find the module :) Thanks for the cooperation. hB. [1] https://features.opensuse.org/305845 [2] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry- spec-1.0.html -- \\\\\ Katarina Machalkova \\\\\\\__o YaST developer __\\\\\\\'/_ & hedgehog painter

2 2

[yast-devel] Re: [yast-commit] <rest-service> network : dns model shows xml list
by Josef Reidinger 03 Sep '09

03 Sep '09

On 09/03/2009 12:14 PM, Michal Zugec wrote: > ref: refs/heads/network > commit b72baab724ea256472be56efe577c9231df97881 > Author: Michal Zugec <mzugec(a)suse.cz> > Date: Thu Sep 3 12:14:49 2009 +0200 > > dns model shows xml list > --- > plugins/network/app/models/dns.rb | 14 +++++++++++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/plugins/network/app/models/dns.rb b/plugins/network/app/models/dns.rb > index 6a03736..f153a75 100644 > --- a/plugins/network/app/models/dns.rb > +++ b/plugins/network/app/models/dns.rb > @@ -42,9 +42,17 @@ class DNS > xml = options[:builder] ||= Builder::XmlMarkup.new(options) > xml.instruct! unless options[:skip_instruct] > > - xml.hostname do > - xml.domains @domains > - xml.servers @servers > + xml.dns do > + xml.domains({:type => "array"}) do > + domains.each do |@domains, val| > + xml.tag!(:domain, domains) > + end > + end > + xml.servers({:type => "array"}) do > + servers.each do |@servers, val| > + xml.tag!(:nameserver, servers) > + end > + end > end > end > Hi, I see it quite often in code and Karel on session say, that instead xml.tag!(:domain, domains) we should use simple xml.domain domains -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST status 03-Sep-2009
by J. Daniel Schmidt 03 Sep '09

03 Sep '09

WebYaST 03-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mschmidkunz, jdsn, mzugec, mvidner, jsuchomel, lslezak absent: jsrain, visnov, fnadge Status: ----------- kkaempf: work in fate dmacvicar: work on error handling plan to handle errors from proxy as well in flash section and pick next high prio. feature schubi: vendor theming done, documentation is in the wiki plan to do it for translations in a similar way mschmidkunz: discussed UI elements for error display plan to release first version of the WebYaST style guide jdsn: research for registration module succeeded to evaluate single lines of perl from ruby plan to do it as well with an entire perl module mzugec: extended REST API for DNS plan to implement YaPI interfaces mvidner: work on bugzilla bugs plan to implement the read only part of the network module jsuchomel: work on bugzilla bugs discussed custom services plan to pick next TODO from the list lslezak: work on error handling in the services module plan to pick next TODO from the list General decisions: - We will handle concrete TODO actions in bugzilla. (not the generic fate request itself, but single tasks/steps to fulfill one) Please hand unassigned bugs to Klaus. - If you look for a new feature to implement please pick one from the _top_ of the TODO file Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: Vendor service - Summary + TODO
by Ladislav Slezak 03 Sep '09

03 Sep '09

(Resending to yast-devel for a broader discussion....) Dne 21.8.2009 10:08, Jiří Suchomel napsal(a): > On Thursday 20 of August 2009 13:30:12 Ladislav Slezak wrote: >> The REST service >> ================ >> >> - provides a REST API for both LSB and custom services >> - uses YaPI for LSB services >> - custom services are handled directly, config files are read/parsed >> directly, SCR service is used for execution >> - uses new YaST::ConfigFile library >> >> >> Web UI (webclient) >> ================== >> >> - provides a separate view on LSB services and custom services >> - allows custom branding (via modifications in /public directory) > > TODO > > The REST service > ================ > - enhance testsuite > - add function to query service status (Q: use new policy for query, or use > the one for "execute"?) I'd reuse the existing right, no need for extra one IMHO. > Web UI (webclient) > ================== > - testsuite > - design the UI (talk to mschmidkunz), may be different for System vs. Custom > services The question is if vendors would like to change "Custom Services" to a better name (with real service name). With current implementation they need to change the name directly in .yml config file. Is that OK? > - show the service status: > - for system services, probably first show list of services, that update the > status of each one service with AJAX calls Maybe one AJAX call for all services could be better (I'm not sure about the overhead, running 30 requests in parallel instead of big one might be too slow.) Any idea? I'm not an AJAX expert... > - custom service is expected to be only one currently, so the status could > be load on loading index page I'd keep the same functionality, this creates unnecessary complexity. More over reading the current status might take long time so the complete page would be displayed after a (possibly long) delay. > - think how the service execution result should be shown better -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 4

[yast-devel] Error handling - rest service side
by Josef Reidinger 03 Sep '09

03 Sep '09

Hi, as you can see from commits I merge my error handling branch to master. So what changes: in short: errors in backend is reported via exceptions, all webservice exceptions should have one ancestor BackendException, so if you want add own exception please create it as child of this class uncatched BackendExceptions is reported as 503 and content is xml description of problem. BackendException must have unique enum identificator, english description if anyone read directly xml and to_xml method, that creates content of respond. I create 3 exceptions for permission check as example, so now permission_check method throws exceptions instead returning false and if you don't want return something special, don't catch it. For yapi based modules I create shortcut yapi_perm_check where you only specify last part of permission (e.g. "time.read") more in yast_roles documentation. Duncan - can we generate documentation on some public place to easier link it and be easier accesible? Welcome any comments and I suggest create own exceptions. I plan in near future addapt client side error reporting for this 503 response. Documented also on wiki http://en.opensuse.org/YaST/Web/Development/Error_Handling Welcome any comments and suggestions -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> basesystem : when module failed in control panel, the result was endless redirect loop
by Josef Reidinger 03 Sep '09

03 Sep '09

On 08/26/2009 06:58 PM, Martin Kudlvasr wrote: > ref: refs/heads/basesystem > commit ea5740fcf91f51284a51cb1bf9345823ddd57cee > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Wed Aug 26 18:58:19 2009 +0200 > > when module failed in control panel, the result was endless redirect loop > added another view to separate controlpanel from basesystem. > now user actually see the error > --- > .../app/controllers/controlpanel_controller.rb | 25 +++++++++++++------ > webclient/app/views/controlpanel/basesystem.rhtml | 4 +++ > 2 files changed, 21 insertions(+), 8 deletions(-) > > diff --git a/webclient/app/controllers/controlpanel_controller.rb b/webclient/app/controllers/controlpanel_controller.rb > index b9ba795..09d7494 100644 > --- a/webclient/app/controllers/controlpanel_controller.rb > +++ b/webclient/app/controllers/controlpanel_controller.rb > @@ -38,8 +38,6 @@ class ControlpanelController < ApplicationController > > > # Constant that signalizes, that all steps from base system setup are done > - # This constant and constant in rest-service -> basesystem.rb are not connected > - # and do not have to be the same value > FINAL_STEP = "FINISH" > # nextstep and backstep expect, that wizard session variables are set > def ensure_wizard > @@ -62,8 +60,9 @@ class ControlpanelController < ApplicationController > # basesystem.save will set always current to FINAL_STEP > basesystem.save > session[:wizard_current] = FINAL_STEP > + redirect_to "/controlpanel" > end > - redirect_to "/controlpanel" > + redirect_to get_redirect_hash(session[:wizard_current]) > end Hi, you cannot do what this change (I already fix it, so this is just note). You redirect_to /controlpanel if basesystem steps is done and then you again redirect to last wizard step, which broke system. You can look at my commit for correct behavior ( only one redirect per action!) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] automatic package submission should be working again
by Duncan Mac-Vicar P. 02 Sep '09

02 Sep '09

Lets see if YaST:Web builds by tomorrow ;-) Duncan -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] yast-commit mails delayed by almost a week ?!
by Klaus Kaempf 02 Sep '09

02 Sep '09

Hi, I'm wondering if others also get yast-commit mails delayed by almost a week. E.g. I received this morning a commit from last week Thursday. I just opened bnc#536189 to track this down. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] Re: [yast-commit] <web-client> master : status module: code cleanup. TODO: implement limit format with maximum and minimum
by josef reidinger 02 Sep '09

02 Sep '09

Bjoern Geuken napsal(a): > ref: refs/heads/master > commit 995bc764b3e72bdb385961a80e3ee861fd9edec4 > Author: Bjoern Geuken <bgeuken(a)suse.de> > Date: Wed Sep 2 10:45:36 2009 +0200 > > status module: code cleanup. TODO: implement limit format with maximum and minimum > --- > .../status/app/controllers/status_controller.rb | 100 +++++--------------- > 1 files changed, 24 insertions(+), 76 deletions(-) > > diff --git a/plugins/status/app/controllers/status_controller.rb b/plugins/status/app/controllers/status_controller.rb > index bd5d22c..d791323 100644 > --- a/plugins/status/app/controllers/status_controller.rb > +++ b/plugins/status/app/controllers/status_controller.rb > @@ -14,63 +14,35 @@ class StatusController < ApplicationController > @permissions = @client.permissions > end > > - def create_data_map( tree, label = "") > + def write_data_group(label, group, metric_name, limits=nil) > + data_list = Array.new > + divisor = (group == "memory")? 1024*1024 : 1 # take MByte for the value > + count = 0 > + data_list = label.map{ |v| count+=1; [count,v.to_f/divisor]} Hi, just few notes, here I don't understand what is label. You have default value for label empty string "", is it really intended? then this map take from String each character and convert it to float (so you get ascii value). From my point of view maybe label is array? > + @data_group[group].merge!({metric_name => data_list}) As I previously say, merge is if you want merge two hash, but in this case you want set one value in hash (it is more effective and less confusing) so you can use @data_group[group][metric_name] = data_list > + divisor = (group == "memory")? 1024*1024 : 1 # take MByte for the value you redefine divisor with same value, is it intended? (second line of this method) Moving shared function to separete method and use it to reduce code (DRY) is good job ;) Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Don't use sudo git...
by Björn Geuken 01 Sep '09

01 Sep '09

Hi, I accidently send a patch with Author: root <root(a)linux-qwou.(none)> by using sudo. I appologize for any confusion and would be happy if anyone could help fixing this. thanks Björn -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] web client, errors and user interface
by Duncan Mac-Vicar Prett 01 Sep '09

01 Sep '09

I have commited Error handling improved for the web client See http://en.opensuse.org/YaST/Web/Development/Error_Handling for more information. New features: - unhandled ajax errors are displayed in the standard flash messages facility, using standard jquery.ui styles, and nothing is rendered - provide helper report_error to put an exception into the flash message area, mean to be used for handled errors. This allows an ajax request to report the error but still render something. - normal handled errors can still be reported using standard Rails flash[] facility. - popup to examine backtrace and copy to clipboard facility As we put the errors in the flash zone, this follows http://en.opensuse.org/YaST/Web/Docu/Style_Guide#Messages What needs still to be done: - We use the standard jquery.ui style, there are some glitches like the flash messages end to close to the status block. The details popup needs to be resizable and may be bigger. - transparent integration with known service errors. Right now we handle normal catched errors and uncatched ones. However for problems like a permission problem, there is no need for every action to worry about them, but it is a too common problem for the general exception trap. So either needs to be handled in a common place, using the information that the service will give to the client, or handled also by the common trap, but having more specific information to show a more specific template and possible solutions. This could be achieved for example by making ServiceResource to throw a more concrete error in this case, and then making the rescue action to handle that (it could also recognize the normal ActiveResource permission denied exception). -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] concept of messages in webYaST
by Martin Schmidkunz 01 Sep '09

01 Sep '09

Hi, please find a first draft concerning the use of messages in webYaST at: http://en.opensuse.org/YaST/Web/Docu/Style_Guide#Messages The basic idea is to distinguish between questions and error messages: questions will be presented as pop ups and error messages within the dialog (between header and content) Furhtermore the idea is to simplify things for developers and users and to skip any destinction between error serverities: there will be just one way to display errors. This doesn`t make it necessary any more to gamble whether a possible error is a warning or a critial one. This is also a concept which was already introduced by Apple. Informative messages should be displayed in the place where the user has his focus (e.g. a loading icon in the row where the information is to be displayed and not on the top of the content because that would mean that the content is moved down everytime a simple loading process happens). Similar case is how to deal deal with questions: there a distinction between informative and warning type can be skippes as well because the user is interrupted in the workflow in any case and by reducing the amount of information in the question dialog, the user is supported to focus on the question text. What do you think about that concept? Cu, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] WebYaST: package versioning?
by Jiří Suchomel 01 Sep '09

01 Sep '09

Hi, I've just realized that most of traditional yast2 packages present in WebYaST repository have the versions of 2.18.*. But this is versioning based on trunk, should we have there the versions of patches SLE11 packages (2.17.<sles-11-released>++), instead of the trunk ones? That's not only about versioning, but also about the non-webyast related changes in these packages; I assume there should be no new stuff between SLE11 release and now, except the WebYaST related one... Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Re: [yast-commit] <rest-service> network : fixed test
by Klaus Kaempf 01 Sep '09

01 Sep '09

* Michal Zugec <mzugec(a)suse.cz> [Aug 31. 2009 13:13]: > @@ -13,8 +13,10 @@ class RoutesControllerTest < Test::Unit::TestCase > # to extract routes data from all YaPI map > # > def test_show > - Routes.expects(:find).returns({:routes=>{:default=>'10.20.30.40'}}) > - Routes.find > + # if this code raises, test-unit 2.0.3 and mocha 0.9.5 fail > + # with PASSTHROUGH_EXCEPTIONS. version mismatch?! > + Route.expects(:find).returns({:routes=>{:default=>{'via'=>'10.20.30.40'}}}) > + Route.find Can you explain what you're actually trying to test here ? Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <rest-service> master : status module: fixed evaluation of intervals for metrics
by Josef Reidinger 01 Sep '09

01 Sep '09

On 08/31/2009 12:49 PM, Bjoern Geuken wrote: > ref: refs/heads/master > commit 7fd7a8616e46b77b97d668b6782283864d32295b > Author: Bjoern Geuken <bgeuken(a)suse.de> > Date: Mon Aug 31 12:49:45 2009 +0200 > > status module: fixed evaluation of intervals for metrics > --- > plugins/status/lib/status.rb | 33 ++++++++++++------------------ > plugins/status/test/unit/status_test.rb | 3 +- > 2 files changed, 15 insertions(+), 21 deletions(-) > > diff --git a/plugins/status/lib/status.rb b/plugins/status/lib/status.rb > index 8628dde..58b7344 100644 > --- a/plugins/status/lib/status.rb > +++ b/plugins/status/lib/status.rb > @@ -9,9 +9,8 @@ class Status > :health_status, > :metrics, > :limits > -#=begin > + > def to_xml(options = {}) > -# puts @limits.inspect > xml = options[:builder] ||= Builder::XmlMarkup.new(options) > xml.instruct! unless options[:skip_instruct] > > @@ -20,7 +19,7 @@ class Status > data.each {|metric, data| > xml.metric(:name => metric, :metricgroup => metric_group) do > xml.starttime(@data[metric_group][metric]["starttime"]) > - xml.interval(5) > + xml.interval(@data[metric_group][metric]["interval"]) > data.each {|label,data| > unless label == "starttime" or label == "interval" > xml.label(:type => "hash", :name => label) do > @@ -201,43 +200,37 @@ class Status > end > unless labels.blank? > # set values for each label and time > + # evaluates interval and starttime once for each metric (not each label) > + nexttime = 9.9e+99 > + result["starttime"] = 9.9e+99 I suggest use some constant for this number because it is quite confusing (I think that it is some initial value, but maybe it is error indicator or some default. Constant give behavior to number and it is then easier to change it and test values on this value > lines.each do |l| # each time > unless l.blank? It is just my recomendation, but if you do big "if" statement in code and indent whole loop body, I think that if you just use next if l.blank? at begin of loop it increase readiness. (the best sulution is to write shorted functions or refactor it to separated parts - I recommend use reek or roodi to check your coding style) > if l =~ /\d*:\D*/ It looks like duplicite check, you check blank and then regex which is not blank, is really necessary to test blankness? and I miss at least some logging about bad input value. > pair = l.split ":" > values = pair[1].split " " > - #puts pair[1] > column = 0 > values.each do |v| # each label > - result["starttime"] ||= pair[0] > - result["starttime"] = pair[0] if pair[0].to_i < result["starttime"].to_i > - nexttime = > + if result["interval"].nil? > + if pair[0].to_i < result["starttime"].to_i > + result["starttime"] = pair[0].to_i > + elsif pair[0].to_i < nexttime and pair[0].to_i > result["starttime"].to_i > + nexttime = pair[0].to_i > + end > + end > > if v != "nan" #store valid values only > result["#{labels[column]}"] ||= Hash.new > -# result["#{labels[column]}"].merge!(v) > result["#{labels[column]}"].merge!({"#{pair[0].chomp(": ")}" => v}) I don't understand why you chomp there, as you have only digits in pair[0] ( regex ensure this ). Second really confusing code on this line is merge. It is really useless. if you use result["#{labels[column]}"][pair[0]] = v you get same result. Another think is that you reusing "#{labels[column]}". At first you can save it samewhere like label = "#{labels[column]}" At second I think that this string is really confusing, why you don't use just labels[column] ? and if it is not String, then add .to_s ? > - #result["#{labels[column]}"].merge!({"T_#{pair[0].chomp(": ")}" => v}) > column += 1 > else > result["#{labels[column]}"] ||= Hash.new > -# result["#{labels[column]}"].merge!("invalid") > result["#{labels[column]}"].merge!({"#{pair[0].chomp(": ")}" => "invalid"}) Same as above and you don't increase column, so if you get invalid value and then get valid value you with same pair[0] you overwrite invalid value. Is it intended to increase column only for valid data? It looks little confusing for me, as if status is invalid (cannot fetch data etcc) then I think it should show or hide this column, but next measure should be in next column not? > end > end > end > end > end > - #setting the limits > -# result.each do |key, value| > -# path = rrdfile[datapath.length+1..rrdfile.length-1].chomp('.rrd') > -# path +="/" + key if key!="value" #do not take care about the value flag > -# path = path.tr('-','_') > -# if @limits.has_key?(path) > -# result[key] ||= Hash.new > -# result[key].merge!({"limit" => @limits[path] }) > -# end > -# end > + result["interval"] = nexttime.to_i - result["starttime"].to_i if result["interval"].nil? testing for nil? is automatic so you can use result["interval"] = nexttime.to_i - result["starttime"].to_i unless result["interval"] If you have any question feel free to ask. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : patches module: fixed vendor package list. #TODO: read real yml file, add tests
by Josef Reidinger 01 Sep '09

01 Sep '09

On 08/31/2009 05:42 PM, Bjoern Geuken wrote: > ref: refs/heads/master > commit 576fcd2127a2d10f936f61800da6d37749fe4186 > Author: Bjoern Geuken <bgeuken(a)suse.de> > Date: Mon Aug 31 17:42:44 2009 +0200 > > patches module: fixed vendor package list. #TODO: read real yml file, add tests > --- > .../patches/app/controllers/packages_controller.rb | 30 ++++++++++--------- > plugins/patches/app/models/package.rb | 7 ---- > 2 files changed, 16 insertions(+), 21 deletions(-) > > diff --git a/plugins/patches/app/controllers/packages_controller.rb b/plugins/patches/app/controllers/packages_controller.rb > index e2b46ca..38d8bfd 100644 > --- a/plugins/patches/app/controllers/packages_controller.rb > +++ b/plugins/patches/app/controllers/packages_controller.rb > @@ -38,30 +38,32 @@ class PackagesController < ApplicationController > end > end > > - public > - > def compare_lists(packages) > - vendor_packages = Hash.new > - # yml datei auslesen: ["packages"] => ["yast-core", "ruby-dbus", ...] > - package_list = Array.new > - package_list << ["yast2-users", "3ddiag", "foo"] > + vendor_packages = Array.new > + #TODO: replace by real yml file > + package_list = ["3ddiag", "foo", "yast2-users", "yast2-network"] > > package_list.each {|pk_name| > - packages.each {|p| > + p = nil > + for i in 0..packages.size-1 > # package installed? > - if p.name == pk_name > - # store version and name > - vendor_packages["package"] = {:name => "#{p.name}", :version => "#{p.version}"} > + if pk_name == packages[i].name > + # store package > + p = packages[i] > + break Hi, As I say before this is unnecessary big code instead p = nil for i in 0..packages.size-1 if pk_name == packages[i].name # store package p = packages[i] break end end use this with same result p = packages.find { |pkg| pk_name == pkg.name } if you have question about code just ask ;) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0