Branch: refs/heads/network-ng Home: https://github.com/yast/yast-network Commit: 6d3508159b36b7837bc82c024b134c1f4d7f5414 https://github.com/yast/yast-network/commit/6d3508159b36b7837bc82c024b134c1f... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: A src/lib/y2network/interface_config_builder.rb Log Message: ----------- Initial implementation of an interface config builder Commit: a4ba577a16c2026a505188d4fe99ed22a7eec8ea https://github.com/yast/yast-network/commit/a4ba577a16c2026a505188d4fe99ed22... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/include/network/lan/complex.rb M src/include/network/lan/hardware.rb M src/include/network/lan/wizards.rb M src/lib/y2network/interface_config_builder.rb M src/modules/LanItems.rb Log Message: ----------- Use an interface config builder in Add interface workflow Cherry-picked from replace-items-rebased, modified to contain only builder updates Commit: b123045910236250930307a9f00b2c898118e60f https://github.com/yast/yast-network/commit/b123045910236250930307a9f00b2c89... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/include/network/lan/complex.rb M src/include/network/lan/wizards.rb M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Adapred Edit interface workflow to use config builder Extracted (and adapted) from replace-items-rebased Commit: ad889ab6a26120de2096efe41852fcbeba6cc5a7 https://github.com/yast/yast-network/commit/ad889ab6a26120de2096efe41852fcbe... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/lib/y2network/interface.rb M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Documentation Commit: 640df48145855a22fd5d24154ef90503bdd7ea18 https://github.com/yast/yast-network/commit/640df48145855a22fd5d24154ef90503... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/include/network/lan/complex.rb M src/include/network/lan/wizards.rb Log Message: ----------- Happy rubocop Commit: 046cf7e6344a14908e8b48916974d4c0accee5ce https://github.com/yast/yast-network/commit/046cf7e6344a14908e8b48916974d4c0... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/complex.rb M src/include/network/lan/wizards.rb M src/lib/y2network/interface_config_builder.rb A src/lib/y2network/interface_defaults.rb Log Message: ----------- Replaced old way of setting default dev map in Add interface workflow Commit: 6e8fbef1ea50646a0a4536a56bf7c762cb162a12 https://github.com/yast/yast-network/commit/6e8fbef1ea50646a0a4536a56bf7c762... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/include/network/lan/complex.rb M src/lib/y2network/interface_config_builder.rb M src/lib/y2network/interface_defaults.rb Log Message: ----------- Replaced old way of dev map loading in Edit interface workflow Cherry-picked (and adapted) from replace-items-rebased Commit: 6b5439d748763464c8bdfaa54ec953a193ee68fc https://github.com/yast/yast-network/commit/6b5439d748763464c8bdfaa54ec953a1... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb Log Message: ----------- Fixed initialization of some widgets in the address dialog Commit: 28af25d029aac09d265bc07c9f7f5c9d3ce7843c https://github.com/yast/yast-network/commit/28af25d029aac09d265bc07c9f7f5c9d... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb Log Message: ----------- Dropped ValidateIfcfgType It was a left over from times when user was allowed to explicitly set device type. However in present times the respective input field is always disabled and moreover user is not allowed to set device type explicitly. Commit: 67911db26b038976299fce6b62a052a781e2cfd7 https://github.com/yast/yast-network/commit/67911db26b038976299fce6b62a052a7... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Removed to LanItems.type from address dialog Commit: fc4020307ff8902b2ef5f0b12832d941ec77debc https://github.com/yast/yast-network/commit/fc4020307ff8902b2ef5f0b12832d941... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/hardware.rb Log Message: ----------- Removed code handling hwcfg widget The widget itself was already removed in 594bbd3a1647c291d6f4db07fa4304e00b9d87d1 (removed support for hwcfg files) Commit: 5182cd72af916a08b87f66ad0855c894a17c5e42 https://github.com/yast/yast-network/commit/5182cd72af916a08b87f66ad0855c894... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/hardware.rb Log Message: ----------- Dropped dead code related to hardwares :list button This button was removed around 27af443af345342c840640cfb2177450f7db0f8b Commit: 278e89020058ab9fcad953af6eac67edec0a8e06 https://github.com/yast/yast-network/commit/278e89020058ab9fcad953af6eac67ed... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/hardware.rb M src/include/network/lan/wizards.rb Log Message: ----------- Removed access to LanItems.type from HardwareDialog Cherry-picked (and adapted) from replace-items-rebased Commit: 05b07718298eab3c221af1e5ea2618fdaf71cc29 https://github.com/yast/yast-network/commit/05b07718298eab3c221af1e5ea2618fd... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: R src/lib/y2network/hwinfo.rb M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Introduced options filtering in interface config builder Commit: 4a1b051f727631ef3d062b8d7275a0a17be1f792 https://github.com/yast/yast-network/commit/4a1b051f727631ef3d062b8d7275a0a1... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/lib/y2network/interface_defaults.rb Log Message: ----------- Minor tweaks based on CR + something for rubocop Cherry-picked (and adapted) from replace-items-rebased Commit: ca212ec959d68b2d508fbdb04dfaafab1a685f60 https://github.com/yast/yast-network/commit/ca212ec959d68b2d508fbdb04dfaafab... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/data/network/sysconfig_defaults.yml M src/include/network/lan/address.rb M src/lib/y2network/interface_config_builder.rb M src/modules/LanItems.rb Log Message: ----------- Fixes in writing non eth devices Cherry-picked (and adapted) from replace-items-rebased Commit: 715d79b30d45f0e699a8b8a21df4c06475d14300 https://github.com/yast/yast-network/commit/715d79b30d45f0e699a8b8a21df4c064... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb M src/modules/LanItems.rb Log Message: ----------- Dropped LanItems::SetDefaultsForHW Cherry-picked (and adapted) from replace-items-rebased Commit: 7219bb4ec1da6bda1e48ce5b7c7432d659a16d5e https://github.com/yast/yast-network/commit/7219bb4ec1da6bda1e48ce5b7c7432d6... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb M src/lib/y2network/interface_defaults.rb M src/modules/LanItems.rb Log Message: ----------- Moved devmap intialization from LanItems to interface builder Cherry-picked (and adapted) from replace-items-rebased Commit: 8552fe3aa038c1cb672a0fddf7544d8fce9abf62 https://github.com/yast/yast-network/commit/8552fe3aa038c1cb672a0fddf7544d8f... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/data/network/sysconfig_defaults.yml M src/lib/y2network/interface_config_builder.rb M test/new_device_startmode_test.rb M test/yaml_defaults_test.rb Log Message: ----------- Adapted testsuite Commit: b2a3db91b6fe6a4ced3a9f1c66dbef8c2e8497c9 https://github.com/yast/yast-network/commit/b2a3db91b6fe6a4ced3a9f1c66dbef8c... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/include/network/lan/address.rb M src/include/network/lan/complex.rb M src/include/network/lan/hardware.rb M src/include/network/lan/wizards.rb M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Made builder param mandatory Cherry-picked (and adapted) from replace-items-rebased Commit: 6a4e964ca7595f5aaad98fab52da120b5300a9d0 https://github.com/yast/yast-network/commit/6a4e964ca7595f5aaad98fab52da120b... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Minor fixes based on CR Commit: cf822d827071e3fcc3215cdd3e148038771286d1 https://github.com/yast/yast-network/commit/cf822d827071e3fcc3215cdd3e148038... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: M test/new_device_startmode_test.rb Log Message: ----------- Fixed testsuite Commit: 1f57a09b2c9cc265b24bbc4baff76ea6c30fdaac https://github.com/yast/yast-network/commit/1f57a09b2c9cc265b24bbc4baff76ea6... Author: Michal Filka Date: 2019-05-29 (Wed, 29 May 2019) Changed paths: A src/lib/y2network/hwinfo.rb Log Message: ----------- Added hwinfo from replace-items-rebased it is in shape as used in replace-items-rebased branch, so sligthly overkill for this branch Commit: eb030525119397999bf274b45fab1db4232ba4a3 https://github.com/yast/yast-network/commit/eb030525119397999bf274b45fab1db4... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/lib/network/network_autoconfiguration.rb Log Message: ----------- Adapted installer's dhcp autoconfiguration to use builder Commit: 158e8427072b7c37b03835b2fdff6fc05723f892 https://github.com/yast/yast-network/commit/158e8427072b7c37b03835b2fdff6fc0... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/modules/LanItems.rb Log Message: ----------- Refactored dhclient option autoconfiguration Access to a global variable was replaced by using actual device configuration Commit: bdedb1c899c5bb0fb1691d039f0b744027a035eb https://github.com/yast/yast-network/commit/bdedb1c899c5bb0fb1691d039f0b7440... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Modified InterfaceConfigBuilder to return nil on undefined options bcs empty string can have different meaning. Commit: f239665ce962fb63e07c310ffc704ab759c78604 https://github.com/yast/yast-network/commit/f239665ce962fb63e07c310ffc704ab7... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Removed default setup of DHCLIENT_SET_DEFAULT_ROUTE from builder It was incorrect, the option is according to a heuristic when writing the configuration. The default setup was copied incorrectly from original code where it worked bcs it was ignored / unconditionally overwritten. Commit: 8bc8850932abef63ffa6783194d7f8c20edea83f https://github.com/yast/yast-network/commit/8bc8850932abef63ffa6783194d7f8c2... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M test/default_route_test.rb Log Message: ----------- Adapted testsuite to work with builder Commit: b6c463fdb10b8238c1ca971eb5649ce0800423ca https://github.com/yast/yast-network/commit/b6c463fdb10b8238c1ca971eb5649ce0... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/include/network/lan/address.rb M src/include/network/lan/hardware.rb M src/include/network/lan/help.rb R src/include/network/lan/virtual.rb M src/include/network/lan/wireless.rb M src/include/network/lan/wizards.rb M src/include/network/routines.rb M src/include/network/widgets.rb A src/lib/y2network/dialogs/add_interface.rb A src/lib/y2network/widgets/additional_addresses.rb A src/lib/y2network/widgets/blink_button.rb M src/lib/y2network/widgets/boot_protocol.rb A src/lib/y2network/widgets/ethtools_options.rb A src/lib/y2network/widgets/interface_name.rb A src/lib/y2network/widgets/interface_type.rb A src/lib/y2network/widgets/ip_address.rb A src/lib/y2network/widgets/ipoib_mode.rb A src/lib/y2network/widgets/kernel_module.rb A src/lib/y2network/widgets/kernel_options.rb A src/lib/y2network/widgets/netmask.rb A src/lib/y2network/widgets/remote_ip.rb A src/lib/y2network/widgets/s390_button.rb A src/lib/y2network/widgets/udev_rules.rb A src/lib/y2network/widgets/vlan_id.rb A src/lib/y2network/widgets/vlan_interface.rb M src/modules/LanItems.rb R test/alias_dialog_test.rb R test/hardware_test.rb R test/widgets_test.rb M test/wireless_test.rb A test/y2network/widgets/additional_addresses_test.rb A test/y2network/widgets/blink_button_test.rb A test/y2network/widgets/ethtools_options_test.rb A test/y2network/widgets/interface_name_test.rb A test/y2network/widgets/ip_address_test.rb A test/y2network/widgets/ipoib_test.rb A test/y2network/widgets/kernel_module_test.rb A test/y2network/widgets/kernel_options_test.rb A test/y2network/widgets/netmask_test.rb A test/y2network/widgets/remote_ip_test.rb A test/y2network/widgets/s390_button_test.rb A test/y2network/widgets/udev_rules_test.rb Log Message: ----------- Merge remote-tracking branch 'upstream/network-ng' into iface_builder Commit: c3693bee9b1962a8d466f9f00283097c3e1772ca https://github.com/yast/yast-network/commit/c3693bee9b1962a8d466f9f00283097c... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/include/network/lan/address.rb M src/lib/y2network/dialogs/add_interface.rb M src/lib/y2network/interface_config_builder.rb M src/lib/y2network/widgets/interface_name.rb M src/modules/LanItems.rb M test/y2network/widgets/interface_name_test.rb Log Message: ----------- Integrating builder into new cwm widgets Commit: 152c8e8aa1256faf30a19ca55e2d2550c2b4e45e https://github.com/yast/yast-network/commit/152c8e8aa1256faf30a19ca55e2d2550... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/lib/y2network/config_writer/sysconfig.rb Log Message: ----------- Fixed InterfacesCollection handling in write handler Commit: 518333c6258c1c04e1ea5ebcdca68d94f469dc1a https://github.com/yast/yast-network/commit/518333c6258c1c04e1ea5ebcdca68d94... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb M src/modules/LanItems.rb Log Message: ----------- Export all values as string from interface config builder Bcs scr agent will silently ignore if the value is not string otherwise. Commit: 0ac58148d6468472fef8a812f0db3f562da5f521 https://github.com/yast/yast-network/commit/0ac58148d6468472fef8a812f0db3f56... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/include/network/lan/wizards.rb M src/lib/y2network/config_writer/sysconfig.rb M src/lib/y2network/interface_config_builder.rb M src/modules/LanItems.rb Log Message: ----------- Improved devmap proposal in config builder Commit: ab753062a1a0559eef72133dd8397fe046763bc4 https://github.com/yast/yast-network/commit/ab753062a1a0559eef72133dd8397fe0... Author: Michal Filka Date: 2019-05-30 (Thu, 30 May 2019) Changed paths: M src/include/network/lan/address.rb M src/lib/y2network/interface_config_builder.rb M src/lib/y2network/interface_defaults.rb M src/modules/LanItems.rb Log Message: ----------- Happy rubocop Commit: e7ce6aa0374eca5f3b8a3a2ce8078b98a2ac4907 https://github.com/yast/yast-network/commit/e7ce6aa0374eca5f3b8a3a2ce8078b98... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/lib/y2network/dialogs/add_interface.rb Log Message: ----------- Reverted LanItems::Rollback into AddInterface Commit: 87a77f5c77c8fe9bb13970cfb05c86231e21188a https://github.com/yast/yast-network/commit/87a77f5c77c8fe9bb13970cfb05c8623... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb R src/lib/y2network/interface_defaults.rb Log Message: ----------- Moved needed stuff from interface defaults to the builder Commit: b17f5366a6648c9723c5db8470a0f77a7c859e67 https://github.com/yast/yast-network/commit/b17f5366a6648c9723c5db8470a0f77a... Author: mchf Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Update src/lib/y2network/interface_config_builder.rb Co-Authored-By: Martin Vidner Commit: a068483fb0913cf1f45c2d9e9dae9b8f8e578c3a https://github.com/yast/yast-network/commit/a068483fb0913cf1f45c2d9e9dae9b8f... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Updated according to review Commit: 4568dbe1883f4a61146595d0ef1b9015e44b157c https://github.com/yast/yast-network/commit/4568dbe1883f4a61146595d0ef1b9015... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/lib/y2network/interface_config_builder.rb Log Message: ----------- Merge branch 'iface_builder' of github.com:mchf/yast-network into iface_builder Commit: d23798a81a44dcf1ce8a745472b64ea16c374b16 https://github.com/yast/yast-network/commit/d23798a81a44dcf1ce8a745472b64ea1... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/include/network/lan/address.rb M src/lib/network/network_autoconfiguration.rb M src/lib/y2network/interface_config_builder.rb M src/modules/LanItems.rb Log Message: ----------- Removed obsolete methods from the builder Commit: 7d76c10523f6400ec6aadb07f649086bf90bf0dd https://github.com/yast/yast-network/commit/7d76c10523f6400ec6aadb07f649086b... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/include/network/lan/address.rb M src/lib/y2network/interface.rb Log Message: ----------- Fixed doc, typos and rubocop Commit: d953f5097e0995cbed8edb9d5b733a3667e1b998 https://github.com/yast/yast-network/commit/d953f5097e0995cbed8edb9d5b733a36... Author: Michal Filka Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/lib/y2network/hwinfo.rb Log Message: ----------- Documentation Commit: 5fba0f4ae560caa19fd04249149d5c4da8571454 https://github.com/yast/yast-network/commit/5fba0f4ae560caa19fd04249149d5c4d... Author: mchf Date: 2019-05-31 (Fri, 31 May 2019) Changed paths: M src/data/network/sysconfig_defaults.yml M src/include/network/lan/address.rb M src/include/network/lan/complex.rb M src/include/network/lan/hardware.rb M src/include/network/lan/wizards.rb M src/lib/network/network_autoconfiguration.rb M src/lib/y2network/config_writer/sysconfig.rb M src/lib/y2network/dialogs/add_interface.rb M src/lib/y2network/hwinfo.rb A src/lib/y2network/interface_config_builder.rb M src/lib/y2network/widgets/interface_name.rb M src/modules/LanItems.rb M test/default_route_test.rb M test/new_device_startmode_test.rb M test/y2network/widgets/interface_name_test.rb M test/yaml_defaults_test.rb Log Message: ----------- Merge pull request #816 from mchf/iface_builder Extracted and adapted interface builder Compare: https://github.com/yast/yast-network/compare/f90966c4ace2...5fba0f4ae560