See https://ci.suse.de/job/yast-yast-network-master/114/display/redirect?page=changes

Changes:

[teclator] Improve additional IP addresses validation

[teclator] Adapt changelog

[teclator] Changes based on CR

------------------------------------------ [...truncated 176.14 KB...] [ 42s] adds a new device with the given name [ 42s] when no device name is given [ 42s] adds a new device with the current device name [ 42s] when the interface already exists [ 42s] does not add any interface [ 42s] LanItems.move_routes [ 42s] assigns all the 'from' routes to the 'to' interface [ 42s] [ 42s] #Yast::DNSClass:0x0000560356be59b0 [ 42s] .default_dhcp_hostname [ 42s] with dhcp_hostname=true in control file [ 42s] in a laptop [ 42s] returns the value from product features [ 42s] in a workstation [ 42s] returns the value from product features [ 42s] with dhcp_hostname=false in control file [ 42s] in a laptop [ 42s] returns the value from product features [ 42s] in a workstation [ 42s] returns the value from product features [ 42s] without dhcp_hostname in control file [ 42s] in a laptop [ 42s] returns false [ 42s] in a workstation [ 42s] returns true [ 42s] .IsHostLocal [ 42s] returns true when host is "localhost" [ 42s] returns true when host is "localhost.localdomain" [ 42s] returns true when host is "::1" [ 42s] returns true when host is "127.0.0.1" [ 42s] returns true when the short hostname is given [ 42s] returns true when the fq hostname is given [ 42s] for IPv4 [ 42s] returns true when the ip of local machine is given [ 42s] returns false when the ip of local machine is not given [ 42s] for IPv6 [ 42s] logs that the implementation is still pending [ 42s] returns false [ 42s] .Read [ 42s] delegates DNS settings reading to Yast::Lan module [ 42s] .Write [ 42s] writes DNS settings [ 42s] .modified [ 42s] when DNS configuration has changed [ 42s] returns true [ 42s] when DNS configuration has not changed [ 42s] returns false [ 42s] #hostname [ 42s] provides static hostname [ 42s] [ 42s] phy_connected? [ 42s] returns true if PHY layer is available [ 42s] returns false if PHY layer is not available [ 42s] [ 42s] NetworkServicesHostInclude [ 42s] #encode_hosts_line [ 42s] encodes canonical name even aliases [ 42s] returns empty string when invalid arguments were passed [ 42s] [ 42s] Yast::HostAutoClient [ 42s] #main [ 42s] when func is Import [ 42s] blames empty host name entries [ 42s] [ 42s] #Yast::HostClass:0x0000560356e71378 [ 42s] .Read [ 42s] reads hosts configuration from system [ 42s] .clear [ 42s] removes all entries from host table [ 42s] .name_map [ 42s] returns hash with ip as key and hostnames as value [ 42s] .names [ 42s] returns empty array if given ip is not is hosts table [ 42s] returns single element array with string containing canonical name and aliases separated by space [ 42s] .add_name [ 43s] adds host to hosts entry even if it is already there [ 43s] .Write [ 43s] writes content of file [ 43s] creates backup of file [ 43s] settings have not been modified [ 43s] does nothing [ 43s] does nothing although system settings have been read [ 43s] .Import [ 43s] loads the current '/etc/hosts' entries [ 43s] merges current entries with the given ones [ 43s] when the profile contains multiple host entries for ::1 [ 43s] converts each duplicated entry to just one line [ 43s] import an emtpy host section [ 43s] does not reset /etc/hosts [ 43s] .Export [ 43s] Successfully exports stored mapping [ 43s] removes empty name lists [ 43s] exports empty hash when no mapping is defined [ 43s] .Update [ 43s] doesn't drop records with two spaces but make it single space [ 43s] adds alias for added hostname [ 43s] deletes old hostnames passed as first parameter [ 43s] adds hostname as alias if ip have already its entry [ 43s] raises an error when empty ip is provided [ 43s] raises an error when nil ip is provided [ 43s] doesn't write entry with duplicate hostname [ 43s] doesn't write entry with duplicate hostname [ 43s] .ResolveHostnameToStaticIPs [ 43s] doesn't call .Update when an IP already has a hostname [ 43s] .ResolveHostnameToStaticIPs [ 43s] do not send array of IPs into .Update [ 43s] doesn't call .Update when an IP already has a hostname [ 43s] .StaticIPs [ 43s] do not return invalid items for devices with static configuration but invalid IP [ 43s] returns all devices with valid setup [ 43s] [ 43s] NetworkLanCmdlineInclude [ 43s] #validateId [ 43s] reports error and returns false if options missing "id" [ 43s] reports error and returns false if options "id" is not number [ 43s] reports error and returns false if options "id" do not fit config size [ 43s] returns true otherwise [ 43s] #ShowHandler [ 43s] prints to command line [ 43s] #ListHandler [ 43s] prints to command line [ 43s] #AddHandler [ 43s] when called without type [ 43s] and it cannot be infered from the given options [ 43s] reports an error [ 43s] returns false [ 43s] when bootproto is given [ 43s] but with an invalid option [ 43s] reports an error [ 43s] returns false [ 43s] when a valid configuration is providen [ 43s] commits the new configuration [ 43s] lists the final configuration [ 43s] returns true [ 43s] #EditHandler [ 43s] when a valid configuration is providen [ 43s] commits the configuration changes [ 43s] shows the configuration of the edited interface [ 43s] returns true [ 43s] #DeleteHandler [ 43s] when a valid configuration is providen [ 43s] [ 43s] (No hardware information) [ 43s] The device is not configured. Press Edit [ 43s] to configure. [ 43s] [ 43s] removes given interface [ 43s] [ 43s] (No hardware information) [ 43s] The device is not configured. Press Edit [ 43s] to configure. [ 43s] [ 43s] returns true [ 43s] [ 43s] Pending: (Failures listed here are expected and do not affect your suite's status) [ 43s] [ 43s] 1) Y2Network::Sysconfig::InterfacesReader#interfaces reads wifi interfaces [ 43s] # Not yet implemented [ 43s] # ./test/y2network/sysconfig/interfaces_reader_test.rb:99 [ 43s] [ 43s] 2) Y2Network::Sysconfig::InterfacesReader#interfaces reads bridge interfaces [ 43s] # Not yet implemented [ 43s] # ./test/y2network/sysconfig/interfaces_reader_test.rb:100 [ 43s] [ 43s] 3) Y2Network::Sysconfig::InterfacesReader#interfaces reads bonding interfaces [ 43s] # Not yet implemented [ 43s] # ./test/y2network/sysconfig/interfaces_reader_test.rb:101 [ 43s] [ 43s] 4) Y2Network::Sysconfig::InterfacesReader#interfaces reads interfaces configuration [ 43s] # Not yet implemented [ 43s] # ./test/y2network/sysconfig/interfaces_reader_test.rb:102 [ 43s] [ 43s] 5) Y2Network::Widgets::BootProtocol#store static configuration selected sets netmask for ipv4 netmask value [ 43s] # drop netmask [ 43s] Failure/Error: expect(builder.subnet_prefix).to eq "255.255.0.0" [ 43s] [ 43s] expected: "255.255.0.0" [ 43s] got: "/16" [ 43s] [ 43s] (compared using ==) [ 43s] # ./test/y2network/widgets/boot_protocol_test.rb:243:in `block (4 levels) in <top (required)>' [ 43s] [ 43s] 6) LanClass #Import flushes internal state of LanItems correctly when asked for reset [ 43s] # Temporarily skipped with xdescribe [ 43s] # ./test/lan_test.rb:159 [ 43s] [ 43s] 7) LanClass #Import reads the current /etc/hosts entries [ 43s] # Temporarily skipped with xdescribe [ 43s] # ./test/lan_test.rb:169 [ 43s] [ 43s] 8) #Yast::LanItemsClass:0x0000560356074cc0 #GetBridgeableInterfaces returns list of slave candidates [ 43s] # old API is dropped, so adapt it [ 43s] Failure/Error: [ 43s] expect(builder.bridgeable_interfaces.map(&:name)) [ 43s] .to match_array expected_bridgeable [ 43s] [ 43s] expected collection contained: ["bond0", "eth11", "eth12", "eth4", "tap0"] [ 43s] actual collection contained: [] [ 43s] the missing elements were: ["bond0", "eth11", "eth12", "eth4", "tap0"] [ 43s] # ./test/bridge_test.rb:140:in `block (3 levels) in <top (required)>' [ 43s] [ 43s] Failures: [ 43s] [ 43s] 1) Y2Network::Dialogs::AdditionalAddress#run when the modifications are applied and the address is not valid reports a validation error [ 43s] Failure/Error: expect(Yast::Popup).to receive(:Error).with(/Invalid/) [ 43s] [ 43s] (#<Yast::PopupClass:0x0000560355525ba8 @my_textdomain=["base"], @feedback_open=false, @default_width=60, @default_height=10, @switch_to_richtext=true, @too_many_lines=20>).Error(/Invalid/) [ 43s] expected: 1 time with arguments: (/Invalid/) [ 43s] received: 0 times [ 43s] # ./test/y2network/dialogs/additional_address_test.rb:57:in `block (5 levels) in <top (required)>' [ 43s] [ 43s] Finished in 32.36 seconds (files took 2.37 seconds to load) [ 43s] 1697 examples, 1 failure, 8 pending [ 43s] [ 43s] Failed examples: [ 43s] [ 43s] rspec ./test/y2network/dialogs/additional_address_test.rb:54 # Y2Network::Dialogs::AdditionalAddress#run when the modifications are applied and the address is not valid reports a validation error [ 43s] [ 43s] rake aborted! [ 43s] Command failed with status (1): [rspec --color --format doc 'test/cfa/gener...] [ 43s] [ 43s] Tasks: TOP => test:unit [ 43s] (See full trace by running task with --trace) [ 43s] error: Bad exit status from /var/tmp/rpm-tmp.Bl3J6k (%check) [ 43s] [ 43s] [ 43s] RPM build errors: [ 43s] Bad exit status from /var/tmp/rpm-tmp.Bl3J6k (%check) [ 43s] [ 43s] yast-ci-worker failed "build yast2-network.spec" at Wed Dec 23 10:40:20 UTC 2020. [ 43s]

The buildroot was: /var/tmp/build-root/SUSE_SLE-15-SP3_GA-x86_64 rm -rf Devel:YaST:Head rake aborted! Command failed with status (1): [yes | osc -A 'https://api.suse.de/' build ...]

Tasks: TOP => osc:sr => osc:commit => osc:build (See full trace by running task with --trace) cleaning Result: PID 19286 exited with value 1 Scanning for a pull request... Found pull request #1135 Adding comment ":x: Internal Jenkins [job #114](https://ci.suse.de/job/yast-yast-network-master/114/) failed" to pull request https://github.com/yast/yast-network/pull/1135 Sending Net::HTTP::Post request to https://api.github.com/repos/yast/yast-network/issues/1135/comments... OK Success Build step 'Execute shell' marked build as failure Not sending mail to unregistered user teclator@gmail.com