March 2020 - YaST Commits - openSUSE Mailing Lists

[yast-commit] [yast/yast-yast2] 316699: Add missing unit tests
by David Díaz 06 Mar '20

06 Mar '20

Branch: refs/heads/fix/loading_services_database Home: https://github.com/yast/yast-yast2 Commit: 316699028cbda240f9e2dbce09d479891d60dfbd https://github.com/yast/yast-yast2/commit/316699028cbda240f9e2dbce09d479891… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/test/port_aliases_test.rb Log Message: ----------- Add missing unit tests The PortAliases public API didn't have unit tests yet, which we considered necessary to make changes in a safety way. Commit: 59a8374b74d0021111f32a1383d6e0039b444a19 https://github.com/yast/yast-yast2/commit/59a8374b74d0021111f32a1383d6e0039… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M library/network/test/port_aliases_test.rb Log Message: ----------- Use `getent` to load the services database The `getent` util will load the database properly, no matter if it is placed in /etc/services, /usr/etc/services, or even in both. Commit: 68689097251a6de4a880f80ac0b681de5223cf25 https://github.com/yast/yast-yast2/commit/68689097251a6de4a880f80ac0b681de5… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M library/network/test/port_aliases_test.rb Log Message: ----------- Improve performance reducing the services lines to process The services database could have almost identical entries for the same services, but with different protocol. Getting rid of the protocol allows to identify and discard those not necessary lines, which helps to improve the performance. Commit: b8ef65895afc3418231cedad626c87671a0a6c83 https://github.com/yast/yast-yast2/commit/b8ef65895afc3418231cedad626c87671… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M library/network/test/port_aliases_test.rb Log Message: ----------- Use a Struct to make easier dealing with services Commit: e0a80f5dce7bf7e0318660ac188ba049a04b786c https://github.com/yast/yast-yast2/commit/e0a80f5dce7bf7e0318660ac188ba049a… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M library/network/test/port_aliases_test.rb Log Message: ----------- Fix documentation and copyright headers Commit: 278db9c09cc3bbf4008e8258b3ea5d1dd7f19454 https://github.com/yast/yast-yast2/commit/278db9c09cc3bbf4008e8258b3ea5d1dd… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M library/network/test/port_aliases_test.rb Log Message: ----------- Get ride of Builtins Commit: a674dc1dd129c3100e8df02e4e31c8d582ef7cab https://github.com/yast/yast-yast2/commit/a674dc1dd129c3100e8df02e4e31c8d58… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M package/yast2.changes M package/yast2.spec Log Message: ----------- Bump version and update changelog Commit: 5c4b61d9e519e3f1211e78e01189117b9feb12d3 https://github.com/yast/yast-yast2/commit/5c4b61d9e519e3f1211e78e01189117b9… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb Log Message: ----------- Fix Rubocop offenses Commit: 8720d01b3f219f361f8e09bf21d6dbe86a7309c5 https://github.com/yast/yast-yast2/commit/8720d01b3f219f361f8e09bf21d6dbe86… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M package/yast2.changes Log Message: ----------- Fix typos and wording based on code review Commit: e23934c964709cd1727977c6062ba9a89bb2e238 https://github.com/yast/yast-yast2/commit/e23934c964709cd1727977c6062ba9a89… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb M library/network/test/port_aliases_test.rb Log Message: ----------- Avoid using complex output pre-process As suggested in the code review, the performance impact should not be noticiable. Commit: 03577a028701b8e95008604731611125f3d12848 https://github.com/yast/yast-yast2/commit/03577a028701b8e95008604731611125f… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb Log Message: ----------- Remove pre-loaded service aliases As suggested during the code review. It helps a bit to simplify the code. Commit: 6ab5c6c195f8485f610d988d7c2c47d173a33e8d https://github.com/yast/yast-yast2/commit/6ab5c6c195f8485f610d988d7c2c47d17… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb Log Message: ----------- Remove unused cache Commit: ad5a5ffd3170cd2092dea63da0af59a118c95843 https://github.com/yast/yast-yast2/commit/ad5a5ffd3170cd2092dea63da0af59a11… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb Log Message: ----------- Do not log `getent sevices` command execution Because its output is too big, now the `logger: nil` option is passed to Yast::Execute in order to use the Cheetah::NullRecorder[1]. [1] https://github.com/openSUSE/cheetah/blob/bafcf46680fba6cc3fa3e60498d2f1d2b7… Compare: https://github.com/yast/yast-yast2/compare/e31523cf6d17...ad5a5ffd3170

1 0

[yast-commit] [yast/yast-yast2] e31523: Do not log `getent sevices` command execution
by David Díaz 06 Mar '20

06 Mar '20

Branch: refs/heads/fix/loading_services_database Home: https://github.com/yast/yast-yast2 Commit: e31523cf6d17aeac3fa3750f67c4877a9c61665a https://github.com/yast/yast-yast2/commit/e31523cf6d17aeac3fa3750f67c4877a9… Author: David Díaz González <dgonzalez(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/network/src/modules/PortAliases.rb Log Message: ----------- Do not log `getent sevices` command execution Because its output is too big, now the `logger: nil` option is passed to Yast::Execute in order to use the Cheetah::NullRecorder[1]. [1] https://github.com/openSUSE/cheetah/blob/bafcf46680fba6cc3fa3e60498d2f1d2b7…

1 0

[yast-commit] [yast/yast-packager] f84f34: Avoid unselecting the base product (bsc#1165501)
by Ladislav Slezák 06 Mar '20

06 Mar '20

Branch: refs/heads/master Home: https://github.com/yast/yast-packager Commit: f84f34cbff0f7703752946c79586111ccba2d207 https://github.com/yast/yast-packager/commit/f84f34cbff0f7703752946c7958611… Author: Ladislav Slezák <lslezak(a)suse.cz> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M package/yast2-packager.changes M package/yast2-packager.spec M src/lib/y2packager/clients/inst_repositories_initialization.rb Log Message: ----------- Avoid unselecting the base product (bsc#1165501) During debugging it turned out that the base product (like SLES) was deselected at this point. Because it is later again selected by solver by other modules dependencies it did not make any problems. But lets fix it to be on the safe side. In an Offline installation this is called at a different place and does not make troubles so handle only the Online case. - 4.2.58 Commit: e3d59227bde5b23db00c207dacc41b0d93393c2c https://github.com/yast/yast-packager/commit/e3d59227bde5b23db00c207dacc41b… Author: Ladislav Slezák <lslezak(a)suse.cz> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M package/yast2-packager.changes M package/yast2-packager.spec M src/lib/y2packager/clients/inst_repositories_initialization.rb Log Message: ----------- Merge pull request #514 from yast/product_init Compare: https://github.com/yast/yast-packager/compare/c0b13a4c5f37...e3d59227bde5

1 0

[yast-commit] [yast/yast-packager]
by Ladislav Slezák 06 Mar '20

06 Mar '20

Branch: refs/heads/product_init Home: https://github.com/yast/yast-packager

1 0

[yast-commit] [yast/yast-yast2]
by Ladislav Slezák 06 Mar '20

06 Mar '20

Branch: refs/heads/product_init Home: https://github.com/yast/yast-yast2

1 0

[yast-commit] [yast/yast-yast2] 3ed7ae: Skip repository reloading (bsc#1165501)
by Ladislav Slezák 06 Mar '20

06 Mar '20

Branch: refs/heads/master Home: https://github.com/yast/yast-yast2 Commit: 3ed7ae50a032f439ebc1cad6321a45d02057da9c https://github.com/yast/yast-yast2/commit/3ed7ae50a032f439ebc1cad6321a45d02… Author: Ladislav Slezák <lslezak(a)suse.cz> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/packages/src/modules/Product.rb M package/yast2.changes M package/yast2.spec Log Message: ----------- Skip repository reloading (bsc#1165501) - 4.2.68 Commit: 3299e093601bb3b77652a3b7d801ac6bf768dff6 https://github.com/yast/yast-yast2/commit/3299e093601bb3b77652a3b7d801ac6bf… Author: Ladislav Slezák <lslezak(a)suse.cz> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M library/packages/src/modules/Product.rb M package/yast2.changes M package/yast2.spec Log Message: ----------- Merge pull request #1028 from yast/product_init Compare: https://github.com/yast/yast-yast2/compare/b0eebf01c548...3299e093601b

1 0

[yast-commit] [yast/yast-packager] f84f34: Avoid unselecting the base product (bsc#1165501)
by Ladislav Slezák 06 Mar '20

06 Mar '20

Branch: refs/heads/product_init Home: https://github.com/yast/yast-packager Commit: f84f34cbff0f7703752946c79586111ccba2d207 https://github.com/yast/yast-packager/commit/f84f34cbff0f7703752946c7958611… Author: Ladislav Slezák <lslezak(a)suse.cz> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M package/yast2-packager.changes M package/yast2-packager.spec M src/lib/y2packager/clients/inst_repositories_initialization.rb Log Message: ----------- Avoid unselecting the base product (bsc#1165501) During debugging it turned out that the base product (like SLES) was deselected at this point. Because it is later again selected by solver by other modules dependencies it did not make any problems. But lets fix it to be on the safe side. In an Offline installation this is called at a different place and does not make troubles so handle only the Online case. - 4.2.58

1 0

[yast-commit] [yast/yast-ntp-client] c921b9: not using Builtins.sformat
by Stefan Schubert 06 Mar '20

06 Mar '20

Branch: refs/heads/SLE-15-SP1-bsc-1164547 Home: https://github.com/yast/yast-ntp-client Commit: c921b99e0024d028f1f8c9ce760d8822ff38fd80 https://github.com/yast/yast-ntp-client/commit/c921b99e0024d028f1f8c9ce760d… Author: Stefan Schubert <schubi(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M src/clients/ntp-client_proposal.rb Log Message: ----------- not using Builtins.sformat

1 0

[yast-commit] [yast/yast-ntp-client] e6bcc3: testcase
by Stefan Schubert 06 Mar '20

06 Mar '20

Branch: refs/heads/SLE-15-SP1-bsc-1164547 Home: https://github.com/yast/yast-ntp-client Commit: e6bcc3e22a9f35f3541957eb1b873557f0679dd7 https://github.com/yast/yast-ntp-client/commit/e6bcc3e22a9f35f3541957eb1b87… Author: Stefan Schubert <schubi(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M test/ntp_client_proposal_test.rb Log Message: ----------- testcase

1 0

[yast-commit] [yast/yast-ntp-client] 5a6359: fixed testcase
by Stefan Schubert 06 Mar '20

06 Mar '20

Branch: refs/heads/SLE-15-SP1-bsc-1164547 Home: https://github.com/yast/yast-ntp-client Commit: 5a6359ad8fe326e3d645bede5bb66d9f948b1b11 https://github.com/yast/yast-ntp-client/commit/5a6359ad8fe326e3d645bede5bb6… Author: Stefan Schubert <schubi(a)suse.de> Date: 2020-03-06 (Fri, 06 Mar 2020) Changed paths: M src/clients/ntp-client_proposal.rb M test/ntp_client_proposal_test.rb Log Message: ----------- fixed testcase

1 0