December 2009 - YaST Commits - openSUSE Mailing Lists

[yast-commit] <rest-service> master : Fixed a hang when PackageKit responded too fast (bnc#561578).
by Martin Vidner 08 Dec '09

08 Dec '09

ref: refs/heads/master commit eb8ae0db1f92fb9ece09f2f57191d6d500750eef Author: Martin Vidner <mvidner(a)suse.cz> Date: Tue Dec 8 18:18:40 2009 +0100 Fixed a hang when PackageKit responded too fast (bnc#561578). All signal handlers need to be in place before the call is made otherwise the signal will be emitted together with the reply (and ignored). A test case is not possible with the current test/packagekit_stub.rb, because it cannot work before run is called. But the bug strikes only when Finished arrives before run is called, even earlier, before the handler is installed. --- plugins/patches/app/models/resolvable.rb | 8 +++++--- .../package/yast2-webservice-patches.changes | 6 ++++++ .../patches/package/yast2-webservice-patches.spec | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/plugins/patches/app/models/resolvable.rb b/plugins/patches/app/models/resolvable.rb index b9682cc..09b1795 100644 --- a/plugins/patches/app/models/resolvable.rb +++ b/plugins/patches/app/models/resolvable.rb @@ -118,16 +118,18 @@ public # def self.execute(method, args, signal, &block) begin + dbusloop = DBus::Main.new transaction_iface, packagekit_iface = self.packagekit_connect proxy = transaction_iface.object proxy.on_signal(signal.to_s, &block) - transaction_iface.send(method.to_sym, *args) - - dbusloop = DBus::Main.new proxy.on_signal("Error") {|u1,u2| dbusloop.quit } proxy.on_signal("Finished") {|u1,u2| dbusloop.quit } + # Do the call only when all signal handlers are in place, + # otherwise Finished can arrive early and dbusloop will never + # quit, bnc#561578 + transaction_iface.send(method.to_sym, *args) dbusloop << DBus::SystemBus.instance dbusloop.run diff --git a/plugins/patches/package/yast2-webservice-patches.changes b/plugins/patches/package/yast2-webservice-patches.changes index be768a6..c85bfc4 100644 --- a/plugins/patches/package/yast2-webservice-patches.changes +++ b/plugins/patches/package/yast2-webservice-patches.changes @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Tue Dec 8 18:24:24 CET 2009 - mvidner(a)suse.cz + +- Fixed a hang when PackageKit responded too fast (bnc#561578). +- 0.0.9 + +------------------------------------------------------------------- Fri Nov 13 14:00:46 UTC 2009 - jreidinger(a)novell.com - adapt to policykit granting script rename (bnc#554946) (mkudlvasr) diff --git a/plugins/patches/package/yast2-webservice-patches.spec b/plugins/patches/package/yast2-webservice-patches.spec index 96912b4..cfd070b 100644 --- a/plugins/patches/package/yast2-webservice-patches.spec +++ b/plugins/patches/package/yast2-webservice-patches.spec @@ -17,7 +17,7 @@ Requires: ruby-dbus >= 0.2.9 License: GPL v2 only Group: Productivity/Networking/Web/Utilities Autoreqprov: on -Version: 0.0.8 +Version: 0.0.9 Release: 0 Summary: YaST2 - Webservice - Patches Source: www.tar.bz2 -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] <rest-service> master : add initial version of ancestor for models, they allow validation, callbacks and mass assignment
by Josef Reidinger 08 Dec '09

08 Dec '09

ref: refs/heads/master commit 3a887ea3796193432c1292ee3a2dec258e69feb0 Author: Josef Reidinger <jreidinger(a)suse.cz> Date: Tue Dec 8 17:51:31 2009 +0100 add initial version of ancestor for models, they allow validation, callbacks and mass assignment --- webservice/lib/base_model/base.rb | 37 +++++++++++++++++++++++++ webservice/lib/base_model/mass_assignment.rb | 9 ++++++ webservice/test/unit/base_model_test.rb | 38 ++++++++++++++++++++++++++ 3 files changed, 84 insertions(+), 0 deletions(-) diff --git a/webservice/lib/base_model/base.rb b/webservice/lib/base_model/base.rb new file mode 100644 index 0000000..e1387e1 --- /dev/null +++ b/webservice/lib/base_model/base.rb @@ -0,0 +1,37 @@ +module BaseModel + class Base + + def save + create_or_update + end + + def save! + create_or_update + #TODO raise exception + end + + def new_record? + true + end + + def create_or_update + (new_record? ? create : update) != false + end + + def create + true + end + + def update + true + end + + def destroy + end + + include BaseModel::MassAssignment + include ActiveRecord::AttributeMethods + include ActiveRecord::Validations + include ActiveRecord::Callbacks + end +end diff --git a/webservice/lib/base_model/mass_assignment.rb b/webservice/lib/base_model/mass_assignment.rb new file mode 100644 index 0000000..ce5dd52 --- /dev/null +++ b/webservice/lib/base_model/mass_assignment.rb @@ -0,0 +1,9 @@ +module BaseModel + module MassAssignment + def load(attributes) + attributes.each do |k,v| + instance_variable_set ( "@#{k.to_s}",v ) + end + end + end +end diff --git a/webservice/test/unit/base_model_test.rb b/webservice/test/unit/base_model_test.rb new file mode 100644 index 0000000..977c364 --- /dev/null +++ b/webservice/test/unit/base_model_test.rb @@ -0,0 +1,38 @@ +require File.dirname(__FILE__) + '/../test_helper' +class BaseModelTest < ActiveSupport::TestCase + class Test < BaseModel::Base + validates_presence_of :arg1 + validates_format_of :arg2, :with => /^\d$/ + before_save :call + + attr_accessor :arg1, :arg2, :callback_used + def call + @callback_used = true; + end + end + + def test_validations + test = Test.new + test.arg1 = "last" + test.arg2 = "5" + assert test.valid? + test.arg1 = nil + test.arg2 = "sda" + assert test.invalid? + end + + def test_callbacks + test = Test.new + test.callback_used = false + assert test.save(false) + assert test.callback_used + end + +MASS_DATA = { :arg1 => "last", :arg2 => "5" } + def test_mass_assignment + test = Test.new + test.load MASS_DATA + assert_equal "last", test.arg1 + assert_equal "5", test.arg2 + end +end -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60006 - in /trunk/qt: package/yast2-qt.changes src/YQContextMenu.cc
by tgoettlicher＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: tgoettlicher Date: Tue Dec 8 17:38:21 2009 New Revision: 60006 URL: http://svn.opensuse.org/viewcvs/yast?rev=60006&view=rev Log: fixed bnc #542830: mouse cursor is busy in context menu Modified: trunk/qt/package/yast2-qt.changes trunk/qt/src/YQContextMenu.cc Modified: trunk/qt/package/yast2-qt.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/qt/package/yast2-qt.changes?rev=… ============================================================================== --- trunk/qt/package/yast2-qt.changes (original) +++ trunk/qt/package/yast2-qt.changes Tue Dec 8 17:38:21 2009 @@ -1,4 +1,9 @@ ------------------------------------------------------------------- +Tue Dec 8 17:34:42 CET 2009 - tgoettlicher(a)suse.de + +- fixed bnc #542830: mouse cursor is busy in context menu + +------------------------------------------------------------------- Mon Sep 28 10:41:55 CEST 2009 - tgoettlicher(a)suse.de - fixed bnc #532518: YaST in translation Modified: trunk/qt/src/YQContextMenu.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/qt/src/YQContextMenu.cc?rev=6000… ============================================================================== --- trunk/qt/src/YQContextMenu.cc (original) +++ trunk/qt/src/YQContextMenu.cc Tue Dec 8 17:38:21 2009 @@ -41,8 +41,7 @@ , YContextMenu( ) , _position ( position ) { - yuiWarning() << "YQContextMenu"; - + // NOP } @@ -69,7 +68,7 @@ // rebuildMenuTree( menu, itemsBegin(), itemsEnd() ); - menu->exec( _position ); + menu->popup( _position ); } -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60005 - /tags/branch-Linux-11_2-2_18_53/network/
by mzugec＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: mzugec Date: Tue Dec 8 15:26:23 2009 New Revision: 60005 URL: http://svn.opensuse.org/viewcvs/yast?rev=60005&view=rev Log: Created tag branch-Linux-11_2-2_18_53 for network Added: tags/branch-Linux-11_2-2_18_53/network/ - copied from r60004, branches/SuSE-Linux-11_2-Branch/network/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60004 - /tags/branch-Linux-11_2-2_18_53/
by mzugec＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: mzugec Date: Tue Dec 8 15:26:21 2009 New Revision: 60004 URL: http://svn.opensuse.org/viewcvs/yast?rev=60004&view=rev Log: Created tag branch-Linux-11_2-2_18_53 Added: tags/branch-Linux-11_2-2_18_53/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60003 - in /branches/SuSE-Linux-11_2-Branch/network: VERSION package/yast2-network.changes src/modules/ISDN.ycp
by mzugec＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: mzugec Date: Tue Dec 8 15:26:14 2009 New Revision: 60003 URL: http://svn.opensuse.org/viewcvs/yast?rev=60003&view=rev Log: ISDN: fixed creating configuration with incorrect name (bnc#534504) Modified: branches/SuSE-Linux-11_2-Branch/network/VERSION branches/SuSE-Linux-11_2-Branch/network/package/yast2-network.changes branches/SuSE-Linux-11_2-Branch/network/src/modules/ISDN.ycp Modified: branches/SuSE-Linux-11_2-Branch/network/VERSION URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Linux-11_2-Branch/networ… ============================================================================== --- branches/SuSE-Linux-11_2-Branch/network/VERSION (original) +++ branches/SuSE-Linux-11_2-Branch/network/VERSION Tue Dec 8 15:26:14 2009 @@ -1 +1 @@ -2.18.52 +2.18.53 Modified: branches/SuSE-Linux-11_2-Branch/network/package/yast2-network.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Linux-11_2-Branch/networ… ============================================================================== --- branches/SuSE-Linux-11_2-Branch/network/package/yast2-network.changes (original) +++ branches/SuSE-Linux-11_2-Branch/network/package/yast2-network.changes Tue Dec 8 15:26:14 2009 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Tue Dec 8 15:25:49 CET 2009 - mzugec(a)suse.cz + +- ISDN: fixed creating configuration with incorrect name (bnc#534504) +- 2.18.53 + +------------------------------------------------------------------- Mon Oct 26 16:00:33 CET 2009 - mzugec(a)suse.cz - show BusID in lan description (FaTE#307165) Modified: branches/SuSE-Linux-11_2-Branch/network/src/modules/ISDN.ycp URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Linux-11_2-Branch/networ… ============================================================================== --- branches/SuSE-Linux-11_2-Branch/network/src/modules/ISDN.ycp (original) +++ branches/SuSE-Linux-11_2-Branch/network/src/modules/ISDN.ycp Tue Dec 8 15:26:14 2009 @@ -795,13 +795,14 @@ */ global define boolean AddIf(string proto) ``{ type = "net"; - device = GetFreeDevice(type); + device = sformat("%1%2", type, GetFreeDevice(type)); interface = $[ "PROTOCOL": proto, "USERCONTROL": "yes", ]; interface = set_ifparameters (interface); operation = `addif; + y2milestone("Adding network configuration %1", device); return true; } -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60002 - /tags/stable-2_19_1/packager/
by kmachalkova＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: kmachalkova Date: Tue Dec 8 14:00:45 2009 New Revision: 60002 URL: http://svn.opensuse.org/viewcvs/yast?rev=60002&view=rev Log: Created tag stable-2_19_1 for packager Added: tags/stable-2_19_1/packager/ - copied from r60001, trunk/packager/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60001 - in /trunk/packager: VERSION package/yast2-packager.changes src/clients/webpin_package_search.ycp
by kmachalkova＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: kmachalkova Date: Tue Dec 8 14:00:37 2009 New Revision: 60001 URL: http://svn.opensuse.org/viewcvs/yast?rev=60001&view=rev Log: Search is the default button Modified: trunk/packager/VERSION trunk/packager/package/yast2-packager.changes trunk/packager/src/clients/webpin_package_search.ycp Modified: trunk/packager/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/packager/VERSION?rev=60001&r1=60… ============================================================================== --- trunk/packager/VERSION (original) +++ trunk/packager/VERSION Tue Dec 8 14:00:37 2009 @@ -1 +1 @@ -2.19.0 +2.19.1 Modified: trunk/packager/package/yast2-packager.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/packager/package/yast2-packager.… ============================================================================== --- trunk/packager/package/yast2-packager.changes (original) +++ trunk/packager/package/yast2-packager.changes Tue Dec 8 14:00:37 2009 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Tue Dec 8 13:54:49 CET 2009 - kmachalkova(a)suse.cz + +- 'Search' button is the one activated by pressing Enter in webpin + client (bnc#538774) +- 2.19.1 + +------------------------------------------------------------------- Tue Nov 24 15:32:33 CET 2009 - locilka(a)suse.cz - Creating backup of old repositories at the end of initial Modified: trunk/packager/src/clients/webpin_package_search.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/packager/src/clients/webpin_pack… ============================================================================== --- trunk/packager/src/clients/webpin_package_search.ycp (original) +++ trunk/packager/src/clients/webpin_package_search.ycp Tue Dec 8 14:00:37 2009 @@ -226,11 +226,14 @@ _("Package Search"), `VBox ( `HBox ( - `VBox( - `MinWidth(20, `InputField (`id ("search_text"), `opt (`hstretch), _("Search &Expression"))), - // TRANSLATORS: push button - `Left(`PushButton (`id ("search"), _("&Search"))), - `VStretch() + `VBox( + `HBox( + `Bottom(`InputField (`id ("search_text"), `opt (`hstretch), _("Search &Expression"))), + // TRANSLATORS: push button + `HSpacing(1), + `Bottom(`PushButton (`id ("search"), `opt(`default), _("&Search"))) + ), + `VStretch() ), `MultiSelectionBox( `id("search_in"), -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r60000 - /trunk/storage/storage/src/modules/Storage.ycp
by fehr＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: fehr Date: Tue Dec 8 12:39:49 2009 New Revision: 60000 URL: http://svn.opensuse.org/viewcvs/yast?rev=60000&view=rev Log: do not overwrite device with empty loop device Modified: trunk/storage/storage/src/modules/Storage.ycp Modified: trunk/storage/storage/src/modules/Storage.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/modules/Stor… ============================================================================== --- trunk/storage/storage/src/modules/Storage.ycp (original) +++ trunk/storage/storage/src/modules/Storage.ycp Tue Dec 8 12:39:49 2009 @@ -1485,7 +1485,7 @@ p["fstype"] = Partitions::loop_name; p["fpath"] = LibStorage::LoopInfo::swig_file_get(info); p["create_file"] = !LibStorage::LoopInfo::swig_reuseFile_get(info); - if( p["enc_type"]:`unknown != `luks ) + if( p["enc_type"]:`unknown != `luks && size(p["loop"]:"")>0 ) p["device"] = p["loop"]:""; c["partitions"] = add( c["partitions"]:[], p ); }); -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r59999 - in /trunk/storage/storage/src/testsuite/tests: proposal1.out proposal1.ycp proposal2.err proposal2.out proposal2.ycp
by aschnell＠svn.opensuse.org 08 Dec '09

08 Dec '09

Author: aschnell Date: Tue Dec 8 12:35:52 2009 New Revision: 59999 URL: http://svn.opensuse.org/viewcvs/yast?rev=59999&view=rev Log: - use helpers Added: trunk/storage/storage/src/testsuite/tests/proposal2.err trunk/storage/storage/src/testsuite/tests/proposal2.out trunk/storage/storage/src/testsuite/tests/proposal2.ycp Modified: trunk/storage/storage/src/testsuite/tests/proposal1.out trunk/storage/storage/src/testsuite/tests/proposal1.ycp Modified: trunk/storage/storage/src/testsuite/tests/proposal1.out URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/testsuite/te… ============================================================================== --- trunk/storage/storage/src/testsuite/tests/proposal1.out (original) +++ trunk/storage/storage/src/testsuite/tests/proposal1.out Tue Dec 8 12:35:52 2009 @@ -0,0 +1,5 @@ +Dump Proposal: +Dump Create extended partition /dev/sda3 (147.09 GB) +Dump Create swap partition /dev/sda5 (2.01 GB) +Dump Create root partition /dev/sda6 (20.00 GB) with ext4 +Dump Create partition /dev/sda7 (125.08 GB) for /home with ext4 Modified: trunk/storage/storage/src/testsuite/tests/proposal1.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/testsuite/te… ============================================================================== --- trunk/storage/storage/src/testsuite/tests/proposal1.ycp (original) +++ trunk/storage/storage/src/testsuite/tests/proposal1.ycp Tue Dec 8 12:35:52 2009 @@ -1,66 +1,15 @@ { - include "testsuite.ycp"; + include "./lib/setup-system.ycp"; - map READ = $[ - "probe" : $[ - "architecture" : "i385", - "cdrom" : [] - ], - "proc" : $[ - "swaps" : [] - ], - "sysconfig" : $[ - "storage" : $[ - "DEFAULT_FS" : "ext4" - ], - "bootloader" : $[ - "LOADER_TYPE" : "grub" - ], - "language" : $[ - "RC_LANG" : "en_US.UTF-8", - "RC_LC_MESSAGES" : "", - ], - ], - "target" : $[ - "size" : 0, - "bash_output" : $[], - "yast2" : $[], - "dir" : [], - ], - ]; + setup_system("one-half-empty"); - TESTSUITE_INIT([READ, $[], READ], nil); + include "./lib/helper1a.ycp"; - - import "Storage"; - import "StorageProposal"; import "ProductFeatures"; ProductFeatures::SetBooleanFeature("partitioning", "try_separate_home", true); ProductFeatures::SetBooleanFeature("partitioning", "proposal_lvm", false); - ProductFeatures::SetStringFeature("partitioning", "root_base_size", "25 GB"); - - StorageProposal::GetControlCfg(); - - map<string, map> target_map = Storage::GetTargetMap(); - map<string, any> prop = StorageProposal::get_inst_prop(target_map); - - if (prop["ok"]:false) - { - Storage::SetTargetMap(prop["target"]:$[]); - - list<map> infos = Storage::GetCommitInfos(); + ProductFeatures::SetStringFeature("partitioning", "root_base_size", "20 GB"); - DUMP("Proposal:"); - foreach(map info, infos, { - string text = info[`text]:""; - if (info[`destructive]:false) - text = text + " [destructive]"; - DUMP(text); - }); - } - else - { - DUMP("No proposal."); - } + include "./lib/helper1b.ycp"; } Added: trunk/storage/storage/src/testsuite/tests/proposal2.err URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/testsuite/te… ============================================================================== (empty) Added: trunk/storage/storage/src/testsuite/tests/proposal2.out URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/testsuite/te… ============================================================================== --- trunk/storage/storage/src/testsuite/tests/proposal2.out (added) +++ trunk/storage/storage/src/testsuite/tests/proposal2.out Tue Dec 8 12:35:52 2009 @@ -0,0 +1,7 @@ +Dump Proposal: +Dump Create boot partition /dev/sda1 (70.60 MB) with ext4 +Dump Create partition /dev/sda2 (29.99 GB) with id=8E +Dump Create volume group system from /dev/sda2 [destructive] +Dump Create logical volume /dev/system/home (19.49 GB) for /home with ext4 +Dump Create logical volume /dev/system/root (10.00 GB) for / with ext4 +Dump Create swap logical volume /dev/system/swap (512.00 MB) Added: trunk/storage/storage/src/testsuite/tests/proposal2.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/testsuite/te… ============================================================================== --- trunk/storage/storage/src/testsuite/tests/proposal2.ycp (added) +++ trunk/storage/storage/src/testsuite/tests/proposal2.ycp Tue Dec 8 12:35:52 2009 @@ -0,0 +1,16 @@ +{ + include "./lib/setup-system.ycp"; + + setup_system("one-empty"); + + include "./lib/helper1a.ycp"; + + import "ProductFeatures"; + + ProductFeatures::SetBooleanFeature("partitioning", "try_separate_home", true); + ProductFeatures::SetBooleanFeature("partitioning", "proposal_lvm", true); + ProductFeatures::SetStringFeature("partitioning", "vm_desired_size", "30 GB"); + ProductFeatures::SetStringFeature("partitioning", "root_base_size", "20 GB"); + + include "./lib/helper1b.ycp"; +} -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0