Am Samstag, 7. September 2013, 20:15:30 schrieb Tobias Klausmann:
Hey there, while seeing the new submit request (https://build.opensuse.org/request/show/197847) and with it the loss of the comments to the previous submit request (hidden in that request), here now a message to all involved (and interested) people.
Johannes, personally i'd really like to have your changes in Mesa but sumski and i, we had some concerns noted in the comments of the previous SR (maybe you want to look at them):
- Do you think this is stable enough for 13.1? (or at least a broader
audience not willing to test bleeding edge software)
See below. But yes it is stable. Even more it should fix some upstream issues like EGL runtime error: https://bugs.freedesktop.org/show_bug.cgi?id=64810
Also Ubuntu builds e. g. libgallium and libmesagallium shared but not with this buildtime speedup shown in my patches: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/mesa/saucy/view/he... http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/mesa/saucy/view/he...
- Will this go into Mesa mainline soon? Anytime? It's quite a deviation
Sorry for German: Damit ich mich nicht immer über die unnötigen Diskussionen, das Bitten und Betteln sowie der einhergehenden Ignoranz der Upstream-Entwickler - selbst bei Patches zur Behebung trivialer Kompilierfehler - ärgern muss, habe ich Einspielrechte beantragt: https://bugs.freedesktop.org/show_bug.cgi?id=69053
I want to maintain master-shared and 9.2-shared branches there until upstream come up to accept them ...
- Why did you remove several packages?
See below (unneccesary).
- Split the huge patch for easier overview.
or for mesa master:
PS: Hopefully i did understand your comment right sumski ;)
Am Samstag, 7. September 2013, 19:05:11 schrieb Johannes Obermayr:
- Drop u_mesa-glapi_dispatch.patch
It is now possible to use $(VISIBILITY_CFLAGS) also for glsl: https://build.opensuse.org/package/rdiff/home:jobermayr:branches:X11:XOrg/Me... So only required symbols are visible from now on :)
Btw. You can see how difficult it is to get even agreed patches upstreamed: http://lists.freedesktop.org/archives/mesa-dev/2013-September/044341.html
Am Donnerstag, 5. September 2013, 15:41:30 schrieb Johannes Obermayr:
Am Donnerstag, 5. September 2013, 14:25:05 schrieb Stefan Dirsch:
I'm afraid we need to discuss these changes. Adding Egbert and Michal.
Comments see below.
On Tue, Sep 03, 2013 at 09:11:45PM +0000, email@example.com wrote:
home:jobermayr:branches:X11:XOrg/Mesa -> X11:XOrg/Mesa
Description: See Mesa.changes
--- Mesa.changes +++ Mesa.changes @@ -1,0 +2,23 @@ +Tue Sep 3 21:02:55 UTC 2013 - firstname.lastname@example.org
+- Drop 0011_u_Fix-crash-in-swrast-when-setting-a-texture-for.patch
It's no longer applicable, which does not necessarily mean, that the issue has been resolved.
That's right. But I could see it has been disabled for ~ 1 1/2 years: https://build.opensuse.org/package/rdiff/X11:XOrg/Mesa?linkrev=base&rev=...
+- Drop 0017_u_mesa-9.0-i965-Make-sure-we-do-render-between.patch
I do not see how this git commit is related to the patch. Could you elaborate?
Discussion with the author in #dri-devel: [Sonntag, 1. September 2013] [15:39:34] <jobermayr> marcheu: Is this patch obsolete: https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/u_mesa-9.0-i965-M... [Sonntag, 1. September 2013] [20:53:51] <marcheu> jobermayr: yup anholt fixed it in git mesa [Sonntag, 1. September 2013] [22:10:24] <jobermayr> marcheu: That means it is still required in 9.2 branch? [Sonntag, 1. September 2013] [22:13:51] <marcheu> I don't think so, check for anholt's commit about URB [Sonntag, 1. September 2013] [22:17:39] <marcheu> http://cgit.freedesktop.org/mesa/mesa/commit/?id=1dfea559c3f188a7a82a4abc097... [Sonntag, 1. September 2013] [22:18:53] <jobermayr> Thanks.
+------------------------------------------------------------------- +Sat Aug 31 18:00:20 UTC 2013 - email@example.com
+- Drop IndirectGL/osmesa
- Use --enable-osmesa instead
- Remove Mesa-libIndirectGL0 and Mesa-libIndirectGL-devel packages
Why? We needed this lib in the past. Unfortunately I no longer can remember, for which purposes and which software components. compiz or some related lib maybe? Anyway, theoretically it should also be possible to use the regular libGL with indirect rendering and software rendering though by setting
So, from my side I would like to accept these changes.
- Speed up build
Sure, that's true.
+- Use patchset from https://github.com/jobermayr/mesa/commits/9.2
- Add 0018_u_build_shared.tar.bz2
- Build as much shared as possible to remove duplicates in binaries
- Less memory consumption at runtime
Please push this patch uptream. Otherwise we cannot accept. Last time we tried to share code in DRI drivers we failed miserably (undefined symbols)! BTW, this is a patch, not a tarball (of patches). ;-)
I am working with Andreas Boll (aboll) from Intel to upstream it. But my experience is same as always: maintainers first welcome to do things, then when I try to upstream well tested work they don't push - even more: they show intolerable! and don't reply ... :-(
Don't think about undefined symbols. I set for each shared lib "-Wl,--no-undefined": https://github.com/jobermayr/mesa/commit/cd04198 or commented what TODO
You can also see in this patchset fixes for a lot of undefined symbols ... Because of my stupidness I even had to make all symbols in glsl visible to fix two of them: https://github.com/jobermayr/mesa/commit/bf17997
This is well tested on a AMD Fusion (r600), Nvidia ION (nouveau) and ATI Mobility Radeon (r200).
To say it like our last minister of defence: "[...] in mühevollster Kleinstarbeit [...]" :)
- Remove Mesa-libglapi0 and Mesa-libglapi-devel packages
Why? Is this the consequence of your patch to share as much code as possible?
Because Mesa's internal libs are now in %_libdir/mesa-9.2.0/* or %_libdir/mesa-9.3.0-devel/* which belongs to Mesa package ...
Please don't split Mesa package more. Because of the dependencies IMHO there should even be only Mesa and Mesa-devel package ...
- Speed up build
+- Prefix numbers to patches
If really helpful/required, we want it the other way round, i.e. u_XXXX_...
I am trying to make Adam Jackson (ajax) to upstream 0013 and 0015 ;)