[softwaremgmt] Listing patches with "zypper patches/list-patches"
(In reply to comment #5 https://bugzilla.novell.com/show_bug.cgi?id=506860#c5):
Anyway, IMO zypper should not deal with individual patch resolvables, but use Selectable and test for Selectable::isSatisfied (this considers the latest version of the patch).
Agreed, i'll do it. But it made me think abou the patch lists we show. Currently 'zypper patches' shows all versions (resolvables): $ zypper patches <cut> openSUSE 11.1 Updates │ xpdf │ 579 │ recommended │ Not Applicable openSUSE 11.1 Updates │ xpdf │ 793 │ security │ Not Applicable <cut> Shouldn't we show only the latest, esp. if the policy dictates (is it documented somewhere?) that newer patches obsolete the older ones? And i guess for 'zypper list-patches' it's only natural that only the latest version should be shown as well then. -- cheers, jano Ján Kupec YaST team ---------------------------------------------------------(PGP)--- Key ID: 637EE901 Fingerprint: 93B9 C79B 2D20 51C3 800B E09B 8048 46A6 637E E901 ---------------------------------------------------------(IRC)--- Server: irc.freenode.net Nick: jniq Channels: #zypp #yast #suse #susecz ---------------------------------------------------------(EOF)---
On Thursday 25 June 2009 17:19:55 Jano Kupec wrote:
(In reply to comment #5
https://bugzilla.novell.com/show_bug.cgi?id=506860#c5):
Anyway, IMO zypper should not deal with individual patch resolvables, but use Selectable and test for Selectable::isSatisfied (this considers the latest version of the patch).
Agreed, i'll do it.
But it made me think abou the patch lists we show. Currently 'zypper patches' shows all versions (resolvables):
$ zypper patches <cut> openSUSE 11.1 Updates │ xpdf │ 579 │ recommended │ Not Applicable openSUSE 11.1 Updates │ xpdf │ 793 │ security │ Not Applicable <cut>
Shouldn't we show only the latest, esp. if the policy dictates (is it documented somewhere?) that newer patches obsolete the older ones?
Well - Patches are assertions, so I'd say they 'include' older ones rather than 'obsolete' them.
And i guess for 'zypper list-patches' it's only natural that only the latest version should be shown as well then.
Zyppers suggestions should be based on the status of the latest patch version(level). But I don't think we should completely hide the older versions. When looking for a patch that fixed a certain bug, you may find it's fixed in somepatch-3. So you want to see if somepatch-3 is satisfied, even if somepatch-4 is already released. Maybe you consider somepatch-4 not being that important, and decide to stay at level -3. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: opensuse-softwaremgmt+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-softwaremgmt+help@opensuse.org
On Monday 29 June 2009 13:52:47 Michael Andres wrote:
On Thursday 25 June 2009 17:19:55 Jano Kupec wrote:
(In reply to comment #5
https://bugzilla.novell.com/show_bug.cgi?id=506860#c5):
Anyway, IMO zypper should not deal with individual patch resolvables, but use Selectable and test for Selectable::isSatisfied (this considers the latest version of the patch).
Agreed, i'll do it.
But it made me think abou the patch lists we show. Currently 'zypper patches' shows all versions (resolvables):
$ zypper patches <cut> openSUSE 11.1 Updates │ xpdf │ 579 │ recommended │ Not Applicable openSUSE 11.1 Updates │ xpdf │ 793 │ security │ Not Applicable <cut>
Shouldn't we show only the latest, esp. if the policy dictates (is it documented somewhere?) that newer patches obsolete the older ones?
Well - Patches are assertions, so I'd say they 'include' older ones rather than 'obsolete' them.
And i guess for 'zypper list-patches' it's only natural that only the latest version should be shown as well then.
Zyppers suggestions should be based on the status of the latest patch version(level). But I don't think we should completely hide the older versions.
'zypper list-patches' - consider the latest patch only. 'zypper patches' - IMO show all versions. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: opensuse-softwaremgmt+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-softwaremgmt+help@opensuse.org
Michael Andres wrote:
On Monday 29 June 2009 13:52:47 Michael Andres wrote:
(In reply to comment #5
https://bugzilla.novell.com/show_bug.cgi?id=506860#c5):
Anyway, IMO zypper should not deal with individual patch resolvables, but use Selectable and test for Selectable::isSatisfied (this considers the latest version of the patch). Agreed, i'll do it.
But it made me think abou the patch lists we show. Currently 'zypper patches' shows all versions (resolvables):
$ zypper patches <cut> openSUSE 11.1 Updates │ xpdf │ 579 │ recommended │ Not Applicable openSUSE 11.1 Updates │ xpdf │ 793 │ security │ Not Applicable <cut>
Shouldn't we show only the latest, esp. if the policy dictates (is it documented somewhere?) that newer patches obsolete the older ones? Well - Patches are assertions, so I'd say they 'include' older ones rather
On Thursday 25 June 2009 17:19:55 Jano Kupec wrote: than 'obsolete' them.
Yes, i had patches obsoleting (or conflicting with) older packages in mind, which in fact means 'including' the older patches.
And i guess for 'zypper list-patches' it's only natural that only the latest version should be shown as well then. Zyppers suggestions should be based on the status of the latest patch version(level). But I don't think we should completely hide the older versions.
You're right about the different patch levels (versions) and that the user should be able to see them so that s/he can check what bugs it fixes and what level to install (although the solver will currently does not enable this - it alway installs the best packages even if lower version of the patch was requested; but the user can install specific version of a package instead).
'zypper list-patches' - consider the latest patch only.
Heh, after i read your first mail, i was convinced to show all (needed) versions here :O) Here's why: This way the user won't see that s/he can choose from multiple versions and all the bugs the new patches are fixing. Yes, 'zypper patch' or 'zypper install -t patch foo' will choose the latest, but the user can decide not to install one of them, and install specific package version instead (which is not very easy currently, due to the solver always picking the latest, but that's another problem).
'zypper patches' - IMO show all versions.
agreed. so it will stay as it is now. -- cheers, jano Ján Kupec YaST team ---------------------------------------------------------(PGP)--- Key ID: 637EE901 Fingerprint: 93B9 C79B 2D20 51C3 800B E09B 8048 46A6 637E E901 ---------------------------------------------------------(IRC)--- Server: irc.freenode.net Nick: jniq Channels: #zypp #yast #suse #susecz ---------------------------------------------------------(EOF)---
On Monday 29 June 2009 15:16:09 Jano Kupec wrote:
'zypper list-patches' - consider the latest patch only.
Heh, after i read your first mail, i was convinced to show all (needed) versions here :O) Here's why:
This way the user won't see that s/he can choose from multiple versions and all the bugs the new patches are fixing.
There's no real choice. Only the latest Patch fixes 'everything', so this is what zypper should suggest. (you could offer 'list-patches --all' to also include needed older versions) -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: opensuse-softwaremgmt+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-softwaremgmt+help@opensuse.org
Michael Andres wrote:
On Monday 29 June 2009 15:16:09 Jano Kupec wrote:
'zypper list-patches' - consider the latest patch only. Heh, after i read your first mail, i was convinced to show all (needed) versions here :O) Here's why:
This way the user won't see that s/he can choose from multiple versions and all the bugs the new patches are fixing.
There's no real choice. Only the latest Patch fixes 'everything', so this is what zypper should suggest.
Yes, unless some serious bug sneaks into the latest patch :O) Should not happen, but sometimes it does.
(you could offer 'list-patches --all' to also include needed older versions)
True. -- cheers, jano Ján Kupec YaST team ---------------------------------------------------------(PGP)--- Key ID: 637EE901 Fingerprint: 93B9 C79B 2D20 51C3 800B E09B 8048 46A6 637E E901 ---------------------------------------------------------(IRC)--- Server: irc.freenode.net Nick: jniq Channels: #zypp #yast #suse #susecz ---------------------------------------------------------(EOF)---
participants (2)
-
Jano Kupec -
Michael Andres