Re: [ANNOUNCE] xf86-video-radeonhd 1.0.0 - INITIAL RELEASE (fwd) - Radeon HD

Re: [ANNOUNCE] xf86-video-radeonhd 1.0.0 - INITIAL RELEASE (fwd)

older
[Bug 13468] New: radeonhd driver...

Matthias Hopf

30 Nov 2007 30 Nov '07

16:03

Ndim + Luc, you might want to look into that. Juan, was this patch necessary for you to get the connector table right? Because we only want to add cards in this table that have a broken one. Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de

Attachments:

attachment.eml (message/rfc822 — 3.8 KB)

Show replies by date

Juan RP

30 Nov 30 Nov

17:28

New subject: [ANNOUNCE] xf86-video-radeonhd 1.0.0 - INITIAL RELEASE (fwd)

On Fri, 30 Nov 2007 17:03:12 +0100 Matthias Hopf wrote:

...

Ndim + Luc, you might want to look into that.

Juan, was this patch necessary for you to get the connector table right? Because we only want to add cards in this table that have a broken one.

I needed this patch is order to run X, haven't tried with latest version... will report more info next week (I don't have the Radeon card plugged in right now). Thanks, -- Juan Romero Pardines - The NetBSD Project http://plog.xtrarom.org - NetBSD/pkgsrc news in Spanish -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Matthias Hopf

11 Dec 11 Dec

16:43

New subject: [ANNOUNCE] xf86-video-radeonhd 1.0.0 - INITIAL RELEASE (fwd)

On Nov 30, 07 18:28:04 +0100, Juan RP wrote:

...

Matthias Hopf wrote:

...
Juan, was this patch necessary for you to get the connector table right? Because we only want to add cards in this table that have a broken one.

I needed this patch is order to run X, haven't tried with latest version... will report more info next week (I don't have the Radeon card plugged in right now).

Any news on that? Though I doubt that anything has changed... Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Hans Ulrich Niedermann

1 Dec 1 Dec

01:44

New subject: [PATCH 1/2] Fix quoting issues on NetBSD ash

From: Joerg Sonnenberger --- git_version.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git_version.sh b/git_version.sh index 6f70076..f033e55 100644 --- a/git_version.sh +++ b/git_version.sh @@ -137,7 +137,7 @@ unset git_errors ||: if [ "x$git_found" = "xyes" ]; then git_version=`git --version` if [ "x$git_version" = "x" ]; then - git_errors="${git_errors+"${git_errors}; "}error running 'git --version'" + git_errors="${git_errors+${git_errors}; }error running 'git --version'" fi fi @@ -153,7 +153,7 @@ if [ "x$git_repo_dir" != "x" ] && [ "x${abs_repo_dir}" = "x${abs_srcdir}/.git" ] # git-1.4 and probably earlier understand "git-rev-parse HEAD" git_shaid=`git-rev-parse HEAD | $SED -n 's/^$.\{8\}$.*/\1/p'` if [ "x$git_shaid" = "x" ]; then - git_errors="${git_errors+"${git_errors}; "}error running 'git-rev-parse HEAD'" + git_errors="${git_errors+${git_errors}; }error running 'git-rev-parse HEAD'" fi # git-1.4 and probably earlier understand "git-symbolic-ref HEAD" git_branch=`git-symbolic-ref HEAD | $SED -n 's|^refs/heads/||p'` -- 1.5.3.4 -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Hans Ulrich Niedermann

01:44

New subject: [PATCH 2/2] Get rid of another potential quoting problem

Some obscure shell might choke on this as well. --- git_version.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git_version.sh b/git_version.sh index f033e55..52b130e 100644 --- a/git_version.sh +++ b/git_version.sh @@ -26,7 +26,7 @@ Options: -x, --example Print complete example program." # The caller may have set these for us -SED="${SED-"sed"}" +SED="${SED-sed}" # Initialize working_dir="$(pwd)" -- 1.5.3.4 -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Matthias Hopf

4 Dec 4 Dec

16:54

New subject: [PATCH 2/2] Get rid of another potential quoting problem

On Dec 01, 07 02:44:09 +0100, Hans Ulrich Niedermann wrote:

...

working_dir="$(pwd)"

Just as I see this - $(cmd) is a bash extension AFAIK. Better use "`cmd`". Will commit your changes tomorrow. Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Hans Ulrich Niedermann

17:51

New subject: [PATCH 2/2] Get rid of another potential quoting problem

Matthias Hopf wrote:

...

On Dec 01, 07 02:44:09 +0100, Hans Ulrich Niedermann wrote:

...
working_dir="$(pwd)"

Just as I see this - $(cmd) is a bash extension AFAIK. Better use "`cmd`".

$(cmd) is not a bashism. $(cmd) is POSIX sh, and is supported by most shs even if they are not strictly POSIX in other ways. The one sh that does not grok $(cmd) is the Solaris /bin/sh. However, Solaris has a working sh in /usr/iforgotwhatitwaswith4/bin/sh, so they can just SHELL=/usr/iforgotwhatitwaswith4/bin/sh and it will work for them. Correct quoting with $() is easy (for file and directory names with spaces e.g.). Correct quoting and escaping with `` frankly escapes me, though, and IIRC there were some things that could not be quoted correctly at all with ``. You're welcome to help me there, of course. I personally think the benefits of the correct nesting and quoting of $() far outweigh that users of the single system with the broken-by-default sh have to explicitly specify the functional sh that is sitting just two directories away. E.g. git's scripts use sh functions and $() substitution. -- Hans Ulrich Niedermann

Stefan Monnier

5 Dec 5 Dec

02:17

New subject: [PATCH 2/2] Get rid of another potential quoting problem

...

The one sh that does not grok $(cmd) is the Solaris /bin/sh. However, Solaris has a working sh in /usr/iforgotwhatitwaswith4/bin/sh, so they

I know that was the case a decade ago. Are you sure it's still the case? Stefan -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Hans Ulrich Niedermann

09:01

New subject: [PATCH 2/2] Get rid of another potential quoting problem

Stefan Monnier wrote:

...

...
The one sh that does not grok $(cmd) is the Solaris /bin/sh. However, Solaris has a working sh in /usr/iforgotwhatitwaswith4/bin/sh, so they

I know that was the case a decade ago. Are you sure it's still the case?

No. IIRC it was the case the last time I did cross-builds of libgphoto2 on Solaris/SPARC on the Sourceforge compile farm - whatever version that was. But if even this most obscure of systems has since joined the world of contemporary software, so much the better :) -- Hans Ulrich Niedermann

Matthias Hopf

11:57

New subject: [PATCH 2/2] Get rid of another potential quoting problem

On Dec 04, 07 18:51:12 +0100, Hans Ulrich Niedermann wrote:

...

$(cmd) is not a bashism. $(cmd) is POSIX sh, and is supported by most shs even if they are not strictly POSIX in other ways.

Ok, didn't know that this is POSIX now. I just remember the days when one had to write 'if [ "x$1" != x ] ; then' in order to not get bashed by sh (what a phrase ;)

...

Correct quoting with $() is easy (for file and directory names with spaces e.g.). Correct quoting and escaping with `` frankly escapes me, though, and IIRC there were some things that could not be quoted correctly at all with ``. You're welcome to help me there, of course.

It's not as complex - as long as no additional ` is included, all escaping in the subshell is unrelated, so a="`cmd "single argument"`" is perfectly valid and working. Nevertheless, you're used to $(), so keep it.

...

E.g. git's scripts use sh functions and $() substitution.

Strong point. Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Hans Ulrich Niedermann

09:03

New subject: [PATCH] sh cmd substitution w/ backticks until git found

git's sh scripts use $(), so if we have detected git we know there is a $() capable sh on board somewhere and can use it. Until then, we use `` and hope our quoting is a) correct and b) works even on those ancient sh implementations which may have problems with $(). --- git_version.sh | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/git_version.sh b/git_version.sh index 52b130e..10acee0 100644 --- a/git_version.sh +++ b/git_version.sh @@ -29,10 +29,10 @@ Options: SED="${SED-sed}" # Initialize -working_dir="$(pwd)" +working_dir=`pwd` # Who am I? -self="$(basename "$0")" +self=`basename "$0"` # Defaults ifndef_symbol="GIT_VERSION_H" @@ -40,7 +40,7 @@ outfile="-" print_example=false keep_if_no_repo=no quiet=false -srcdir="$(pwd)" +srcdir=`pwd` # Parse command line parameter, affecting defaults while [ "x$1" != "x" ] @@ -131,6 +131,7 @@ do break fi done +# If git_found=yes, we can now use $() substitutions (as git does). Hooray! # Determine git specific defines unset git_errors ||: -- 1.5.3.4 -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Matthias Hopf

11 Dec 11 Dec

16:41

New subject: [PATCH 2/2] Get rid of another potential quoting problem

On Dec 01, 07 02:44:09 +0100, Hans Ulrich Niedermann wrote: ... took a while, but thanks :) BTW - what's happened to radeonhd.lauft.net? Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

5980

Age (days ago)

5991

Last active (days ago)

List overview

Download

11 comments

4 participants

participants (4)

Hans Ulrich Niedermann
Juan RP
Matthias Hopf
Stefan Monnier