[opensuse-packaging] Python package tries to download dependencies during build
Hi!
I'm currently packaging "python-sshtunnel" but I am unable to build the package
as the build fails with setuptools trying to download paramiko during install
which is not allowed, of course (see below for the fail of the build log).
I have already added paramiko to BuildRequires but setuptools still insists
on trying to download paramiko. I couldn't find any reference to the download
in the python code though.
Any ideas?
Adrian
===============================================================================
[ 6s] using tox.ini: /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/setup.cfg
[ 6s] using tox-2.9.1 from /usr/lib/python2.7/site-packages/tox/__init__.pyc
[ 6s] GLOB sdist-make: /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/setup.py
[ 6s] /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3$ /usr/bin/python2 /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/setup.py sdist --formats=zip --dist-dir /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/dist >/home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/log/tox-0.log
[ 6s] python create: /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/python
[ 6s] /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox$ /usr/bin/python2 -m virtualenv --python /usr/bin/python2 python >/home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/python/log/python-0.log
[ 32s] python inst: /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/dist/sshtunnel-0.1.3.zip
[ 32s] WARNING:Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
[ 32s] /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3$ /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/python/bin/pip install /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/dist/sshtunnel-0.1.3.zip >/home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/python/log/python-1.log
[ 41s] ERROR: invocation failed (exit code 1), logfile: /home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/python/log/python-1.log
[ 41s] ERROR: actionid: python
[ 41s] msg: installpkg
[ 41s] cmdargs: ['/home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/python/bin/pip', 'install', '/home/abuild/rpmbuild/BUILD/sshtunnel-0.1.3/.tox/dist/sshtunnel-0.1.3.zip']
[ 41s]
[ 41s] Processing ./.tox/dist/sshtunnel-0.1.3.zip
[ 41s] Collecting paramiko>=1.15.2 (from sshtunnel==0.1.3)
[ 41s] Retrying (Retry(total=4, connect=None, read=None, redirect=None)) after connection broken by 'NewConnectionError('
On Fri, May 4, 2018 at 11:00 AM John Paul Adrian Glaubitz < adrian.glaubitz@suse.com> wrote:
Hi!
I'm currently packaging "python-sshtunnel" but I am unable to build the package as the build fails with setuptools trying to download paramiko during install which is not allowed, of course (see below for the fail of the build log).
I have already added paramiko to BuildRequires but setuptools still insists on trying to download paramiko. I couldn't find any reference to the download in the python code though.
Any ideas?
Do you have your packaging uploaded somewhere to look at? -- 真実はいつも一つ！/ Always, there's only one truth! -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Hi Adrian,
I'm currently packaging "python-sshtunnel" but I am unable to build the package as the build fails with setuptools trying to download paramiko during install which is not allowed, of course (see below for the fail of the build log).
I have already added paramiko to BuildRequires but setuptools still insists on trying to download paramiko. I couldn't find any reference to the download in the python code though.
Any ideas?
Not sure if this is the problem, but I guess it's checking a test suite through tox. Usually tox tries to build a virtual Python environment and downloads all the requirements from PyPI. Do you have a link to your specific OBS project or spec file? Otherwise it's hard to tell. ;)
[...]
-- Gruß/Regards, Thomas Schraitle ---------------------------------------------------------------------- SUSE LINUX GmbH (o< Maxfeldstrasse 5 /\\ Documentation Specialist 90409 Nuernberg, Germany _\_v http://www.suse.com http://lizards.opensuse.org/author/thomas-schraitle/ GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Hi Thomas! On 05/04/2018 05:16 PM, Thomas Schraitle wrote:
Not sure if this is the problem, but I guess it's checking a test suite through tox. Usually tox tries to build a virtual Python environment and downloads all the requirements from PyPI.
Yes, it's using tox.
Do you have a link to your specific OBS project or spec file? Otherwise it's hard to tell. ;)
I'm currently checking it in to:
https://build.opensuse.org/project/show/home:glaubitz:branches:devel:languag...
but I currently have a slow connection to OBS. It should show up there in a few minutes. Adrian -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Hi, Am Freitag, 4. Mai 2018, 17:18:23 CEST schrieb John Paul Adrian Glaubitz:
On 05/04/2018 05:16 PM, Thomas Schraitle wrote:
Not sure if this is the problem, but I guess it's checking a test suite through tox. Usually tox tries to build a virtual Python environment and downloads all the requirements from PyPI.
Yes, it's using tox.
You can just directly run the test commands that are specified in the tox file, at least that's how I would do it. As you are packaging you don't have to test the Python distribution mechanism (which is one feature of tox), and the unified spec should take care of testing it on all Python versions (which is the other feature of tox). Kind Regards, Matthias -- Dr. Matthias Bach www.marix.org „Der einzige Weg, die Grenzen des Möglichen zu finden, ist ein klein wenig über diese hinaus in das Unmögliche vorzustoßen.“ - Arthur C. Clarke
Hi Adrian, Am Freitag, 4. Mai 2018, 17:18:23 CEST schrieb John Paul Adrian Glaubitz:
[...]
Do you have a link to your specific OBS project or spec file? Otherwise it's hard to tell. ;)
I'm currently checking it in to:
https://build.opensuse.org/project/show/home:glaubitz:branches:devel:langu ages:python but I currently have a slow connection to OBS. It should show up there in a few minutes.
Thanks, that was helpful. The most important issues I've found: * First, the tarball doesn't contain any tests at all. So it's pretty useless to run tox without tests. ;) * As sshtunnel is installed as a executable script under /usr/bin, you should take into account the different Python versions. As such, I've added alternatives. See the files in /usr/bin/. You can find all my changes in the following request: https://build.opensuse.org/request/show/604491 It builds for all architectures except those that have blocked packages. Of course, you can improve the spec file and introduce a variable, run spec- cleaner etc. but that's up to you. :) Hope this helps. -- Gruß/Regards, Thomas Schraitle ---------------------------------------------------------------------- SUSE LINUX GmbH (o< Maxfeldstrasse 5 /\\ Documentation Specialist 90409 Nuernberg, Germany _\_v http://www.suse.com http://lizards.opensuse.org/author/thomas-schraitle/ GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Hi Thomas! On 05/05/2018 12:12 PM, Thomas Schraitle wrote:
The most important issues I've found:
* First, the tarball doesn't contain any tests at all. So it's pretty useless to run tox without tests. ;) * As sshtunnel is installed as a executable script under /usr/bin, you should take into account the different Python versions. As such, I've added alternatives. See the files in /usr/bin/.
You can find all my changes in the following request:
https://build.opensuse.org/request/show/604491
It builds for all architectures except those that have blocked packages. Of course, you can improve the spec file and introduce a variable, run spec- cleaner etc. but that's up to you. :)
Thanks a lot. Your fixes helped a lot, indeed. I need python-sshtunnel as a dependency only, so I cannot invest too much time in making the package perfect. Adrian -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Mon, 2018-05-07 at 10:42 +0200, John Paul Adrian Glaubitz wrote:
Hi Thomas!
On 05/05/2018 12:12 PM, Thomas Schraitle wrote:
The most important issues I've found:
* First, the tarball doesn't contain any tests at all. So it's pretty useless to run tox without tests. ;) * As sshtunnel is installed as a executable script under /usr/bin, you should take into account the different Python versions. As such, I've added alternatives. See the files in /usr/bin/.
You can find all my changes in the following request:
https://build.opensuse.org/request/show/604491
It builds for all architectures except those that have blocked packages. Of course, you can improve the spec file and introduce a variable, run spec- cleaner etc. but that's up to you. :)
Thanks a lot. Your fixes helped a lot, indeed. I need python-sshtunnel as a dependency only, so I cannot invest too much time in making the package perfect.
That's probably the weirdest argument I ever heard. If your package FOO depends on BAR, you better have BAR in good shape or FOO will be broken too. Do, or do not - but don't do things half-way (just to paraphraze) Cheers Dominique
On 05/07/2018 11:16 AM, Dominique Leuenberger / DimStar wrote:
That's probably the weirdest argument I ever heard. If your package FOO depends on BAR, you better have BAR in good shape or FOO will be broken too.
Not really. If I spend several hours now to make a small dependency package perfect under every aspect of the packaging guidelines instead of continuing with the packages we actually need for the Public Cloud Team, my colleagues won't be particularly happy. Adrian -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Mon, 2018-05-07 at 11:21 +0200, John Paul Adrian Glaubitz wrote:
On 05/07/2018 11:16 AM, Dominique Leuenberger / DimStar wrote:
That's probably the weirdest argument I ever heard. If your package FOO depends on BAR, you better have BAR in good shape or FOO will be broken too.
Not really. If I spend several hours now to make a small dependency package perfect under every aspect of the packaging guidelines instead of continuing with the packages we actually need for the Public Cloud Team, my colleagues won't be particularly happy.
You in turn will shout at the review team doings it job by pointing out things that are wrong when compared to the packaging guidelines - making neither you nor the review team happy - and as a direct consequence your colleagues will also not be happy. What do you gain? Cheers Dominique
On 05/07/2018 11:24 AM, Dominique Leuenberger / DimStar wrote:
Not really. If I spend several hours now to make a small dependency package perfect under every aspect of the packaging guidelines instead of continuing with the packages we actually need for the Public Cloud Team, my colleagues won't be particularly happy.
You in turn will shout at the review team doings it job by pointing out things that are wrong when compared to the packaging guidelines -
I've never done that. I usually always make all the changes requested by the review team.
making neither you nor the review team happy - and as a direct consequence your colleagues will also not be happy. What do you gain?
What do I gain when I invest hours in making a small Python package (I'm not talking about the kernel or any toolchain package) when this isn't my main task I am being paid for? Adrian -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Mon, 2018-05-07 at 11:45 +0200, John Paul Adrian Glaubitz wrote:
On 05/07/2018 11:24 AM, Dominique Leuenberger / DimStar wrote:
Not really. If I spend several hours now to make a small dependency package perfect under every aspect of the packaging guidelines instead of continuing with the packages we actually need for the Public Cloud Team, my colleagues won't be particularly happy.
You in turn will shout at the review team doings it job by pointing out things that are wrong when compared to the packaging guidelines -
I've never done that. I usually always make all the changes requested by the review team.
Ok, in this case I apologize - you indeed have not done so; but I clearly do recall discussions into this direction with other maintainers
making neither you nor the review team happy - and as a direct consequence your colleagues will also not be happy. What do you gain?
What do I gain when I invest hours in making a small Python package (I'm not talking about the kernel or any toolchain package) when this isn't my main task I am being paid for?
Well, if you are paid to get FOO into shape and FOO depends on BAR: shoulnd't you discuss with your manager to get BAR into your line of duties, as you obviously can't provide FOO without BAR? Either you/your team/your manager * acknowledge the importance or BAR (and maintain it) * find a different team/maintainer for BAR * Work towards FOO being usable without BAR I don't think there are other options available. Cheers, Dominique
On 07/05/18 19:15, John Paul Adrian Glaubitz wrote:
On 05/07/2018 11:24 AM, Dominique Leuenberger / DimStar wrote:
Not really. If I spend several hours now to make a small dependency package perfect under every aspect of the packaging guidelines instead of continuing with the packages we actually need for the Public Cloud Team, my colleagues won't be particularly happy.
You in turn will shout at the review team doings it job by pointing out things that are wrong when compared to the packaging guidelines -
I've never done that. I usually always make all the changes requested by the review team.
making neither you nor the review team happy - and as a direct consequence your colleagues will also not be happy. What do you gain?
What do I gain when I invest hours in making a small Python package (I'm not talking about the kernel or any toolchain package) when this isn't my main task I am being paid for?
Adrian
If a package you use has dependencies that need to be maintained and no one else is maintaining them then yes it becomes part of your job unless you can convince someone else / another team to look after them for you. I have several packages that I need to maintain indirectly because I have customer packages that depend on them as do many other members of SUSE's packaging team. -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B
participants (6)
-
Dominique Leuenberger / DimStar -
John Paul Adrian Glaubitz -
Matthias Bach -
Neal Gompa -
Simon Lees -
Thomas Schraitle