[opensuse-packaging] What to do with review request?
Hey, as one of the storeBackup maintainers I got review request assigned from leaper. [0] However, leaper set the review reason to: | Submission for storeBackup by someone who is not maintainer in the devel | project (devel:openSUSE:Factory). Please review Thus, I didn't review it. Since I am getting review reminders from staging-bot for this request, I am wondering whether I have to take action? [0] https://build.opensuse.org/request/show/500089 -- A bore is a man who deprives you of solitude without providing you with company. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 6/11/17 11:51 AM, Jan Ritzerfeld wrote:
| Submission for storeBackup by someone who is not maintainer in the devel | project (devel:openSUSE:Factory). Please review Yes, you have to decide if you are ok with submitted version being in Leap
Cheers M -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Am Sonntag, 11. Juni 2017, 12:31:13 CEST schrieb Martin Pluskal:
On 6/11/17 11:51 AM, Jan Ritzerfeld wrote:
| Submission for storeBackup by someone who is not maintainer in the devel | project (devel:openSUSE:Factory). Please review
Yes, you have to decide if you are ok with submitted version being in Leap
Ah, my bad! Right after reading leapers comment in your quoting again I got it. Thank you very much Jan -- The trouble with the rat race is that even if you win, you're still a rat. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 11/06/17 19:21, Jan Ritzerfeld wrote:
Hey,
as one of the storeBackup maintainers I got review request assigned from leaper. [0] However, leaper set the review reason to: | Submission for storeBackup by someone who is not maintainer in the devel | project (devel:openSUSE:Factory). Please review Thus, I didn't review it.
When someone who is not a maintainer of a given package submits that package into leap the request needs to be reviewed by the maintainers (in this case yourself) to check that they are happy for a new version of that package to go into leap. There are many reasons why a maintainer may not want to update a version in leap.
Since I am getting review reminders from staging-bot for this request, I am wondering whether I have to take action?
If you are happy for this change to go into Leap 42.3 you should accept the request, if you are not happy for the change to go in you should decline the request (probably with a reason explaining why) -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B
Am Sonntag, 11. Juni 2017, 21:07:25 CEST schrieb Simon Lees:
On 11/06/17 19:21, Jan Ritzerfeld wrote: [...] When someone who is not a maintainer of a given package submits that package into leap the request needs to be reviewed by the maintainers (in this case yourself) to check that they are happy for a new version of that package to go into leap.
Yes, and it was actually myself who forwarded the original request to Leap. There is now a checkbox for forwarding it to Leap when submitting to Factory, isn't it? So it seems that I got a little bit confused and thought that "someone who is not maintainer in the devel project" has to review it before it can be included in Leap. However, it makes sense now after realizing that Leap gets it packages from the devel projects directly.
There are many reasons why a maintainer may not want to update a version in leap. [...]
Yes, and I have read some articles about that before I forwarded the request and I haven't found anything against including this small update in Leap. Thanks Jan -- Any code of your own that you haven't looked at for six or more months, might as well have been written by someone else. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (3)
-
Jan Ritzerfeld -
Martin Pluskal -
Simon Lees